From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB4E2A0A0F; Wed, 30 Jun 2021 08:49:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A5DA40040; Wed, 30 Jun 2021 08:49:41 +0200 (CEST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 7557F4003C for ; Wed, 30 Jun 2021 08:49:40 +0200 (CEST) Received: by mail-io1-f42.google.com with SMTP id g22so1932183iom.1 for ; Tue, 29 Jun 2021 23:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ii9X2Vcz3Hx7d5moWHpCUd5ooL0JOu2g837/QMrf+0=; b=Hq67Ikl8ZIqIIvG4sw+qQmkInqVj0hrtnSQLsjoJl8ykeZZbBR3oslGyhVbfQ+zFIC Xz515Rxi1aJVgVagwmThZjzYaMN7/ZFrIBpr1ONaegpMRSm5KGKwC7T1HR8nugZq4lgI RUwXwIjqYvZ2FYFw0t9y+nO2GpJ6VAGcFbN9baPRRhcuBEP7cb+ZT42so12E5bIaD0T1 JLhzI0OXQf7Wrsgiia5gBXOxl47r+vANP++yOvqfBZh0MCCAGiTiuyQ7dhS+d403azTc 3/HGr7SfF+NAzn+gtsrQvLhB55UgFChBZwvQaNupS3LPLwhn5eJQPbQRfn1xWmLemb6A /E4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ii9X2Vcz3Hx7d5moWHpCUd5ooL0JOu2g837/QMrf+0=; b=jqhiLEWkzRGxY4NEbZUC4hHXhgbgTWf/hJ3Nx7czoLbDruQskWtvkP0w1bT7L0K/Kz odi5c5N97WHkQvIkrva/kPuLUT0Z9CekZ5v9UPViWqmuVxe77rKs0jXxPl9j67x6UMgo iHqP0rcxsRzu4yMgcyO7NbTNoUdyYR4lXqoIh0eRsFGpjHluJGEQ49hJ7WLgKVim5sA8 w6hkaK665+l8Q+na5eV9b6HYWzkQL0ME4HR/O3Jwv7owymzZRamrK4cM99NTR+wVbLVh TI7SMnMYv22EZpE9NJmw9gMOovy06VPwoNiqM59uN2WRgFoCjd2FXlSVltfVErfAqH+t 1eNg== X-Gm-Message-State: AOAM531osSgZke+u+4wR6uxKlZHgbrCtRnjY7BmLnHt4ElqIYsJjqihO usKH/6AjoNfh6HRDIzmipvO41eKw7UM9HX2gM2A= X-Google-Smtp-Source: ABdhPJzENJWfnuL1c+yfHIzl3F67G0vpj2wT5ZtS1SHyWoaWYsOabQ+hvmiyeLPoXYlPBn1Mk+pconF8meuMGul58rg= X-Received: by 2002:a5e:a80b:: with SMTP id c11mr6923308ioa.94.1625035779901; Tue, 29 Jun 2021 23:49:39 -0700 (PDT) MIME-Version: 1.0 References: <20210510061148.1674641-1-feifei.wang2@arm.com> In-Reply-To: <20210510061148.1674641-1-feifei.wang2@arm.com> From: Jerin Jacob Date: Wed, 30 Jun 2021 12:19:14 +0530 Message-ID: To: Feifei Wang Cc: Jerin Jacob , dpdk-dev , nd , Ruifeng Wang , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] app/eventdev: remove unnecessary barrier for order test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 10, 2021 at 11:42 AM Feifei Wang wrote: > > For "order_launch_lcores" function, wmb after that the main lcore > updates the variable "t->err", which represents the end of the test > signal, is unnecessary. Because after the main lcore updates this > siginal variable, it will jump out of the launch function loop, and wait > other lcores stop or return error in the main function(evt_main.c). > During this time, there is no storing operation and thus no need for > wmb. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > app/test-eventdev/test_order_common.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c > index 04456d56db..d7760061ba 100644 > --- a/app/test-eventdev/test_order_common.c > +++ b/app/test-eventdev/test_order_common.c > @@ -308,7 +308,6 @@ order_launch_lcores(struct evt_test *test, struct evt_options *opt, > rte_event_dev_dump(opt->dev_id, stdout); > evt_err("No schedules for seconds, deadlock"); > t->err = true; > - rte_smp_wmb(); > break; > } > old_remaining = remaining; > -- > 2.25.1 >