From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 645CB44100; Wed, 29 May 2024 10:02:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 008FD402CD; Wed, 29 May 2024 10:02:08 +0200 (CEST) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by mails.dpdk.org (Postfix) with ESMTP id C863F402B9 for ; Wed, 29 May 2024 10:02:06 +0200 (CEST) Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3d11ed39dbbso983067b6e.2 for ; Wed, 29 May 2024 01:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716969726; x=1717574526; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Sp87q6fgPh/yUY6LpGEE+yp5QNt/1RC6KP+pFprLPKA=; b=AScby4ZbfnXKUvVALj7gSQhsQoa4AQdtgpDhNVr8trTHJsE9FEqZeZDVdGnH9r4Ymm 4LgzcSzBlxwyXqb72+Dg/iXROAnwXZhMtl8kW/3o0u3GysEGgcMsY68nNZIvBpjtuEmh iiRbIrIIsKcy4nGOryQlJDmIX7Yn66iQL5FP+Uv/j/7rPv3tyWO3I4OYmCgXIzcrWwu5 OO9C8M7GNXjb52pG3uOc7/dTvypWUw/sChPUu0X5tXs+DkUUVbH+bYvOJovhgPNxE76O tLmbbaq3/+On5QnEhe0OtKqtOT9e7j977aDR7mb1TED1wTquTcUhPQrnEDTcRxZeWFDJ EaWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716969726; x=1717574526; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sp87q6fgPh/yUY6LpGEE+yp5QNt/1RC6KP+pFprLPKA=; b=hN+I4LQhooecTvPtW8hnLLrcuYmrTdzL4I8MdHRSd8iPzSbNFKkTH3TJkr8YKQ9Zf/ Vhki6Pjh2oevU8nMB8BVdw5BroC7aRrHDqAt/pvpLlZeSQINCgdDtP+VsXnwIKT9RdGM xA3z8HAQr/klL3Mo4ndCz/uWK3YYmMbRC+42tM3kg0878KaqXsoNGQlbuxtQguaa/VHP +ennX/tK6Nz24E7reGPzZSkj7WgXvOfEqfmdPgnfPNFV952enTphLTOcYxE5OpPbvJiS Dz7GbwmwX7Ad8n6tOy9fRSr3bD3rW8wEdTsBhstclfRt29RxCzFl5JjOgOvJAOV7bWmE l8og== X-Forwarded-Encrypted: i=1; AJvYcCWdn98Cuqh0InOu8O0VRnhViX5QXMSxrXBW1erTYjCtSez89OhGL61DIMndgN9CMYEqEzvp6x/gutm3IoM= X-Gm-Message-State: AOJu0YyJ/Bc3VGtXK5gqm60NbW0YT2352gUaBED7GfTmnqtWff+nlYo3 kIRrQ/R1MuPOAtwnxCU0l0eSyfmzX78nQspWyb/qrqgDAyUfDOcirioRZ8ssaUmzBzwN3vomBQm JL6iy3ROoRUg7E4N8XZ3FbFiuFCA= X-Google-Smtp-Source: AGHT+IHCrDGWrWSf3rh9d1my7OAepUw9UZIAoHH1SzkUqHiM2qNsG7s7phlfX6GMgU0vrSNvd6t/lmUG/o0VeiLxTvI= X-Received: by 2002:a05:6808:2a09:b0:3c9:6b7a:f3c4 with SMTP id 5614622812f47-3d1a5c31413mr15282853b6e.26.1716969725775; Wed, 29 May 2024 01:02:05 -0700 (PDT) MIME-Version: 1.0 References: <20240522192139.3016-1-pbhagavatula@marvell.com> <20240527153431.6663-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 29 May 2024 13:31:39 +0530 Message-ID: Subject: Re: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files To: Pavan Nikhilesh Bhagavatula Cc: Bruce Richardson , Jerin Jacob , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Harman Kalra , Shijith Thotton , Anatoly Burakov , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 28, 2024 at 3:31=E2=80=AFPM Pavan Nikhilesh Bhagavatula wrote: > > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, May 28, 2024 3:10 PM > > To: Pavan Nikhilesh Bhagavatula > > Cc: Jerin Jacob ; Nithin Kumar Dabilpuram > > ; Kiran Kumar Kokkilagadda > > ; Sunil Kumar Kori ; Satha > > Koteswara Rao Kottidi ; Harman Kalra > > ; Shijith Thotton ; Anatoly > > Burakov ; dev@dpdk.org > > Subject: Re: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template = files > > > > On Tue, May 28, 2024 at 09:23:12AM +0000, Pavan Nikhilesh Bhagavatula > > wrote: > > > > On Mon, May 27, 2024 at 09:04:29PM +0530, > > pbhagavatula@marvell.com > > > > wrote: > > > > > From: Pavan Nikhilesh > > > > > > > > > > Disable building template files when CNXK_DIS_TMPLT_FUNC is defin= ed > > > > > as a part of c_args. This option can be used when reworking data= path > > > > > or debugging issues to reduce Rx/Tx path compilation time. > > > > > > > > > > Example command: meson build -Dc_args=3D'-DCNXK_DIS_TMPLT_FUNC' > > > > > -Dexamples=3Dall --cross-file config/arm/arm64_cn10k_linux_gcc > > > > > > > > > Should this option be set in CI by default, or in test-meson-builds= by > > > > default? When do we need to avoid setting this flag, vs setting it? > > > > > > > > > > Yes, we can set this option when testing builds to speed things up. = We > > > would want to avoid setting the flag when we are packaging or generat= ing > > > release binaries as it will negatively affect fastpath performance. > > > > > > I am not sure how to integrate to test-meson-builds as there is no ta= rget > > > option for cn10k/cn9k. > > > > > So, are these template files already not built when building for other > > platforms other than cn10k/cn9k? > > I rechecked they are only built when target is aarch64. Bruce, planning to merge this patch. Please let me know if there is a difference in opinion.