DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	 Pavan Nikhilesh <pbhagavatula@marvell.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix build on arm64
Date: Wed, 30 Oct 2019 17:12:45 +0530	[thread overview]
Message-ID: <CALBAE1O=L-kShF1tdxZnjsgj4QW-occDGsRHQtg+=+JtV2py_Q@mail.gmail.com> (raw)
In-Reply-To: <20191028112535.692-1-alialnu@mellanox.com>

On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alialnu@mellanox.com> wrote:
>
> OcteonTx was disabled for causing an internal compiler error on old gcc
> versions.
> See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
>
> The condition that was added later to apply disabling OcteonTx
> only on arm64 caused the condition to never be obeyed because it
> compares ["arm64"] to [arm64].
>
> This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
> because the former has the quotes removed, while the later doesn't.
>
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

> ---
>  mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
> index ea40a11c0..00d6fd642 100644
> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> @@ -99,7 +99,7 @@ else
>         endif
>
>         # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64
> -       ifeq ($(CONFIG_RTE_ARCH), arm64)
> +       ifeq ($(RTE_ARCH), arm64)
>         ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
>                 CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
>                 CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> --
> 2.23.0
>

  parent reply	other threads:[~2019-10-30 11:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 11:25 Ali Alnubani
2019-10-28 11:25 ` [dpdk-dev] [PATCH 2/2] mk: disable OcteonTx2 on old compilers Ali Alnubani
2019-10-30 11:49   ` Jerin Jacob
2019-10-28 16:34 ` [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 Thomas Monjalon
2019-10-30 11:42 ` Jerin Jacob [this message]
2019-11-04 13:30 ` [dpdk-dev] [PATCH v2 " Ali Alnubani
2019-11-04 13:30   ` [dpdk-dev] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers Ali Alnubani
2019-11-08 15:32     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1O=L-kShF1tdxZnjsgj4QW-occDGsRHQtg+=+JtV2py_Q@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=alialnu@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).