From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] meson support of armv8 crypto PMD
Date: Thu, 3 Oct 2019 12:00:39 +0530 [thread overview]
Message-ID: <CALBAE1OA-LmtpbEBLPWnfPPaPY7pduuR5smX5mAN1rj4eGTJjw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zud76Sqt+5_BfSYshB5kLiy8tGNStneepuWE0eCSrB3A@mail.gmail.com>
On Wed, Oct 2, 2019 at 4:09 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Wed, Oct 2, 2019 at 11:19 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Wed, Oct 2, 2019 at 10:56 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > There is no meson support for drivers/crypto/armv8/
> > >
> > > Please, who can add it?
> >
> > From my side, I would love to get detailed instructions on cross
> > compiling the external library "armv8_crypto".
>
> Something has been broken in this library.
> Current HEAD won't compile, went back to some reference Thomas had in his setup.
>
> d498a6f - (HEAD -> master, origin/master, origin/HEAD) crypto/armv8:
> ILP optimizations for AES128CBCdec+SHA256 HMAC (2 years, 7 months ago)
> <Zbigniew Bodek>
>
> Won't compile.
>
> 71258fb - Makefile: remove DPDK dependency (2 years, 9 months ago)
> <Zbigniew Bodek>
>
> Builds fine.
>
>
> Please someone fix this library and/or the documentation we have in dpdk.
I have fixed the 'native' build issue. We will add cross-compilation
support and update the library README.
I was expecting a similar issue and I was against creating a separate
library to have an unnecessary
dependency. This library was soley meant for DPDK so there was no
technical reason for making it
a separate library. I don't believe the external libraries are really
open source way of doing the stuff.
I think the argument to keep the external library was
- Crypto export license issues.
- Assembly code is diffcult to understand and therefore maintain it.
> Thanks.
>
>
> --
> David Marchand
>
next prev parent reply other threads:[~2019-10-03 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 8:55 Thomas Monjalon
2019-10-02 9:19 ` David Marchand
2019-10-02 10:38 ` David Marchand
2019-10-03 4:23 ` Honnappa Nagarahalli
2019-10-03 6:30 ` Jerin Jacob [this message]
2019-10-02 9:36 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OA-LmtpbEBLPWnfPPaPY7pduuR5smX5mAN1rj4eGTJjw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).