Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function

[Jerin Jacob <jerinjacobk@gmail.com>]

On Tue, Aug 3, 2021 at 11:35 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
> >
> > Currently there is a dedicated modify function for each
> > field that the application wants to change.
> > For example:
> > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
> > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
> >
> > A new function rte_flow_action_modify_field DPDK added the ability
> > to use the same function to modify any field, in addition to be able to
> > modify the value based on different field and not just immediate value.
> >
> > Signed-off-by: Ori Kam <orika@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


>
> > ---
> > V2:
> >   Fix typo.
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 3 +++
> >  1 file chanAcked-by: Jerin Jacob <jerinj@marvell.com>
ed, 3 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index b530616281..77491c322f 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -162,3 +162,6 @@ Deprecation Notices
> >  * ethdev: The struct ``rte_flow_action_modify_data`` will be modified
> >    to support modifying larger fields than 64 bits.
> >    In addition, documentation will be updated to clarify byte order.
> > +
> > +* ethdev: Announce moving from dedicated modify function for each field,
> > +  to using the general ``rte_flow_modify_field`` action.
> > --
> > 2.25.1
> >