From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74DF1A0547; Sat, 7 Aug 2021 15:34:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63AA240691; Sat, 7 Aug 2021 15:34:10 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id D5ED74003D for ; Sat, 7 Aug 2021 15:34:09 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id f11so17910721ioj.3 for ; Sat, 07 Aug 2021 06:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8r1qkuvdmOxmtnnpRKkpQOsLqyN6yIIsrdBpU3F/AJA=; b=TeleU+uSFkwU2XaEs/581Du16hV3NY8tNDCPKRQbFhmjutqKzt3PsFDucizIeDDui8 DhOgIaSPHzAiydDOsAzarmlx99KLwO3DUKHHNpSI3iYbX16HSbWOnmCeqZ4zddHD04Ai tPC2u3jS3Eg0ifJT0W92Uq+Xfva0vh07NecjfJ+vFg5Gz2KprDTkvTEnWBJE+iZi25m3 1c65h5uq82LC/tsAhC3c81YciCfEFf0XLu8+c9shMAqhdFSmS33eq15O1SBguA5r63yU YOMx3DvDRtdmUWYYb8p4fPRIBbnkW+v0mBqqG4HfXS88iVNozvJEwC2G9SItAknyzjHk efUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8r1qkuvdmOxmtnnpRKkpQOsLqyN6yIIsrdBpU3F/AJA=; b=IvuIOhz1exacpPfeopQ+D8ALHdwzQZsAWLWJVvZSfPR6bQ6YpvhjDCVprV7lTNVKdU jmsuv21BpLN97ajq498rvF4/yyRU0KcXyXUIZKcJ90UlVOq2wmsfCD9KSSBxOmHw05hy 0Uu7Bz2OHQUgMIjSi8SBVUegy3pENPM+D916iUUU8E4zqpCNBtpgfSLhucFWDAh+kCpy /9sVUdj+Q6m+cfSQhjsrAlYapVhis1/Ds4oq59zfdWm+zDetdGgRyoHuMSXYwHbYViNE +2+mjiI74eIGiHLcAeP/9NqyWMJYzJ6DKfsMIw51uUzAb37QPzdF/W/s8HfYY7ZGoUDl xSbw== X-Gm-Message-State: AOAM532JojVANiIuzT+A/vPZZypx8LAfZuj6PIVCrk85rdTWF1WmH3eY ZbYOdkSfXG0+bX13VOYztndtg6r4pULOdBFLgRc= X-Google-Smtp-Source: ABdhPJwxuy0VStAYCWEAiLBhhf69U1QpLm4wwcFKC6FPjblgwcBTrcwYdAcMZfTPdASfUsSsrQ2ygXsVFp8Ep1PKCQY= X-Received: by 2002:a05:6638:214d:: with SMTP id z13mr14415758jaj.113.1628343249318; Sat, 07 Aug 2021 06:34:09 -0700 (PDT) MIME-Version: 1.0 References: <20210802141004.353754-1-matan@nvidia.com> <20210803085754.643180-1-orika@nvidia.com> <20210803085754.643180-2-orika@nvidia.com> In-Reply-To: From: Jerin Jacob Date: Sat, 7 Aug 2021 19:03:43 +0530 Message-ID: To: Ajit Khaparde Cc: Ori Kam , Thomas Monjalon , Andrew Rybchenko , Ray Kinsella , dpdk-dev , Slava Ovsiienko , Ferruh Yigit , Matan Azrad , Raslan Darawsheh , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 3, 2021 at 11:35 PM Ajit Khaparde wrote: > > On Tue, Aug 3, 2021 at 1:58 AM Ori Kam wrote: > > > > Currently there is a dedicated modify function for each > > field that the application wants to change. > > For example: > > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. > > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4. > > > > A new function rte_flow_action_modify_field DPDK added the ability > > to use the same function to modify any field, in addition to be able to > > modify the value based on different field and not just immediate value. > > > > Signed-off-by: Ori Kam > > Acked-by: Matan Azrad > Acked-by: Ajit Khaparde Acked-by: Jerin Jacob > > > --- > > V2: > > Fix typo. > > --- > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file chanAcked-by: Jerin Jacob ed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index b530616281..77491c322f 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -162,3 +162,6 @@ Deprecation Notices > > * ethdev: The struct ``rte_flow_action_modify_data`` will be modified > > to support modifying larger fields than 64 bits. > > In addition, documentation will be updated to clarify byte order. > > + > > +* ethdev: Announce moving from dedicated modify function for each field, > > + to using the general ``rte_flow_modify_field`` action. > > -- > > 2.25.1 > >