From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E40DA0597; Thu, 9 Apr 2020 15:10:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83DC11C225; Thu, 9 Apr 2020 15:10:53 +0200 (CEST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by dpdk.org (Postfix) with ESMTP id 037DF1C19F for ; Thu, 9 Apr 2020 15:10:51 +0200 (CEST) Received: by mail-il1-f174.google.com with SMTP id t10so4959098iln.2 for ; Thu, 09 Apr 2020 06:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HkyDLjMSX3LxkjkLIvEvatdct4R9iK4obF3G78OcUf8=; b=JJ+HocLVBTyQ85H66nzNig0Lx63npMDsfGwPytcba8f4T05Bi8CgQ4FoDIF/METhlP +14LdWa9MlfNfQGwoksCZpR3G4ds3WE06AOFaDpUfG0OPxe5EOAg4iZYQVRwWIcaORPY jHHTIc/55kYuXs7r2BinxdOD3jpT5+0GxT+vaEl622QRRJxxcrgp1eEI2GVLI0Pv5R3z Ap1kYwfmEBeRULmNY04CV3vEWAzOyngS+ZJOLnmvvCJ2Rei28tT7uLP1jjIuodXNGGDf tJHB7WgKIJxPbUvC+RW7q8IJ67AdBonyaHwVbpmEZLZDFmKIOupoB2aVnTSTMBPRlW7z oCuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HkyDLjMSX3LxkjkLIvEvatdct4R9iK4obF3G78OcUf8=; b=dRaSkMkkvhf5L2tCsT44R7c7+MJVKeo3WDLwrw1ZYx/FR0zMBpEFl0F1Kojm0/VBAN zd3o9Gg3fj9S3UglLFoLuBDVBOtT0uqaJ43N6pjBSUBFoDVk6R5RakIFPxmg5SGFOzOS gJBwKZia6Gd+Cqy86870I7bR7gSdZ3hxAMIV+4W+f0l2vSZBpAVnJVKVXCz5Dqoajsi+ PRTsQFlh/Zcn5D1urbxukF0MXqc+G52MpLKjquAOrFmxEynbbhdImtMzPqTR3WwsXVPm 9XNHr7Rauad/SA6ehD9sPuK2HBMMeAWlpW9KyCdZ45J7RzWBbNu3LTysAAOT1xxW4vlZ 8jUA== X-Gm-Message-State: AGi0PualLbhXXJcSqoxoFakYEM9NTAAB67rlNG8qqXWuo6NGuagS/6J3 MI2LzSaquwBRwjO9uqFmaIUdIX8KSjC9W0V0ZqU= X-Google-Smtp-Source: APiQypKcMv0qc85TMJ8l0luyYPc5hOK8jC14kI9Maq3yeSBp0EfndwWKVBeeXmds+6c6nEOh8tVhMqcpALQgKGAnX60= X-Received: by 2002:a92:48cb:: with SMTP id j72mr13276668ilg.162.1586437851271; Thu, 09 Apr 2020 06:10:51 -0700 (PDT) MIME-Version: 1.0 References: <0e082fc8-c60c-f62b-ef22-4b453e193567@intel.com> In-Reply-To: <0e082fc8-c60c-f62b-ef22-4b453e193567@intel.com> From: Jerin Jacob Date: Thu, 9 Apr 2020 18:40:35 +0530 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Thomas Monjalon , David Marchand , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > * tracing library > * Some concerns on the API, it is copy/paste of log API The following API signatures are taken from log API. 1) void rte_trace_global_level_set(uint32_t level); 2) uint32_t rte_trace_global_level_get(void); 3) uint32_t rte_trace_level_get(rte_trace_t trace); 4) int rte_trace_level_set(rte_trace_t trace, uint32_t level); 5) int rte_trace_pattern(const char *pattern, bool enable); 6) int rte_trace_regexp(const char *regex, bool enable); I have intentionally kept public API similar to rte_log wherever it is possible. Reason being, 1) In the future, it is easy to replace rte_log with trace _if needed_. 2) Avoid the new API learning curve. 3) I did not find anything wrong with the existing log API to improve on at least on API that selected to copy the prototype. If there are specific comments on why we need to take the deviation from log API on the above schematics. I am happy to change it. > * Lacking more reviews Just FYI: There is enough documentation on the programming model and implementation details if someone likes to kick start the review. http://patches.dpdk.org/patch/67792/