From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E24BA034E; Tue, 22 Feb 2022 10:51:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B911340DF6; Tue, 22 Feb 2022 10:51:15 +0100 (CET) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 43EC040DF4 for ; Tue, 22 Feb 2022 10:51:14 +0100 (CET) Received: by mail-io1-f45.google.com with SMTP id r7so13973257iot.3 for ; Tue, 22 Feb 2022 01:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YbRm7jo6Uu0iHCYoxrQv6rex2FDz7JISEpJgu8NTEVk=; b=acH/Jm+mLHUZ+UqglhoOSVisSqstpfHdgwxcJKnv1ayVxYVEb62qMdsIXDyPenwtKj jY185CHZxrEgWBQjweFTnP6fAhN+E3fyKl0Vc9WqBBdkXmr/eQijb5nW9QHz5/W+Q5TB SXskjf6fmfyYeTjlHt1F/VyOrg/h6NOPX7+sC4dulNf3CClXKHH2tamO7bUSTpzs5bvK WjePpX10NYr3H4P1EaO/S2blRhzumevb6bWpcLzDxkkGCdp5xCvp31u+/+/B7bM47lYZ S3z5EOayBbia5sEMx30M7RdYbCWb5OXsc0ZdAqZpwjw5z67pUdKETo5utoyVuxoomgFf yuTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YbRm7jo6Uu0iHCYoxrQv6rex2FDz7JISEpJgu8NTEVk=; b=5lYp4oW7iyOBX3ii4rwJnd5Q0xRhRTu+vfo6tCRskxBR0pExX5UxdUzGhJCN/YfbJh KEy2sziVHHpStYc7YoH3yxwhbLqCv3A6cZA5SyPZmPlnt1p2rz44EdY1kqmmAz9NYFp6 sXo2yAZ1Nw3YI7rKgkR+tKKk57ekMwXpgIZKzXUhooc1coZMGIu/SvK92RQIbCpEtCuL UgIxSxGjUk/b/z3wxgfqhaIoMsZAVNHJFJ5NtrY0sLK0KOkYu9lVAZpZoiAiu4G/KFvp 5OC7jvRBIh6qpX3yrixPk1Xqnw/fcLks/1dNPN5mZX4bRzbOmmPgMZIBiJmZYtVNpjBA y8IQ== X-Gm-Message-State: AOAM533Qxc3GlzquqvBVd7+SbdAPku0+C3R3TUmcxxmmkMN+DbJHtHGR pz/plAIU0HSfQPaAmQbJGEqz/ubrAyK8C6GcXICFsk1Cyw1hNQ== X-Google-Smtp-Source: ABdhPJwublilDlmPBtl3jLeqWayV/EEx3+P0GDNx/ihFmc2V0LCzZI+4/avNroB1X3z1S+HLN5OUKSdWvp+OHIEAE6M= X-Received: by 2002:a02:604f:0:b0:30f:e6f1:3883 with SMTP id d15-20020a02604f000000b0030fe6f13883mr18311370jaf.266.1645523473444; Tue, 22 Feb 2022 01:51:13 -0800 (PST) MIME-Version: 1.0 References: <20220212123948.3394407-1-gmuthukrishn@marvell.com> In-Reply-To: <20220212123948.3394407-1-gmuthukrishn@marvell.com> From: Jerin Jacob Date: Tue, 22 Feb 2022 15:20:47 +0530 Message-ID: Subject: Re: [PATCH 1/3] event/cnxk: fix incompatible casting of variables To: Gowrishankar Muthukrishnan Cc: dpdk-dev , Pavan Nikhilesh , Shijith Thotton , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 12, 2022 at 6:10 PM Gowrishankar Muthukrishnan wrote: > > Fix incompatible casting on variables reported by coverity scan. Series applied to dpdk-next-net-eventdev/for-main. Thanks > > Fixes: 6223ede2036 ("event/cnxk: add event port link and unlink") > Coverity issue: 370582 370584 > > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/event/cnxk/cn10k_eventdev.c | 4 ++-- > drivers/event/cnxk/cn9k_eventdev.c | 11 ++++------- > 2 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c > index 7b7ce44c74..2bcf5066c4 100644 > --- a/drivers/event/cnxk/cn10k_eventdev.c > +++ b/drivers/event/cnxk/cn10k_eventdev.c > @@ -98,10 +98,10 @@ cn10k_sso_hws_release(void *arg, void *hws) > { > struct cnxk_sso_evdev *dev = arg; > struct cn10k_sso_hws *ws = hws; > - int i; > + uint16_t i; > > for (i = 0; i < dev->nb_event_queues; i++) > - roc_sso_hws_unlink(&dev->sso, ws->hws_id, (uint16_t *)&i, 1); > + roc_sso_hws_unlink(&dev->sso, ws->hws_id, &i, 1); > memset(ws, 0, sizeof(*ws)); > } > > diff --git a/drivers/event/cnxk/cn9k_eventdev.c b/drivers/event/cnxk/cn9k_eventdev.c > index 4611936b7f..3413467edc 100644 > --- a/drivers/event/cnxk/cn9k_eventdev.c > +++ b/drivers/event/cnxk/cn9k_eventdev.c > @@ -97,24 +97,21 @@ cn9k_sso_hws_release(void *arg, void *hws) > struct cnxk_sso_evdev *dev = arg; > struct cn9k_sso_hws_dual *dws; > struct cn9k_sso_hws *ws; > - int i; > + uint16_t i; > > if (dev->dual_ws) { > dws = hws; > for (i = 0; i < dev->nb_event_queues; i++) { > roc_sso_hws_unlink(&dev->sso, > - CN9K_DUAL_WS_PAIR_ID(dws->hws_id, 0), > - (uint16_t *)&i, 1); > + CN9K_DUAL_WS_PAIR_ID(dws->hws_id, 0), &i, 1); > roc_sso_hws_unlink(&dev->sso, > - CN9K_DUAL_WS_PAIR_ID(dws->hws_id, 1), > - (uint16_t *)&i, 1); > + CN9K_DUAL_WS_PAIR_ID(dws->hws_id, 1), &i, 1); > } > memset(dws, 0, sizeof(*dws)); > } else { > ws = hws; > for (i = 0; i < dev->nb_event_queues; i++) > - roc_sso_hws_unlink(&dev->sso, ws->hws_id, > - (uint16_t *)&i, 1); > + roc_sso_hws_unlink(&dev->sso, ws->hws_id, &i, 1); > memset(ws, 0, sizeof(*ws)); > } > } > -- > 2.25.1 >