DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Linhaifeng <haifeng.lin@huawei.com>
Cc: Gavin Hu <Gavin.Hu@arm.com>, "dev@dpdk.org" <dev@dpdk.org>,
	 "thomas@monjalon.net" <thomas@monjalon.net>,
	chenchanghu <chenchanghu@huawei.com>,
	 xudingke <xudingke@huawei.com>,
	"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
	 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	Steve Capper <Steve.Capper@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0
Date: Tue, 10 Mar 2020 14:33:15 +0530	[thread overview]
Message-ID: <CALBAE1OBT2naWoMkJECM4iao40Ee=LuBmZCu1KYmP4ziwyg3jw@mail.gmail.com> (raw)
In-Reply-To: <4099DE2E54AFAD489356C6C9161D53339729F575@DGGEML502-MBX.china.huawei.com>

On Tue, Mar 10, 2020 at 1:39 PM Linhaifeng <haifeng.lin@huawei.com> wrote:

Please change the subject to  more meaningful one: Something like,

eal/arm64: fix rdtsc precise version

> We should use isb rather than dsb to sync system counter to cntvct_el0.

Please tell "why" in commit message, something like this

In order to get more accurate the cntvct_el0 reading, SW must invoke  .....

Add Fixes: as well.

# Make sure it is passing ./devtools/checkpatches.sh and
./devtools/check-git-log.sh

>
> Reference of linux kernel:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220
>
> Signed-off-by: Haifeng Lin <haifeng.lin@huawei.com>
> ---
>  .../common/include/arch/arm/rte_atomic_64.h   |  3 +++
>  .../common/include/arch/arm/rte_cycles_64.h   | 20 +++++++++++++++++--
>  2 files changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> index 859ae129d..2587f98a2 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
> @@ -21,6 +21,7 @@ extern "C" {
>
>  #define dsb(opt) asm volatile("dsb " #opt : : : "memory")
>  #define dmb(opt) asm volatile("dmb " #opt : : : "memory")
> +#define isb()    (asm volatile("isb" : : : "memory"))
>
>  #define rte_mb() dsb(sy)
>
> @@ -44,6 +45,8 @@ extern "C" {
>
>  #define rte_cio_rmb() dmb(oshld)
>
> +#define rte_isb() isb()

As David said, Don't add rte_ public symbols from header files.

> +
>  /*------------------------ 128 bit atomic operations -------------------------*/
>
>  #if defined(__ARM_FEATURE_ATOMICS) || defined(RTE_ARM_FEATURE_ATOMICS)
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h b/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
> index 68e7c7338..bc4e3f8e6 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
> @@ -18,6 +18,7 @@ extern "C" {
>   *   The time base for this lcore.
>   */
>  #ifndef RTE_ARM_EAL_RDTSC_USE_PMU
> +
>  /**
>   * This call is portable to any ARMv8 architecture, however, typically
>   * cntvct_el0 runs at <= 100MHz and it may be imprecise for some tasks.
> @@ -59,11 +60,26 @@ rte_rdtsc(void)
>  }
>  #endif
>
> +#define arch_counter_enforce_ordering(val) do {                                                \
> +       uint64_t tmp, _val = (val);                                                                             \
> +                                                                                                                                       \
> +       asm volatile(                                                                                                   \
> +       "       eor  %0, %1, %1\n"                                                                                      \
> +       "       add  %0, sp, %0\n"                                                                                      \
> +       "       ldr  xzr, [%0]"                                                                                         \
> +       : "=r" (tmp) : "r" (_val));                                                                             \
> +} while (0)

Please use static  inline function and change the name to
__rte_arm64_cntvct_el0_enforce_ordering() or so

> +
>  static inline uint64_t
>  rte_rdtsc_precise(void)
>  {
> -       rte_mb();
> -       return rte_rdtsc();
> +       uint64_t tsc;
> +
> +       rte_isb();
No need for new marco, If you think, it is needed make it as
__rte_arm64_isb() or so

> +       tsc = rte_rdtsc();
> +       arch_counter_enforce_ordering(tsc);
> +       return tsc;
>  }
>
>  static inline uint64_t
> --
> 2.24.1.windows.2

  parent reply	other threads:[~2020-03-10  9:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  8:09 Linhaifeng
2020-03-10  8:25 ` Gavin Hu
2020-03-10  9:03 ` Jerin Jacob [this message]
2020-03-10  9:38   ` Linhaifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1OBT2naWoMkJECM4iao40Ee=LuBmZCu1KYmP4ziwyg3jw@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=Gavin.Hu@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Steve.Capper@arm.com \
    --cc=chenchanghu@huawei.com \
    --cc=dev@dpdk.org \
    --cc=haifeng.lin@huawei.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).