From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBA6FA0032; Fri, 18 Feb 2022 14:57:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A670B40150; Fri, 18 Feb 2022 14:57:45 +0100 (CET) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mails.dpdk.org (Postfix) with ESMTP id A127F40141 for ; Fri, 18 Feb 2022 14:57:43 +0100 (CET) Received: by mail-io1-f46.google.com with SMTP id s1so7589541iob.9 for ; Fri, 18 Feb 2022 05:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PMMvQBZaGhMD7VyN53sDAOZBqO3zuqt0n5JR45EPPdw=; b=QshOIIautBLz8+EwMYyRYe8TMPzdsNiFDOAKNDrS4aMNN9clE99i+cy0Fqcm+fl6j4 FuF/y/ds8AqY9AHI6Lp9tDCesyQv18De6gRntV06Qvs/b6xENmz6UDWJJd3mmBaVeXwP keEorKnJ1JSJLdRB03qCbZJCck2zfpETTyrzpAlugt2EmAztREjECgJxwAXoYXfiH4HV /H21zF+30mSUk3hRhzibLHxyzZLfh2OdEpjfq8T/zaeBaL9wPuIPCsDM/gQ25xXPzXpG lEkObNJLNMJCMuu3G1NnAb7G3g34rldmPLTF1kccd9ONmc37fBXgAFXglqyYhyAyEoMp yIaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PMMvQBZaGhMD7VyN53sDAOZBqO3zuqt0n5JR45EPPdw=; b=F0Km/pO2C6QMXijkYBNsCc6ZKqViFAxjl7YDb/Yl6+G/Dg9A3B8bUWPoRxAe0wJRa2 bj67XY+e5RtaoOfj8iWnkxXW3uVl07akVCHfzxwntS1RTAha/i96SMF7ZSXOuMS8XvTR QJ+kSVz6QfRsyoQqiKh2HPPSyea7Dz3D0kcJkjCD9qWAJvufT+t03ibS2cq4CN8ixmx5 S+gReqsDKLhOdDfjox1XhiWrSnS6RIq6F1MyQnPkH2a0jwOzc1kqVTfEr3SEnn1kxsQi 2vUg0MbH0d7eLuStI7+VfVR0QNw5EzEPtytGQudp+OmR44z+4E7Si2AbxYcDbieNaPSb cKqg== X-Gm-Message-State: AOAM532LoRNv9VT6RgGBIlt+OB6L74XTD52tyodGj3rN/InrHbmmSW2A 3GYG0lTZgwHqLk9UeEPWSUs3wpLhkPWI/1jr5bg= X-Google-Smtp-Source: ABdhPJxW/aTZ8eV9LYGU9DSAkninRdhitfKb6gobgqj8JelLAea2mmIM4NrIoaBOSy49OXfYvM/uWpGOSheRyKoRrkw= X-Received: by 2002:a05:6602:3406:b0:640:4192:e649 with SMTP id n6-20020a056602340600b006404192e649mr5475725ioz.160.1645192663061; Fri, 18 Feb 2022 05:57:43 -0800 (PST) MIME-Version: 1.0 References: <20220209050925.1552306-1-s.v.naga.harish.k@intel.com> <20220214171016.961658-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Fri, 18 Feb 2022 19:27:17 +0530 Message-ID: Subject: Re: [PATCH v2] eventdev/eth_rx: fix queue config get logic To: "Jayatheerthan, Jay" Cc: "Naga Harish K, S V" , "jerinj@marvell.com" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 15, 2022 at 10:24 PM Jayatheerthan, Jay wrote: > > Looks good. Thanks! > > Acked-by: Jay Jayatheerthan Applied to dpdk-next-net-eventdev/for-main. Thanks > -Jay > > > > > -----Original Message----- > > From: Naga Harish K, S V > > Sent: Monday, February 14, 2022 10:40 PM > > To: Jayatheerthan, Jay ; jerinj@marvell.com > > Cc: dev@dpdk.org > > Subject: [PATCH v2] eventdev/eth_rx: fix queue config get logic > > > > remove the memcpy usage in queue config get function for > > `event` variable which is 8 byte size and use direct copy. > > Also provide vector information and event buffer size in the > > queue config info. > > > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > > > Signed-off-by: Naga Harish K S V > > --- > > v2: > > * remove memcpy usage > > also provide vector data and event buffer size info > > --- > > lib/eventdev/rte_event_eth_rx_adapter.c | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > > index ae1e260c08..28388d3abb 100644 > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > @@ -3194,11 +3194,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > uint16_t rx_queue_id, > > struct rte_event_eth_rx_adapter_queue_conf *queue_conf) > > { > > +#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq)) > > struct rte_eventdev *dev; > > struct event_eth_rx_adapter *rx_adapter; > > struct eth_device_info *dev_info; > > struct eth_rx_queue_info *queue_info; > > - struct rte_event *qi_ev; > > int ret; > > > > if (rxa_memzone_lookup()) > > @@ -3229,7 +3229,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > } > > > > queue_info = &dev_info->rx_queue[rx_queue_id]; > > - qi_ev = (struct rte_event *)&queue_info->event; > > > > memset(queue_conf, 0, sizeof(*queue_conf)); > > queue_conf->rx_queue_flags = 0; > > @@ -3238,7 +3237,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > > queue_conf->servicing_weight = queue_info->wt; > > > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > > + queue_conf->ev.event = queue_info->event; > > + > > + queue_conf->vector_sz = queue_info->vector_data.max_vector_count; > > + queue_conf->vector_mp = queue_info->vector_data.vector_pool; > > + /* need to be converted from ticks to ns */ > > + queue_conf->vector_timeout_ns = TICK2NSEC( > > + queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz()); > > + > > + if (queue_info->event_buf != NULL) > > + queue_conf->event_buf_size = queue_info->event_buf->events_size; > > + else > > + queue_conf->event_buf_size = 0; > > > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > > -- > > 2.23.0 >