From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2093A2EEB for ; Thu, 12 Sep 2019 17:48:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E6F9E1EAF2; Thu, 12 Sep 2019 17:48:48 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 229CB1EAD6 for ; Thu, 12 Sep 2019 17:48:48 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id b136so55905593iof.3 for ; Thu, 12 Sep 2019 08:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EcMvx2CNdlKUDabgbeq2h7HhtmRIIGlBugfx4N0iIaQ=; b=OTd8Cx7IcBFt0/eaqUgD+Soeu7YIf1N/vGW5ktREBYxglwHNrbztRVGN2yIP499n2D XhUBVHrcuXRp0qtEs+mO4AeCe4FoxebERAAHJE47rL/mjFNIfu8Q6RXddTzrAxaqXgKu V8PQ2t0DTSP0BaGrgXLUv1V3z3iluh7QMwLCSOPqhY5y7t3LZQ0shtR70oNGTIyYH5mG aOnd8YHVbPKbAi/96w1TVW1b4IqbZD/QTLkMXwQ+EQleFD59mb29odOjPLb6pirvgXoy sWyi+Ag6Cu7BHFfm/CgfsztP3I2YHYuh5MC456VAOl8dJp4DEK/bXBVfaJJp6tv224T4 XqnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EcMvx2CNdlKUDabgbeq2h7HhtmRIIGlBugfx4N0iIaQ=; b=c5g4jBC/lRCqtenltMd/P4TRbx9sDMpqZOwhqzxAyz6kmBDTTdHAepXZcGGe+4Kvwj 2NI17x5CBgF1cBBMX7ahBXV12zSlDqKzaNRJjOVjNgZSdEmIcvHAVFORHdnmloBEpj+n VgMJ/1puKKrmWaXQXRfdALrGP7lERsahrdkuzqpmU7PSa+HmPa7G+u0ZcJO+2PTEOxFl yv6A9lRpR9LjQHgfMD8EDgIQ2rnl82o0cTnYjN61n81w5kX68tvcaldYiUWrWGHOP4pY ZaWkP5AXB7bAAYOoAwACXM/jSWzcnwAwiI1hACL0NN6ZdA+rXmHAulpO5fv9GQVMDie7 xEsQ== X-Gm-Message-State: APjAAAVdpecPzn6ohQGqb0fkha7Yhh2pMfmjj4Ut6B4JS/f8Y0Hmu4cv ahGQwbw39amkw9hj56olw9A9oT3C7BzwkyjKKNQ= X-Google-Smtp-Source: APXvYqziivovom32r0au82FiKZrRgB35Lzj3epLNIMkliEfmX9X2Ynia+tcizVPEtvy1pGQhaACqu9CWTXCT0bIMm7Y= X-Received: by 2002:a05:6638:29c:: with SMTP id c28mr44041529jaq.133.1568303327123; Thu, 12 Sep 2019 08:48:47 -0700 (PDT) MIME-Version: 1.0 References: <1561911676-37718-1-git-send-email-gavin.hu@arm.com> <1568287473-55306-1-git-send-email-gavin.hu@arm.com> <1568287473-55306-2-git-send-email-gavin.hu@arm.com> In-Reply-To: <1568287473-55306-2-git-send-email-gavin.hu@arm.com> From: Jerin Jacob Date: Thu, 12 Sep 2019 21:18:35 +0530 Message-ID: To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, Thomas Monjalon , stephen@networkplumber.org, hemant.agrawal@nxp.com, Jerin Jacob , Pavan Nikhilesh , Honnappa.Nagarahalli@arm.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/8] config: add WFE config entry for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 12, 2019 at 5:05 PM Gavin Hu wrote: > > Add the RTE_USE_WFE configuration entry for aarch64, disabled by default. s/RTE_USE_WFE/RTE_ARM_USE_WFE > It can be enabled selectively based on the performance benchmarking. > > Signed-off-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Steve Capper > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang Does it make sense to add the Reviewed-by without CCing the people? I understand, There may be an internal review before sending out to mailing list, IMO, it better to give Reviewed-By in the mailing list. Not sure about general practice and other people view. > Acked-by: Pavan Nikhilesh > --- > config/arm/meson.build | 1 + > config/common_base | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 979018e..18ecd53 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -116,6 +116,7 @@ impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic] > impl_dpaa2 = ['NXP DPAA2', flags_dpaa2, machine_args_generic] > > dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > +dpdk_conf.set('RTE_ARM_USE_WFE', 0) > > if not dpdk_conf.get('RTE_ARCH_64') > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) > diff --git a/config/common_base b/config/common_base > index 8ef75c2..d4cf974 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -570,6 +570,12 @@ CONFIG_RTE_CRYPTO_MAX_DEVS=64 > CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO=n > CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n > > +# Use WFE instructions to implement the rte_wait_for_equal_xxx APIs, > +# calling these APIs put the cores in low power state while waiting > +# for the memory address to become equal to the expected value. > +# This is supported only by aarch64. > +CONFIG_RTE_ARM_USE_WFE=n Since this comes as EAL config, IMO, it is better to move this to end of EAL section. i.e move after CONFIG_RTE_USE_LIBBSD And I think, we should squash this patch to "eal: add the APIs to wait until equall" as it single logical change. > + > # > # Compile NXP CAAM JR crypto Driver > # > -- > 2.7.4 >