From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 852084591E; Fri, 6 Sep 2024 15:11:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 572014025D; Fri, 6 Sep 2024 15:11:41 +0200 (CEST) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id E444F400D5 for ; Fri, 6 Sep 2024 15:11:39 +0200 (CEST) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4567f2cbdb9so12104181cf.2 for ; Fri, 06 Sep 2024 06:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725628299; x=1726233099; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zSr3pIlb6y/GagXfPYW2pr+mMYJcL4E5Gvzoy9gRNtY=; b=khdfGvdKYsdy7Be4FzBAh2cJo9FrttMjdesOIB6Ol9EfsDoxLj6kXTcbWYgCso2M6B 4Go/HTewXy2U/EaEfeBMXAvSE/N2gXkGmD342Ena3DsmyAmWlWOb4hhcInIdNzaFnIE+ yIzCIfmM6u4KSGPLNk0YmUGyGmXqR+1T8WfQcwcYQSq7elEpqDWM9/tMI4FijNr5RACw zXnSoWz6BxNk/8ILsNEcaoq5EIwyyucQ+IepmLyqLJwHh4ju5thwt7O+6GFyhG7bOxkQ GOCl1ruh+WKaoDUikd7yLKlNBYOqMjErT5bSBTxqp3ZkJoao3tCii2JcIlpVhJZG/EoJ l6EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725628299; x=1726233099; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSr3pIlb6y/GagXfPYW2pr+mMYJcL4E5Gvzoy9gRNtY=; b=AnwVBa8wBxJ5FPzjzH0yJr2mlDrMvxjhQfIoAk/oOqW8IEpgT93u0aNWuvSOUacGr7 Hn910YI8IDkjvP2e9DJshhh0TbLS++hhEIhSe7+wKyYXNTRGNDCW2XpdbigYdphLQ0XQ 5EJkTsK8gNJXC8aUJT9JeMta0wLJvWnqQ0lIRDjt6ahd8bh0LhmXOOG0A67eIHXw7qgs AMVAzhz4xpI4BbncFVbkpKUjWG6dSerp++2dMZ44TaZaF+7Vx9e7mGnRxb9V94oOnSG7 VEOQP+LxLHxWayASQcIjmbKE74SEqLoDG+1hiPCQJskS0E6fU4MNMIxx563eyGPDLi2Y OHoQ== X-Forwarded-Encrypted: i=1; AJvYcCUld/RDI3211bdKGO5BqcOC947ZW3p5e3/AeQZlfqsJgWvYYKSzrdIM+jTHBJjkropUqgs=@dpdk.org X-Gm-Message-State: AOJu0YzDfJggbSlV1bYfYSpPFqcHkuZfMV0up4ha62Z+M8kpj24L/HcZ kfkNaIoz8WKjXDP3i3NxW8VLiUp8tqOTktmV+BKXH2ZgFIl6jvhbrdlCftZfDhru1q3+h0C0TvA lw+i9HEjjyYsvpjgjG4FugnRiHa0= X-Google-Smtp-Source: AGHT+IEtqu0r+quPF5mVHz/wBvmoJvX1f9/0G+OEgf0MIFBQ+zA5jLjq5uYjrsAb21afVZ79DX7N/YB49/sKrybw+KI= X-Received: by 2002:ac8:5854:0:b0:456:7da0:7cc8 with SMTP id d75a77b69052e-4580c68dd87mr37589081cf.17.1725628299159; Fri, 06 Sep 2024 06:11:39 -0700 (PDT) MIME-Version: 1.0 References: <20240904180954.104473-1-stephen@networkplumber.org> <3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com> In-Reply-To: <3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com> From: Jerin Jacob Date: Fri, 6 Sep 2024 18:41:12 +0530 Message-ID: Subject: Re: [PATCH 0/3] eal: mark API's as stable To: Ferruh Yigit Cc: David Marchand , Stephen Hemminger , dev@dpdk.org, Jerin Jacob Kollanukkaran , Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 3:04=E2=80=AFPM Ferruh Yigit = wrote: > > On 9/5/2024 8:58 AM, David Marchand wrote: > > On Wed, Sep 4, 2024 at 8:10=E2=80=AFPM Stephen Hemminger > > wrote: > >> > >> The API's in ethtool from before 23.11 should be marked stable. > > > > EAL* ? > > > >> Should probably include the trace api's but that is more complex chang= e. > > > > On the trace API itself it should be ok. > > The problem is with the tracepoint variables themselves, and I don't > > think we should mark them stable. > > > > We cleaned tracepoint variables from ethdev map file, why they exist for > 'eal'? > > I can see .map file has bunch of "__rte_eal_trace_generic_*", I think > they exists to support 'rte_eal_trace_generic_*()' APIs which can be > called from other libraries. > > Do we really need them? > Why not whoever calls them directly call 'rte_trace_point_emit_*' instead= ? > As these rte_eal_trace_generic_*()' not used at all, I assume this is > what done already. > > @Jerin, > what do think to remove 'rte_eal_trace_generic_*()' APIs, so trace > always keeps local to library, and don't bloat the eal .map file? The purpose of exposing rte_eal_trace_generic_* is that, applications can add generic trace points in the application. > >