DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Abdullah Sevincer <abdullah.sevincer@intel.com>
Cc: dev@dpdk.org, jerinj@marvell.com
Subject: Re: [PATCH v1] event/dlb2: revise QE Weight Feature
Date: Tue, 8 Aug 2023 16:12:59 +0530	[thread overview]
Message-ID: <CALBAE1OH3Sx0N9FzrV7t17YDY6HiEiwFZGCcnimaXBOAb=aasQ@mail.gmail.com> (raw)
In-Reply-To: <20230627132421.1946338-1-abdullah.sevincer@intel.com>

On Tue, Jun 27, 2023 at 6:54 PM Abdullah Sevincer
<abdullah.sevincer@intel.com> wrote:
>
> Revise QE weight feature to enable from command line
> just passing  a flag. If QE weight feature is enabled
> simply port cq weight will be same as dequeue depth.
>
> Also, update DLB documentation for revised QE weight feature and
> usage of eventdev application with DLB hardware.
>
> Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
>
> @@ -4774,11 +4728,11 @@ dlb2_parse_params(const char *params,
>                                              DLB2_VECTOR_OPTS_ENAB_ARG,
>                                              DLB2_MAX_CQ_DEPTH,
>                                              DLB2_MAX_ENQ_DEPTH,
> -                                            DLB2_CQ_WEIGHT,
>                                              DLB2_PORT_COS,
>                                              DLB2_COS_BW,
>                                              DLB2_PRODUCER_COREMASK,
>                                              DLB2_DEFAULT_LDB_PORT_ALLOCATION_ARG,
> +                                                DLB2_ENABLE_CQ_WEIGHT_ARG,

Alignment lost here. Added following diff to the patch

[for-main]dell[dpdk-next-eventdev] $ git diff
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 07c9384950..3bc9d7408f 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -4732,7 +4732,7 @@ dlb2_parse_params(const char *params,
                                             DLB2_COS_BW,
                                             DLB2_PRODUCER_COREMASK,

DLB2_DEFAULT_LDB_PORT_ALLOCATION_ARG,
-                                                DLB2_ENABLE_CQ_WEIGHT_ARG,
+                                            DLB2_ENABLE_CQ_WEIGHT_ARG,
                                             NULL };

Updated the git commit as follows and applied to
dpdk-next-net-eventdev/for-main. Thanks

    event/dlb2: revise QE weight feature

    Revise QE weight feature to enable from command line just passing
    a flag. If QE weight feature is enabled simply port CQ weight will
    be same as dequeue depth.

    Also, updated DLB documentation for revised QE weight feature and
    usage of eventdev application with DLB hardware.

    Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>


>                                              NULL };

      reply	other threads:[~2023-08-08 10:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 13:24 Abdullah Sevincer
2023-08-08 10:42 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1OH3Sx0N9FzrV7t17YDY6HiEiwFZGCcnimaXBOAb=aasQ@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=abdullah.sevincer@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).