From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B2C2A0546; Thu, 16 Jul 2020 13:56:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13CE71C115; Thu, 16 Jul 2020 13:56:12 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id EE2511BFFC for ; Thu, 16 Jul 2020 13:56:10 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id l1so5679783ioh.5 for ; Thu, 16 Jul 2020 04:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=N3eg/ezCHtBTcZQ68fsnO7AZyXqe1gD5zg1BGVdFbM4=; b=jfQ7LiPffOeH/F8HGo3Gns2gIqy6c9NgREljoY262AJLvWkQAVVvhcu4TzJ46McMp+ LtHzC7/YS4bN7kKjm073iKEBUtC86AF++wdXoxnRtUddRBJm2Ap6JPEIbvlK9wj068Lf aywZUq74hRLxfh4WkTETCEFLEwcD9Tkz/8YURzrNx0QmQLia7z31JrEiZ6k3LYHOUdr+ cqfyPw2hQIbaJ/wSw5krLTFMozt/A+RKODIFMdN9aUgI1rPxUjfw95/caOgoMkWjr0Ym 2UZ7RMM+Pwj3i/k62HWiLAd2mTqijySGLJLTHFQREfDaoMWlz/ENX8EcwEzsEHbcCtup orXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=N3eg/ezCHtBTcZQ68fsnO7AZyXqe1gD5zg1BGVdFbM4=; b=dvyB9OGsUln2YM8FBGo/gWklHwqVYD5x65Lv9c9WiEGIG/DiUDWkwDIyH6Acb6ctNl BlX98rnsFj9guifjAm09hdSShYyKf5pfJfq11KC/SDebTRMx3+y90lfxjFenaMeC7wuz Rd6pBKfOIybWotjnwKjsy1udBijde21eqLP6joZzbi4ZAKLZJccAxRH0HA8jiI1/FZdr jlHRQ4YONlFqrbtQyKOJ0aBfxv7Ircf0mzkhZ1pjMk77xUDHiO4E9yrB6VWs1hqQ2wBY 6qyBTrqaOcs/cBie1tBaA5leP1HY1Y9i4XU4vMHWJnu/t3FRyZLiHeTBqU3wvigx0hg6 yiug== X-Gm-Message-State: AOAM530iaGvJdej1/jlcRpnoe1BJ4CM8dtxsfhdDZUc9NQVaS7iXLwK8 LlE0X/MR4ROH0Ys2Vh0Sqb0qHuXBCC3mhCQA9So= X-Google-Smtp-Source: ABdhPJzxipBXz5pXfLX0D9L5wMeCGI9c8TRY4AipIFMpQym9zU4JdKrlk/jQhinqwVyn7Xuvl1sWlkJfqk9k0VBQp0U= X-Received: by 2002:a05:6602:1555:: with SMTP id h21mr4027950iow.163.1594900570097; Thu, 16 Jul 2020 04:56:10 -0700 (PDT) MIME-Version: 1.0 References: <20200713151319.17547-2-manishc@marvell.com> <20200716101753.722ld3p66bqrjss7@u256.net> <2902125.JAyrVFZy8S@thomas> In-Reply-To: <2902125.JAyrVFZy8S@thomas> From: Jerin Jacob Date: Thu, 16 Jul 2020 17:25:53 +0530 Message-ID: To: Thomas Monjalon Cc: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= , Manish Chopra , Ferruh Yigit , Igor Russkikh , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjalon wrote= : > > 16/07/2020 12:27, Jerin Jacob: > > On Thu, Jul 16, 2020 at 3:48 PM Ga=C3=ABtan Rivet wrot= e: > > > > > > On 16/07/20 12:08 +0200, Ga=C3=ABtan Rivet wrote: > > > > Re-CCing dev@dpdk.org as it was removed from the reply. > > > > > > > > On 13/07/20 08:13 -0700, Manish Chopra wrote: > > > > > This is merely copy of latest linux/pci_regs.h in > > > > > order to avoid dependency of dpdk on user headers. > > > > > > > > > > > > > I guess this dependency is an issue on non-linux systems, when you = must > > > > use those defines in a generic implementation. Can you confirm this= is > > > > the motivation here? > > > > > > > > If so, I think it would be clearer to state "in order to avoid > > > > dependency of DPDK on linux headers". > > > > > > > > > > To add to it, if this is actually the motivation to add this header, = I > > > don't think it is sufficient. > > > > > > You can restrict the function definition to the linux part of the > > > PCI bus driver instead, using stubs for other systems. > > > > > > > > Signed-off-by: Manish Chopra > > > > > Signed-off-by: Igor Russkikh > > > > > --- > > > > > drivers/bus/pci/linux/pci_uio.c | 2 +- > > > > > drivers/bus/pci/linux/pci_vfio.c | 2 +- > > > > > drivers/net/bnx2x/bnx2x.h | 2 +- > > > > > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 2 +- > > > > > lib/librte_pci/Makefile | 1 + > > > > > lib/librte_pci/meson.build | 2 +- > > > > > lib/librte_pci/rte_pci_regs.h | 1075 +++++++++++++++++++++= ++++++ > > > > > 8 files changed, 1082 insertions(+), 6 deletions(-) > > > > > create mode 100644 lib/librte_pci/rte_pci_regs.h > > > > > > > > > > > > > [...] > > > > > > > > > diff --git a/lib/librte_pci/rte_pci_regs.h b/lib/librte_pci/rte_p= ci_regs.h > > > > > new file mode 100644 > > > > > index 000000000..1d11f4de5 > > > > > --- /dev/null > > > > > +++ b/lib/librte_pci/rte_pci_regs.h > > > > > @@ -0,0 +1,1075 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > > +/* > > > > > > > > This file is delivered alongside the PCI lib, targeting userspace. > > > > This seems to be an exception to the license policy described in > > > > license/README. Code shared between kernel and userspace is expecte= d > > > > to be dual-licensed BSD-3 and GPL-2.0. > > > > > > > > As it is a copy of Linux user includes, re-licensing it as BSD-3 as= well > > > > is not possible. > > > > > > > > So I think it might require a techboard + governing board exception > > > > approval. Ferruh or Thomas, what do you think? > > > > I think, instead of importing GPL-2.0 file, We can add the constants > > as need by the DPDK > > as symbols start from RTE_PCI_*(It will fix up the namespace as well). > > If symbols can be found in /usr/include/, don't add anything. Not by default on all the distros. It is part of pciutils library. Moreover, we need these symbols for Windows OS as well. IMO, We should add absolute minimum constants that needed for DPDK as RTE_P= CI_* > >