From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A4E2A04B5; Fri, 30 Oct 2020 11:32:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C1AAC7F2; Fri, 30 Oct 2020 11:32:57 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id C8940C748 for ; Fri, 30 Oct 2020 11:32:55 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id s7so6929936iol.12 for ; Fri, 30 Oct 2020 03:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gRpxWj3cWFhOCfTBMA8ZiG+JNqDTUV3f655ocW9FJ6c=; b=TOZEm8Z3/8Fbt1SgMGSJFLdud2dkxrMtK2tpxj4JK3fKX0iPD3wdgm8yIVYVEZJXsB nb06b/OL+S0VOOAOh1wa+pmQ3xncMIpkPEU9x6UjEE4ADNm7Q16rI+Pw7YViRLlLvaWg QzWWHxVdCaq5hM2Juj6J9LkOIKAo76MZKPMzxctdwZWDDZYkGC8ldY2VJB4BPHcFrdPY 2zjkpJMtpEZNioJGcX24ccenWLu4HqXwNo5US/RrUf0Om69sxflcFqON/ORlecGgkv8Q t9bd9dbJydCTxEAE7s/RiaKrWyJGMdTV/oyfutI0xnPuF1pPwQvjBCQ9/mnBiXmO5KHO wiFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gRpxWj3cWFhOCfTBMA8ZiG+JNqDTUV3f655ocW9FJ6c=; b=BNuoSbul1NyqN+SEXQG9+QeE8TyjfNBnn5hIzx+l/W+7a2EOaZulg3vG3lUDmErkng q0FD1gVvFaiHuzyg9EJUlU73vuF1eF3i0YPNkZDOypkWvgk2NbaXE4ZiU2tQb12bGLIs jFrXC9kxRrEZvW9R6JAkVf5ymblXGsE3Jgkcv0IptMd3Wf6xP+5XazP/d40gsm11p4un L9gLQai8OieH/Fmc0yGlPQsjGf+GWFrJl+gnF+Bl8H8xBTOQ91+y0I5yZzOn7kzsdxS9 ovz0tSgm7Ii3J5p3hbHmvlDhA6srsnmj+0PjBwTnbYEyoRwSTet0kpNnNFACT1hOSkqc 04fA== X-Gm-Message-State: AOAM531RZUxNCkCb6DT6nO97uBmizAURz7/1aQf/CU6GuBKN9K96GDbn zeSd7YexiJDjrIdS8QIGnSE+BAm1q8DtXFpsvp0= X-Google-Smtp-Source: ABdhPJyehAt2aq5T+dgbYwYgEMXS864PYIvUi6bL1ql970MNxxMMM9m6kB6Bj4S2/XS9QN34mLopHA5XC4X7QzdmPwY= X-Received: by 2002:a5d:9615:: with SMTP id w21mr1238682iol.59.1604053974174; Fri, 30 Oct 2020 03:32:54 -0700 (PDT) MIME-Version: 1.0 References: <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <1604051021-26699-1-git-send-email-timothy.mcdaniel@intel.com> <3010612.HaWdak5MLs@thomas> In-Reply-To: From: Jerin Jacob Date: Fri, 30 Oct 2020 16:02:37 +0530 Message-ID: To: "McDaniel, Timothy" , Liang Ma , Anatoly Burakov Cc: Thomas Monjalon , "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "jerinj@marvell.com" , "david.marchand@redhat.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2020 at 3:46 PM McDaniel, Timothy wrote: > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Friday, October 30, 2020 5:02 AM > > To: McDaniel, Timothy > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > > ; Van Haaren, Harry ; > > jerinj@marvell.com; david.marchand@redhat.com > > Subject: Re: [PATCH v5 00/23] Add DLB2 PMD > > > > 30/10/2020 10:43, Timothy McDaniel: > > > - note that the code still uses its private byte-encoded versions of > > > umonitor/umwait, rather than the new functions in the power > > > patch that are built on top of those intrinsics. This is intentional. > > > > Why? Now these intrinsics are available in the main branch. > > We should avoid duplicating such code. > > > > > > I had asked that the low level intrinsics (UMWAIT/UMONITOR) be split out so that DLB/DLB2 could use them instead of its own private byte-encoded versions, but instead we have these wrappers that call the low level intrinsics. Those wrappers > introduce additional overhead that is not required for DLB/DLB2. I have a meeting with Ma Liang on Monday to discuss. Then why we merged the EAL patches? The all-purpose was to use this by other subsystems. If it is only for the power library then we should make specific to the power library. Thomas, Should I take this series in eventdev or I need to wait to sort out this?