From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DA40A0C4E; Mon, 8 Nov 2021 17:38:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33A8041122; Mon, 8 Nov 2021 17:38:01 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 4DAF0410FD for ; Mon, 8 Nov 2021 17:38:00 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id r80so5324036pgr.9 for ; Mon, 08 Nov 2021 08:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/6G23KeS4QvexCHHsI0p3gl5tScRoKbsYKCpyWAjGOQ=; b=B1o2yYaq71qm4FPcskW8L7+UF7tmVkbHYxKUkvJJMfXwQz4p/4M14BN+48Cb7/Qdb/ Dmo4GAioXYPhDtxhygCh4Uybr4uVGihQfCdR+beltoVODJGalS293uk2SeQQRYhuw9UO /YNqV78yWymcVGjQoxUrKsHFwOK3ueCchWA66hUw+Lr6ePCs8AbIO30ZRMj3SoAPC4JF fX21IP1YJHMZmQpwJp4TSnV5XNFLPOR3mX9SQFmOyulvRbPq8FvYXomIWTkDaU8CVETd zM1Id1AiiYN72l9Pw4d61aeCKYiWJad1E7Q9kZfPywpcSvWm4liQYPzPmGPcPNkxrjsP +Esg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/6G23KeS4QvexCHHsI0p3gl5tScRoKbsYKCpyWAjGOQ=; b=BJAKbZ+3GrnGpa+FPLQb469XrTJ7UvYohJSn/waduDT2KY3FkOZBv3fGO0RsOMOW3W xBb/HpudNpwjBeaW6R+tKFw64AUoY2eazFOXPeyL5/x6HUBTMq6qpHpOUn5d6RB4iYDA A1cPwbTdkeszsMydAqN0vSXNdA4YSLJEi6zrmAo4k6yVX1K0XULneHpVO9uoaTi32DJw UtN0bx1q/nBE75qc9IX2AFe09uvvsoM1gPW5VXDDDok+lgHeDmBYTbhLljY5b6SSesmA dwSd8ttVAY4IM13UGnMN/k/2UPq9K18voK/bJhg7D1klLoNvv1/99+86L5z3TAgm/eXD 2GeA== X-Gm-Message-State: AOAM532YQ4CAJKAlQdu50UkkNP+Kzn5lwErs1SU04kWpaHc4KLZdQHd3 WvFL6XAWfH23x/WErvd12loWdcxceN63dYxjOWU= X-Google-Smtp-Source: ABdhPJySuNFzzrih1pIyOXEKZpM3cntA8GP3YBqgsU7cj0DMOHZQjjeGZdh3XsY+7PNz9BDZwtdcU340I3VmQ7unHfg= X-Received: by 2002:a05:6a00:1594:b0:49f:c5f0:19df with SMTP id u20-20020a056a00159400b0049fc5f019dfmr170747pfk.70.1636389479455; Mon, 08 Nov 2021 08:37:59 -0800 (PST) MIME-Version: 1.0 References: <20211108134547.3286191-1-vfialko@marvell.com> In-Reply-To: <20211108134547.3286191-1-vfialko@marvell.com> From: Jerin Jacob Date: Mon, 8 Nov 2021 22:07:33 +0530 Message-ID: To: Volodymyr Fialko , "Ruifeng Wang (Arm Technology China)" , Honnappa Nagarahalli Cc: dpdk-dev , Bruce Richardson , Anatoly Burakov , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build: enable ASan for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 8, 2021 at 7:16 PM Volodymyr Fialko wrote: > > This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan > documentation. This offset should cover all arm64 VMAs supported by > ASan. > > Signed-off-by: Volodymyr Fialko ++ Arm maintainers Prefer to change the subject to eal/arm64: support ASan > --- > config/meson.build | 2 +- > doc/guides/prog_guide/asan.rst | 2 +- > lib/eal/common/malloc_elem.h | 3 +++ > 3 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/config/meson.build b/config/meson.build > index 17b5bec406..7eb710c08d 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -428,7 +428,7 @@ if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'address > dpdk_extra_ldflags += '-lasan' > endif > > - if is_linux and arch_subdir == 'x86' and dpdk_conf.get('RTE_ARCH_64') > + if is_linux and arch_subdir in ['x86', 'arm'] and dpdk_conf.get('RTE_ARCH_64') > dpdk_conf.set10('RTE_MALLOC_ASAN', true) > endif > endif > diff --git a/doc/guides/prog_guide/asan.rst b/doc/guides/prog_guide/asan.rst > index 6d1b871c93..7a584427dd 100644 > --- a/doc/guides/prog_guide/asan.rst > +++ b/doc/guides/prog_guide/asan.rst > @@ -33,7 +33,7 @@ Example:: > "stty echo" command when an error occurs. > > ASan is aware of DPDK memory allocations, thanks to added instrumentation. > -This is only enabled on x86_64 at the moment. > +This is only enabled on x86_64 and arm64 at the moment. > Other architectures may have to define ASAN_SHADOW_OFFSET. > > Example heap-buffer-overflow error > diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h > index 262d69bb3e..c00c7845ab 100644 > --- a/lib/eal/common/malloc_elem.h > +++ b/lib/eal/common/malloc_elem.h > @@ -107,6 +107,9 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem) > #ifdef RTE_ARCH_X86_64 > #define ASAN_SHADOW_OFFSET 0x00007fff8000 > #endif > +#ifdef RTE_ARCH_ARM64 Better to change to "else if" to be more foolproof > +#define ASAN_SHADOW_OFFSET 0x001000000000 Add a minimal comment on why this value was selected instead of x86 value of 0x00007fff8000 With the above change, Acked-by: Jerin Jacob > +#endif > > #define ASAN_SHADOW_GRAIN_SIZE 8 > #define ASAN_MEM_FREE_FLAG 0xfd > -- > 2.25.1 >