From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC9E141C67; Sat, 11 Feb 2023 06:17:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90AF940E50; Sat, 11 Feb 2023 06:17:02 +0100 (CET) Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by mails.dpdk.org (Postfix) with ESMTP id A3C4040E0F for ; Sat, 11 Feb 2023 06:17:00 +0100 (CET) Received: by mail-vk1-f177.google.com with SMTP id o28so3696112vkf.12 for ; Fri, 10 Feb 2023 21:17:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RD5fgLXmP1TE8Hkv96apgwXPbdZQO3eZX5PpRhSubTQ=; b=My+ugezqVhxW+RNDVk/bBWqfB7j5W6JPlyjf0AhTKhwzXKg+C9Y2Wn5BAkcEKFGoOz FnqLLWsRI/49ZrwksnOHJBKrwzyv4ASD8PFHrfMzzojrUCeEuOYe+1HUXx614N3S+1FN XiTrDHFPzlzimQ9AFYQPW3EyY8Dkc8D9XJ0r30VAw4lD6JaptBEhUVIE1RGIE2Shg1uj qGF1l9ExsDzhp4/Vr5G4adIksNzzUuD8v13weYESOUIOd5KxY0AKlptDLgGlN8Ej1Vzq iSXcMOzpTWr3pN7Z7K1T2Qax7Y/ICKHNoQnRABeF6Vh2dcnbMRXYH3cjS8lQtqQ+8SWG GqiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RD5fgLXmP1TE8Hkv96apgwXPbdZQO3eZX5PpRhSubTQ=; b=lIIguEi/E/T55Qx6o3CRwvEhhj1x9D9pOacNNAgg2ju29KOSuHWoMTbe+Ag+xNX3IJ cAjCSHPOQU5nZOnky1tsBefNlqQdhEHGFOniJYIl6sTxX52sg+pGoGFV9zLHWLCaDOFW q0fLvUq0U2WVr303mWg2/+SJDpookCaCMfGrtG1Z4dns2dTNHsYuoDdXVhBjWPV5W2sW gFcsx7tVxdOsOqp0J9KhUxZvgKCe6xF7m4vrY8uYdUx/a2nN3WHUcdwq7tP8Dz8JwdA6 73V1yMSJOwIuzgGpFMW6NP9kP7mmQ6M4HEZ9/aI9qh1n6mcN2rygPBTME66Rlgbx0t6D kygw== X-Gm-Message-State: AO0yUKW+9h1egkIDUydzoUSovTntbNCrL5UMywuaiNujtIxGSzhCdwVQ jw6y0AmPVgAXmTvowPFcRkH0Er0gNuR2PjVMg5s= X-Google-Smtp-Source: AK7set/IIknu6ri8FaCSd+DBYb4IrsDFa60BMuR/GJeeHy2aVC2DKzgVXeh8mgdvvVQOjO7k7j7F33KYxZmB2BAn6aY= X-Received: by 2002:a1f:274d:0:b0:3e8:791d:5ee with SMTP id n74-20020a1f274d000000b003e8791d05eemr3324283vkn.14.1676092620013; Fri, 10 Feb 2023 21:17:00 -0800 (PST) MIME-Version: 1.0 References: <20230210081422.1004901-1-rkudurumalla@marvell.com> <20230210082623.1005496-1-rkudurumalla@marvell.com> In-Reply-To: From: Jerin Jacob Date: Sat, 11 Feb 2023 10:46:33 +0530 Message-ID: Subject: Re: [PATCH v6 1/3] ethdev: skip congestion management configuration To: Ferruh Yigit Cc: Rakesh Kudurumalla , Ori Kam , Thomas Monjalon , Andrew Rybchenko , jerinj@marvell.com, ndabilpuram@marvell.com, dev@dpdk.org, David Marchand Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 11, 2023 at 6:05 AM Ferruh Yigit wrote: > > On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > > index b60987db4b..f4eb4232d4 100644 > > --- a/lib/ethdev/rte_flow.h > > +++ b/lib/ethdev/rte_flow.h > > @@ -2203,6 +2203,17 @@ enum rte_flow_action_type { > > */ > > RTE_FLOW_ACTION_TYPE_DROP, > > > > + /** > > + * Skip congestion management configuration > > + * > > + * Using rte_eth_cman_config_set() API the application > > + * can configure ethdev Rx queue's congestion mechanism. > > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the > > + * congestion configuration applied to the given ethdev Rx queue. > > + * > > + */ > > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN, > > + > > Inserting new enum item in to the middle of the enum upsets the ABI > checks [1], can it go to the end? Yes. > > > > > [1] > 1 function with some indirect sub-type change: > > [C] 'function size_t rte_flow_copy(rte_flow_desc*, size_t, const > rte_flow_attr*, const rte_flow_item*, const rte_flow_action*)' at > rte_flow.c:1092:1 has some indirect sub-type changes: > parameter 1 of type 'rte_flow_desc*' has sub-type changes: > in pointed to type 'struct rte_flow_desc' at rte_flow.h:4326:1: > type size hasn't changed > 1 data member changes (1 filtered): > type of 'rte_flow_action* actions' changed: > in pointed to type 'struct rte_flow_action' at > rte_flow.h:3775:1: > type size hasn't changed > 1 data member change: > type of 'rte_flow_action_type type' changed: > type size hasn't changed > 1 enumerator insertion: > > 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_SKIP_CMAN' value '8' > 50 enumerator changes: > 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_COUNT' > from value '8' to '9' at rte_flow.h:2216:1 > ...