From: Jerin Jacob <jerinjacobk@gmail.com>
To: Liron Himi <lironh@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [EXT] Re: [PATCH v3 4/5] common/cnxk: link REE support to ROC files
Date: Mon, 6 Dec 2021 13:38:29 +0530 [thread overview]
Message-ID: <CALBAE1OLv__9hgzpXoJu7i4f=TMEWZRX-qh4+LV0LA3z79fjVQ@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB447325FF5D9F319D38DDA6C7C66D9@PH0PR18MB4473.namprd18.prod.outlook.com>
On Mon, Dec 6, 2021 at 12:24 PM Liron Himi <lironh@marvell.com> wrote:
>
> Hi,
>
> This patch is not just for map update.
> what about all other changes?
1) roc_ree.c is added in this patch to build. It should be moved to
the first patch where thing started building
+ 'roc_ree.c',
2) All other minor changes in this patch can be squashed to respective patches.
>
> Liron Himi
>
>
>
> Park Azorim, Kyriat Arie, Petah Tikva, 49527, Israel
> Mobile: +972.52.3329169
>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, 6 December 2021 07:08
> To: Liron Himi <lironh@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>
> Subject: [EXT] Re: [PATCH v3 4/5] common/cnxk: link REE support to ROC files
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, Nov 30, 2021 at 1:30 AM <lironh@marvell.com> wrote:
> >
> > From: Liron Himi <lironh@marvell.com>
> >
> > add references to REE files from ROC files
> >
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> > ---
> > cnxk_logtype_nix;
> > cnxk_logtype_npa;
> > cnxk_logtype_npc;
> > + cnxk_logtype_ree;
> > cnxk_logtype_sso;
> > cnxk_logtype_tim;
> > cnxk_logtype_tm;
> > @@ -347,6 +348,21 @@ INTERNAL {
> > roc_tim_lf_enable;
> > roc_tim_lf_free;
> > roc_se_ctx_swap;
> > -
> > + roc_ree_af_reg_read;
> > + roc_ree_af_reg_write;
> > + roc_ree_config_lf;
> > + roc_ree_dev_fini;
> > + roc_ree_dev_init;
> > + roc_ree_err_intr_register;
> > + roc_ree_err_intr_unregister;
> > + roc_ree_iq_disable;
> > + roc_ree_iq_enable;
> > + roc_ree_msix_offsets_get;
> > + roc_ree_qp_get_base;
> > + roc_ree_queues_attach;
> > + roc_ree_queues_detach;
> > + roc_ree_rule_db_get;
> > + roc_ree_rule_db_len_get;
> > + roc_ree_rule_db_prog;
>
>
> We don't update .map files in a separate patch. Please update this to the respective patch.
> In short, this 4/5 patch can be squashed to respective patches.
> Rest looks good to me. We can merge the next version if there are no other comments.
>
>
> > local: *;
> > };
> > --
> > 2.28.0
> >
next prev parent reply other threads:[~2021-12-06 8:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 6:23 [dpdk-dev] [PATCH] common/cnxk: add REE support lironh
2021-10-28 9:30 ` Jerin Jacob
2021-11-23 19:13 ` [PATCH v2 0/5] regex/cn9k: use cnxk infrastructure lironh
2021-11-23 19:13 ` [PATCH v2 1/5] common/cnxk: add REE HW definitions lironh
2021-11-23 19:13 ` [PATCH v2 2/5] common/cnxk: add REE mbox definitions lironh
2021-11-23 19:13 ` [PATCH v2 3/5] common/cnxk: add REE support lironh
2021-11-23 19:13 ` [PATCH v2 4/5] common/cnxk: link REE support to ROC files lironh
2021-11-23 19:13 ` [PATCH v2 5/5] regex/cn9k: use cnxk infrastructure lironh
[not found] ` <20211123193835.20601-1-robot@bytheb.org>
2021-11-28 20:17 ` [EXT] |FAILURE| pw104631 " Liron Himi
2021-11-28 20:37 ` Thomas Monjalon
2021-11-29 9:55 ` Liron Himi
2021-11-29 10:10 ` Thomas Monjalon
2021-11-29 19:47 ` [PATCH v2 0/5] " lironh
2021-11-29 19:47 ` [PATCH v3 " lironh
2021-11-29 19:47 ` [PATCH v3 1/5] common/cnxk: add REE HW definitions lironh
2021-12-07 18:31 ` [PATCH v4 0/4] regex/cn9k: use cnxk infrastructure lironh
2021-12-07 18:31 ` [PATCH v4 1/4] common/cnxk: add REE HW definitions lironh
2021-12-07 18:31 ` [PATCH v4 2/4] common/cnxk: add REE mbox definitions lironh
2021-12-07 18:31 ` [PATCH v4 3/4] common/cnxk: add REE support lironh
2021-12-07 18:31 ` [PATCH v4 4/4] regex/cn9k: use cnxk infrastructure lironh
2021-12-08 9:14 ` [PATCH v4 0/4] " Jerin Jacob
2021-12-11 9:04 ` [dpdk-dev] [PATCH v5 0/5] remove octeontx2 drivers jerinj
2021-12-11 9:04 ` [dpdk-dev] [PATCH v5 1/5] common/cnxk: add REE HW definitions jerinj
2021-12-11 9:04 ` [dpdk-dev] [PATCH v5 2/5] common/cnxk: add REE mbox definitions jerinj
2021-12-11 9:04 ` [dpdk-dev] [PATCH v5 3/5] common/cnxk: add REE support jerinj
2021-12-11 9:04 ` [dpdk-dev] [PATCH v5 4/5] regex/cn9k: use cnxk infrastructure jerinj
2021-12-11 9:04 ` [dpdk-dev] [PATCH v5 5/5] drivers: remove octeontx2 drivers jerinj
2021-12-14 8:57 ` Ruifeng Wang
2022-01-12 14:37 ` [dpdk-dev] [PATCH v5 0/5] " Thomas Monjalon
2021-11-29 19:47 ` [PATCH v3 2/5] common/cnxk: add REE mbox definitions lironh
2021-11-29 19:47 ` [PATCH v3 3/5] common/cnxk: add REE support lironh
2021-11-29 19:47 ` [PATCH v3 4/5] common/cnxk: link REE support to ROC files lironh
2021-11-29 19:47 ` [PATCH v3 5/5] regex/cn9k: use cnxk infrastructure lironh
2021-11-29 19:49 ` [PATCH v3 0/5] " lironh
2021-11-29 19:49 ` [PATCH v3 1/5] common/cnxk: add REE HW definitions lironh
2021-11-29 19:49 ` [PATCH v3 2/5] common/cnxk: add REE mbox definitions lironh
2021-11-29 19:49 ` [PATCH v3 3/5] common/cnxk: add REE support lironh
2021-11-29 19:49 ` [PATCH v3 4/5] common/cnxk: link REE support to ROC files lironh
2021-11-29 19:49 ` [PATCH v3 5/5] regex/cn9k: use cnxk infrastructure lironh
2021-11-29 19:59 ` [PATCH v3 0/5] " lironh
2021-11-29 19:59 ` [PATCH v3 1/5] common/cnxk: add REE HW definitions lironh
2021-11-29 19:59 ` [PATCH v3 2/5] common/cnxk: add REE mbox definitions lironh
2021-11-29 19:59 ` [PATCH v3 3/5] common/cnxk: add REE support lironh
2021-11-29 19:59 ` [PATCH v3 4/5] common/cnxk: link REE support to ROC files lironh
2021-12-06 5:07 ` Jerin Jacob
2021-12-06 6:54 ` [EXT] " Liron Himi
2021-12-06 8:08 ` Jerin Jacob [this message]
2021-11-29 19:59 ` [PATCH v3 5/5] regex/cn9k: use cnxk infrastructure lironh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OLv__9hgzpXoJu7i4f=TMEWZRX-qh4+LV0LA3z79fjVQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=lironh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).