DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
	 Kiran Kumar K <kirankumark@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	 Zhirun Yan <yanzhirun_163@163.com>
Subject: Re: [PATCH dpdk 1/2] graph: always count objects and calls
Date: Tue, 9 Dec 2025 14:39:30 +0530	[thread overview]
Message-ID: <CALBAE1OMwTX=a5i56G_sPXicw=17ozvb4PBfak0ev2Ps3xwuGw@mail.gmail.com> (raw)
In-Reply-To: <20251209085028.115203-5-rjarry@redhat.com>

On Tue, Dec 9, 2025 at 2:27 PM Robin Jarry <rjarry@redhat.com> wrote:
>
> Accumulate the number of processed objects and the number of times each
> node is visited regardless of the compile time value of
> RTE_LIBRTE_GRAPH_STATS.


By default, RTE_LIBRTE_GRAPH_STATS is enabled in distro build. So why
need such changes?


>
> Accumulating these numbers do not bring much overhead when rte_rdtsc()
> isn't called.
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
>  lib/graph/rte_graph_worker_common.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h
> index 4ab53a533e4c..c87a6796a96e 100644
> --- a/lib/graph/rte_graph_worker_common.h
> +++ b/lib/graph/rte_graph_worker_common.h
> @@ -209,11 +209,11 @@ __rte_node_process(struct rte_graph *graph, struct rte_node *node)
>                 start = rte_rdtsc();
>                 rc = node->process(graph, node, objs, node->idx);
>                 node->total_cycles += rte_rdtsc() - start;
> -               node->total_calls++;
> -               node->total_objs += rc;
>         } else {
> -               node->process(graph, node, objs, node->idx);
> +               rc = node->process(graph, node, objs, node->idx);
>         }
> +       node->total_calls++;
> +       node->total_objs += rc;
>         node->idx = 0;
>  }
>
> --
> 2.52.0
>

  reply	other threads:[~2025-12-09  9:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09  8:50 [PATCH dpdk 0/2] Flexible graph nodes stats collection Robin Jarry
2025-12-09  8:50 ` [PATCH dpdk 1/2] graph: always count objects and calls Robin Jarry
2025-12-09  9:09   ` Jerin Jacob [this message]
2025-12-09  9:12     ` Robin Jarry
2025-12-09 11:13       ` Morten Brørup
2025-12-09 11:47         ` Robin Jarry
2025-12-09 12:11           ` Morten Brørup
2025-12-09 12:45             ` Robin Jarry
2025-12-09 13:45               ` Morten Brørup
2025-12-09 14:47                 ` Robin Jarry
2025-12-09  8:50 ` [PATCH dpdk 2/2] graph: allow enabling/disabling node visit cycles collection Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1OMwTX=a5i56G_sPXicw=17ozvb4PBfak0ev2Ps3xwuGw@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=rjarry@redhat.com \
    --cc=yanzhirun_163@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).