From: Jerin Jacob <jerinjacobk@gmail.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
Cc: dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com,
ptakkar@marvell.com
Subject: Re: [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers
Date: Thu, 19 Sep 2024 23:03:16 +0530 [thread overview]
Message-ID: <CALBAE1ONJ=BZO5uH77hX7NNSByR-jFjo6AbAogupjXvdvFMUGw@mail.gmail.com> (raw)
In-Reply-To: <20240731060652.7937-1-syalavarthi@marvell.com>
On Wed, Jul 31, 2024 at 12:08 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> From: Anup Prabhu <aprabhu@marvell.com>
>
> Enabled data caching for all MRVL layers in TVM models
Add why?
If it is Fix, please add Fixes: tag
Also, MRVL can be removed
>
> Signed-off-by: Anup Prabhu <aprabhu@marvell.com>
> ---
> drivers/ml/cnxk/cn10k_ml_ops.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
> index 834e55e88e9..f6b2baa0df0 100644
> --- a/drivers/ml/cnxk/cn10k_ml_ops.c
> +++ b/drivers/ml/cnxk/cn10k_ml_ops.c
> @@ -996,13 +996,8 @@ cn10k_ml_layer_start(void *device, uint16_t model_id, const char *layer_name)
> if (ret < 0) {
> cn10k_ml_layer_stop(device, model_id, layer_name);
> } else {
> - if (cn10k_mldev->cache_model_data) {
> - if ((model->type == ML_CNXK_MODEL_TYPE_GLOW &&
> - model->subtype == ML_CNXK_MODEL_SUBTYPE_GLOW_MRVL) ||
> - (model->type == ML_CNXK_MODEL_TYPE_TVM &&
> - model->subtype == ML_CNXK_MODEL_SUBTYPE_TVM_MRVL))
> - ret = cn10k_ml_cache_model_data(cnxk_mldev, layer);
> - }
> + if (cn10k_mldev->cache_model_data)
> + ret = cn10k_ml_cache_model_data(cnxk_mldev, layer);
> }
>
> return ret;
> --
> 2.45.1
>
prev parent reply other threads:[~2024-09-19 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 6:06 Srikanth Yalavarthi
2024-09-19 17:33 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1ONJ=BZO5uH77hX7NNSByR-jFjo6AbAogupjXvdvFMUGw@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=aprabhu@marvell.com \
--cc=dev@dpdk.org \
--cc=ptakkar@marvell.com \
--cc=sshankarnara@marvell.com \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).