From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D84459D8; Thu, 19 Sep 2024 19:33:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AE56406FF; Thu, 19 Sep 2024 19:33:45 +0200 (CEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id 6A8C44026B for ; Thu, 19 Sep 2024 19:33:44 +0200 (CEST) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4581ee65b46so8182881cf.3 for ; Thu, 19 Sep 2024 10:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726767224; x=1727372024; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zneXg0D+Rdob9BvED6YCyTSccii1ArTlm9rzX01IMNY=; b=T1KGxdnpQaMPvDXVVXvWcGG5N6+wtqSY4MUX5Goar8oYdPCJ+6eEIVk8QyUD/W8zQS OYyXamHuvtC4ZnNN+ZuTK+xnuXDf0yqAieTlda2e6GoC6PU0bOsTh1FNXSyPyhr4a6oJ gIEwEx/hUa9FJACcCokPgxa3QSqeTM8hbwhWhjHL49pPyBJiO/p6aKiBS+8255GjYQhv Q7YRzwAZWkEWF2bIml8Q7bO274h96MW6PtDG3kxw4ol25GDthfnbZu6FvYYPPWxqUCKp 6ju3zbyL3H7+0dju/h7WCoYgEQBvJYW0UYEAk1XnFqKtznywoYv0DJHoZHorOLqK9aOD GaxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726767224; x=1727372024; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zneXg0D+Rdob9BvED6YCyTSccii1ArTlm9rzX01IMNY=; b=AScBw4plg+GTwGMkpBzY+g0AXVeRuQ3Wni3iButIGL3OeM1IJ5dBYplTsI+ubh4o1L JdxUVH32UwrGOxfMV5Ai+E/QNidXs46L5iFKKOo2sI5C+V5m9rTusQjKV5dc7YnGxkZk Pob9wMj41LY8LJdhZ887wxBn1jqUL9YyTSKJsB8AvOS+1v8S7CXXQDMRSfOtQegwjFSp 7qr8JmRNEumzaUDnIrDDg6uJPYNksXnKFHekdZBRYe7p1t99PK+3SPbNi59KhTNljGS1 gjEg5Gx47avFTFPNr8egP6IQywsydt+vzEeEYTe8qw8KTYeLcbzZnDf3cuOdRWZodvAy QTdg== X-Gm-Message-State: AOJu0YyjnNHI8R6OfBPhzKCpJpzoNvO9cFNmS18ZsHTLhCuFZIToaLbZ cHCO5cXzU4CurRInJOiTm31htGUQPS5v1GT7HRad3Cx1K0qrsxv/VPNPUC5dAEhbXxH5R+fjGcD 4EQlr/rUq1qr4HyEcFbf0gRcjKnU= X-Google-Smtp-Source: AGHT+IFGgReIlm9BoOg3mW6bkGjRl0JLQyzA8UiT6Zs37KvWg4pFpKfU+3r9RMhIg8drSWG0WvdsdMdWvdS0RuuCIBk= X-Received: by 2002:ac8:7c48:0:b0:458:5011:666c with SMTP id d75a77b69052e-45b204de384mr2656421cf.4.1726767223725; Thu, 19 Sep 2024 10:33:43 -0700 (PDT) MIME-Version: 1.0 References: <20240731060652.7937-1-syalavarthi@marvell.com> In-Reply-To: <20240731060652.7937-1-syalavarthi@marvell.com> From: Jerin Jacob Date: Thu, 19 Sep 2024 23:03:16 +0530 Message-ID: Subject: Re: [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 31, 2024 at 12:08=E2=80=AFPM Srikanth Yalavarthi wrote: > > From: Anup Prabhu > > Enabled data caching for all MRVL layers in TVM models Add why? If it is Fix, please add Fixes: tag Also, MRVL can be removed > > Signed-off-by: Anup Prabhu > --- > drivers/ml/cnxk/cn10k_ml_ops.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_op= s.c > index 834e55e88e9..f6b2baa0df0 100644 > --- a/drivers/ml/cnxk/cn10k_ml_ops.c > +++ b/drivers/ml/cnxk/cn10k_ml_ops.c > @@ -996,13 +996,8 @@ cn10k_ml_layer_start(void *device, uint16_t model_id= , const char *layer_name) > if (ret < 0) { > cn10k_ml_layer_stop(device, model_id, layer_name); > } else { > - if (cn10k_mldev->cache_model_data) { > - if ((model->type =3D=3D ML_CNXK_MODEL_TYPE_GLOW &= & > - model->subtype =3D=3D ML_CNXK_MODEL_SUBTYPE_= GLOW_MRVL) || > - (model->type =3D=3D ML_CNXK_MODEL_TYPE_TVM && > - model->subtype =3D=3D ML_CNXK_MODEL_SUBTYPE_= TVM_MRVL)) > - ret =3D cn10k_ml_cache_model_data(cnxk_ml= dev, layer); > - } > + if (cn10k_mldev->cache_model_data) > + ret =3D cn10k_ml_cache_model_data(cnxk_mldev, lay= er); > } > > return ret; > -- > 2.45.1 >