From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B4E945BD5; Fri, 25 Oct 2024 13:02:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7012A400D5; Fri, 25 Oct 2024 13:02:34 +0200 (CEST) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by mails.dpdk.org (Postfix) with ESMTP id 4645D4003C for ; Fri, 25 Oct 2024 13:02:33 +0200 (CEST) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-288661760d3so1126589fac.3 for ; Fri, 25 Oct 2024 04:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729854152; x=1730458952; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jG14dYU5TWCkcGxfv6ysuvb7bP0sJ+CEaBvxUXFk9Lw=; b=P3ouemEfLa99f7G0bt3RsPi3TNA/OrsLYLUXzJY68HNrnSReKFFcne1nmjqzQY86En BD82btMlH3HT7tkDy4YYCMDEDJ4mKe8DfvMZRzbiKZ5TfCB/qdnRSGNvuMVGmwjOFnAx G8gvrnbZBxX9X6Rj/l/nghCVEUo5kp+Ei6tshFDorddKri1bV3V/9WOXd3eAjGsXqc6h yAxcmlmxbO9jvuR3Dz4g3t1dVikUN3jmOBgNGzuiVkiqtS2gIw8lUzaUG+xJgIYf/+Dh xJseyw22vB27QHBvcgPChGD0npUZIOy1d4NUazEuXppCIHddlgHc+Tv6qyg/xHvt1chz DoVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729854152; x=1730458952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jG14dYU5TWCkcGxfv6ysuvb7bP0sJ+CEaBvxUXFk9Lw=; b=JtxH/kMLXRtJZpOF0BUWq72a/5IeYF3ebYjtCa9fbCME8Y/KV5kp2U3o9VSjTzhdWt 23p/EoXBlpc1usA2l4Ocuzez4iwRPzA4wjWwNKUGAKSeiyngWmgnQiUez1svE7VLCFXS +Q+OA/SwDmYUOzwNivwy0x+to0sdkdy8QkX7fuYSNADMtZfHQ9ad2RJrQOIV1+I2Z/VR 8teyFIuEj1Q0LWr53Nv9aNAWci2Y3m0ba1ox8ZKcWBhb2RMrfoMmi/HyX0WQPqpnzfDi 0vd5Hnr4woZbV2T+QSzi/znPl7f/pIGPtJa9Prv6KzjbLVmy0N3+JUemww35p8IJj4Hr sIdg== X-Forwarded-Encrypted: i=1; AJvYcCW/V5V67VXTIUuXzIWPY1nU16IwqgrXBqCqhFnFsvPXkwwZqExpWe/Ppd/v+BGc37ElgQo=@dpdk.org X-Gm-Message-State: AOJu0YwNyiA6OkdXhR4ZSt+4dIlJWKRLqxP4c0rbApehCoe8SbtVWtP3 i9tAPXW2HDAs3fQmV2iSlbl7XdLcv+650Lwl7O0FxLYS2qW35p8b8FiFY72EoGIqoRI0Kz59UPN +m5LY8Mngl6a2A0rnBdhqGiV49sQ= X-Google-Smtp-Source: AGHT+IHi4BqJKEOEphxg9JTIzYrCfPaAaApYNwUAnPnjrcf9HIDXMzWqv4Ttn0ubAaS8dP7t/j2ygYtKqwGdkK6yInc= X-Received: by 2002:a05:6870:330c:b0:277:fbac:1f71 with SMTP id 586e51a60fabf-28ced117a4emr5386185fac.3.1729854152134; Fri, 25 Oct 2024 04:02:32 -0700 (PDT) MIME-Version: 1.0 References: <20241011094944.3586051-1-tduszynski@marvell.com> <20241025085414.3412068-1-tduszynski@marvell.com> <20241025085414.3412068-5-tduszynski@marvell.com> In-Reply-To: <20241025085414.3412068-5-tduszynski@marvell.com> From: Jerin Jacob Date: Fri, 25 Oct 2024 16:32:05 +0530 Message-ID: Subject: Re: [PATCH v15 4/4] eal: add PMU support to tracing library To: Tomasz Duszynski Cc: Jerin Jacob , Sunil Kumar Kori , Tyler Retzlaff , Ruifeng.Wang@arm.com, bruce.richardson@intel.com, david.marchand@redhat.com, dev@dpdk.org, konstantin.v.ananyev@yandex.ru, mattias.ronnblom@ericsson.com, mb@smartsharesystems.com, stephen@networkplumber.org, thomas@monjalon.net, zhoumin@loongson.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 2:25=E2=80=AFPM Tomasz Duszynski wrote: > > In order to profile app one needs to store significant amount of samples > somewhere for an analysis later on. Since trace library supports > storing data in a CTF format lets take advantage of that and add a > dedicated PMU tracepoint. > > Signed-off-by: Tomasz Duszynski --------------START------------------------- > diff --git a/lib/eal/common/eal_common_trace_points.c b/lib/eal/common/ea= l_common_trace_points.c > index 0f1240ea3a..c99eab92f4 100644 > --- a/lib/eal/common/eal_common_trace_points.c > +++ b/lib/eal/common/eal_common_trace_points.c > @@ -100,3 +100,8 @@ RTE_TRACE_POINT_REGISTER(rte_eal_trace_intr_enable, > lib.eal.intr.enable) > RTE_TRACE_POINT_REGISTER(rte_eal_trace_intr_disable, > lib.eal.intr.disable) > + > +#ifdef RTE_LIB_PMU > +RTE_TRACE_POINT_REGISTER(rte_eal_trace_pmu_read, > + lib.eal.pmu.read) > +#endif > > #define RTE_EAL_TRACE_GENERIC_FUNC rte_eal_trace_generic_func(__func__) > > +#ifdef RTE_LIB_PMU > +#include > + > +RTE_TRACE_POINT_FP( > + rte_eal_trace_pmu_read, > + RTE_TRACE_POINT_ARGS(unsigned int index), > + uint64_t val =3D rte_pmu_read(index); > + rte_trace_point_emit_u64(val); > +) > +#endif > + --------------END------------------------- All of the above changes can go to lib/pmu. Right? Like ethdev is adding its trace points in ethdev library? and make trace point name as rte_pmu_trace_read