From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C535A0352; Mon, 18 Nov 2019 19:30:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A89C2B62; Mon, 18 Nov 2019 19:30:42 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id E4B272AB for ; Mon, 18 Nov 2019 19:30:41 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id m5so16956452ilq.0 for ; Mon, 18 Nov 2019 10:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uQjK9Ym+8LStHPFm8b4TxZZyzPg9sSsCDrHocooondU=; b=tlUNJpekgM0aylzQU6Wvclf3a9b3zlBPxyHcafPEPdULHn9bSae7NqDLpGLEy53npo PCgsU02ClaxPMtUPxbDbwt5mfDh5n8A8V/7MjC+mc2wu9BXMgKqdfxB4nUGq2D+Z50s5 8H+KvygSWTSN8Yu6lZoHRHBLSseWRd7KJ3AYhsDzsmrCQGWBAXPMr4FkbVc06xVmqKEH 3Agkb/E0GF3VMl0/u8t2iN8vjobrDTlUlCLgyUePgFVFnhb+i9LU79uIZe/DCj4bA+lD 4HDQp5NQwuit3mREkiRM549s76Ign5JbzN+ZdUeYLm+u+VZ8hJFB+iat8UUwAipkQaiM ma3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uQjK9Ym+8LStHPFm8b4TxZZyzPg9sSsCDrHocooondU=; b=jawxciUPcQmHYzWMYGO72dcgzDV08vU8DbQr9oYzX/RSjkz3P8gqIB/LOvZS9y9IXn X8W5YxMpeRDnq94uDI7GgD6x6tCL7ZbsDcnjPuhpB/6DqlvzipWvcl8355FCzho9L5S+ MhF6APnEvfYmwHNW75mdSVz7arWhoToEEjpv01/w5A7dpKgHbsVBqXOYLKRk8McCHM9n Qop5m7hZOPz3/TNa5eu2lUYWXSAfGcT1sDSmMa/pLZxEb66E5WV6+TPITy9sIfPQT/Fp eGmo8zqlKkfPjKdEuSaHnCVf53oH+RGnBCA7x489KseRywYFLdzFj6kc4Z1rcYtjc26u 5uSQ== X-Gm-Message-State: APjAAAW9+rwQZxyFSiaky7/p0c47kEQLt8xVaquvqld1uHccLSPvg8yg 8UbPX8hJqiuqUJcbBqp+g9wDawCvbTRI7UlptwM= X-Google-Smtp-Source: APXvYqwpiGHFS15lfn8fWssAJr0QTKsPaRYOgnkqqYtLBQoiHyigB+mNmfCg1DR4mz9IuRxIvxzSjTH/ZLn3ifTH1PE= X-Received: by 2002:a92:afd5:: with SMTP id v82mr18597066ill.294.1574101840868; Mon, 18 Nov 2019 10:30:40 -0800 (PST) MIME-Version: 1.0 References: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com> In-Reply-To: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com> From: Jerin Jacob Date: Tue, 19 Nov 2019 00:00:31 +0530 Message-ID: To: Thinh Tran Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 18 Nov, 2019, 11:49 pm Thinh Tran, wrote: > Simple change to enable scatter for Mellanox CX4/CX5 PMDs > to run this example > > Signed-off-by: Thinh Tran > --- > examples/ip_reassembly/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c > index d59e6d02f..f881b89d1 100644 > --- a/examples/ip_reassembly/main.c > +++ b/examples/ip_reassembly/main.c > @@ -1109,6 +1109,9 @@ main(int argc, char **argv) > port_conf.rx_adv_conf.rss_conf.rss_hf, > > local_port_conf.rx_adv_conf.rss_conf.rss_hf); > } > + /* Mellanox PMDs needs scatter mode to be explicitly > enabled */ > + if (!strcmp(dev_info.driver_name, "net_mlx5")) > No driver specific code in generic application. Please fix the driver instead. + local_port_conf.rxmode.offloads |= > DEV_RX_OFFLOAD_SCATTER; > > ret = rte_eth_dev_configure(portid, 1, > (uint16_t)n_tx_queue, > &local_port_conf); > -- > 2.17.1 > >