From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85DF6A0543; Mon, 13 Jun 2022 09:00:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A04B410DD; Mon, 13 Jun 2022 09:00:03 +0200 (CEST) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by mails.dpdk.org (Postfix) with ESMTP id 15C3E40150 for ; Mon, 13 Jun 2022 09:00:02 +0200 (CEST) Received: by mail-qk1-f171.google.com with SMTP id 15so3411548qki.6 for ; Mon, 13 Jun 2022 00:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RPst0UanBxcIUpSTT97/naR4l/qenMShGkuikFH74pM=; b=UG/N7FxwVzlvD5AjDvU7j+LdNt3yTFGRgJ2hQZ6zTeQU3s1DoQcIVNhET90VuUorQT AMRw8iYLQOf7l0+f4Bc3IiFfga0WimQQD5EMOG5zU6NyZvl//KmBEbj17SATh28NGvEb 3Z8hiAATG/SO2PPMHXFicVhFP7CMlujJDA5VNT3PMwsoOpHJJFmHbC7QoLRXrry8jllG Qq3v9WRJTxgrtGquxjKVtvTZo5oFH9yC9BPHMRqek4igCVvjmuKsUUVgBhmIWcis09GR XsfM5P1I5efEdGiECQCBOwknwYrQp1tOnEcmdBOLs1JyRZfEneiRJE7B0D9WRnnB6lwf Nv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RPst0UanBxcIUpSTT97/naR4l/qenMShGkuikFH74pM=; b=v6cxGDqOcoIIK4yeTvQ6a9fmqfkPNlY1JHjfeC4o73PMEi631bv/p2REfNpP+IlcJF rjwoBISeBsxwdCef1EKIZarMEH/chPQIBzTAt+tXEiWjsWs9UZE+v4Rr7OT8xmMBdBJg gREqHP37bra9QJPVwCBwiW4IaqVr1oVT2tHoOP1FZBbU4hORauz5BmJ9wejYKnxfyIVG ml7tikvVC8qgT93gkZbYS7fo1a9k9ZCNaGNHjSTertn7dExLSPY2FYH+XIQKLCWwuV7b S7TGgYJ/5cKH3cUQSNnWpCN4NjU2kV6jajRxbI9iVSYLTNxW1yvZ8R/rkWo0F7rfPhX0 FsYA== X-Gm-Message-State: AOAM530QIYcvlRB1gggBLBGhuUSSR3l16D5QY+Sgt/n1U9NExxM7L2ia OGaq1WigfsthputhR2VjQ9NGG8bM7BSD3KurHiN5QhOpumk= X-Google-Smtp-Source: ABdhPJxtm3F5ERAg7MWRtg8WNaSWKn+lI4PjFu/dLVdsqPWucErouzuXv09rKEF6BbLdM8Gatw5IS79CCpNrpQwV/OE= X-Received: by 2002:a05:620a:424b:b0:6a7:8eda:bb29 with SMTP id w11-20020a05620a424b00b006a78edabb29mr2489507qko.26.1655103601521; Mon, 13 Jun 2022 00:00:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Mon, 13 Jun 2022 12:29:35 +0530 Message-ID: Subject: Re: [PATCH] app/test-eventdev: wait for workers before cryptodev destroy To: Pavan Nikhilesh Bhagavatula Cc: Shijith Thotton , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 13, 2022 at 12:08 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -----Original Message----- > > From: Shijith Thotton > > Sent: Thursday, June 2, 2022 5:15 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > > Nikhilesh Bhagavatula > > Subject: [PATCH] app/test-eventdev: wait for workers before cryptodev > > destroy > > > > Destroying cryptodev resources before exiting workers are not safe. > > Moved cryptodev destroy after worker thread exit in main thread. > > > > Fixes: de2bc16e1bd1 ("app/eventdev: add crypto producer mode") Cc: stable@dpdk.org > > > > Signed-off-by: Shijith Thotton > > Acked-by: Pavan Nikhilesh Acked-by: Jerin Jacob Applied to dpdk-next-net-eventdev/for-main. Thanks > > > --- > > app/test-eventdev/evt_main.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-eventdev/evt_main.c b/app/test-eventdev/evt_main.c > > index c5d63061bf..b785e603ee 100644 > > --- a/app/test-eventdev/evt_main.c > > +++ b/app/test-eventdev/evt_main.c > > @@ -159,9 +159,6 @@ main(int argc, char **argv) > > if (test->ops.ethdev_rx_stop) > > test->ops.ethdev_rx_stop(test, &opt); > > > > - if (test->ops.cryptodev_destroy) > > - test->ops.cryptodev_destroy(test, &opt); > > - > > rte_eal_mp_wait_lcore(); > > > > if (test->ops.test_result) > > @@ -173,6 +170,9 @@ main(int argc, char **argv) > > if (test->ops.eventdev_destroy) > > test->ops.eventdev_destroy(test, &opt); > > > > + if (test->ops.cryptodev_destroy) > > + test->ops.cryptodev_destroy(test, &opt); > > + > > if (test->ops.mempool_destroy) > > test->ops.mempool_destroy(test, &opt); > > > > -- > > 2.25.1 >