From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CDD9A0A02; Thu, 14 Jan 2021 14:29:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E93F5141258; Thu, 14 Jan 2021 14:29:56 +0100 (CET) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 0C942141257 for ; Thu, 14 Jan 2021 14:29:56 +0100 (CET) Received: by mail-io1-f48.google.com with SMTP id y19so11133973iov.2 for ; Thu, 14 Jan 2021 05:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KdXSS17KAC0pw11BHom7NANmEX5/rb0jukREk1D0plI=; b=qMY7lRY4VsuUrFtRRzBZnG58WasrJOe8aEmUnDHvAd0+93TSzeFa1z818EcP07MU4x MwRzFsomaa7UY8W6Cbii6/WKXzfne9ClFp6qYtZ9fFHl1gpW7MttKT7Tea5t6hGSlHAR m7HarNZhipctiQUHZTHry1qbvn3oe2jZHzmrzTfyQQYpyvsWQM5BONfFI0o0DwgqN/PA LqxsMAKFKMQv5TfNSMTHFL7fspt7RVg7ypIZHndxmkZd2mJzdBqAqAwguqrVJaeczKvN LOA/q8powvT7CouTfivbhdouJCg+xf/dmCUg1Tn+zG5PvhAYiv6EThWYp33CsDl7oDOj s6aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KdXSS17KAC0pw11BHom7NANmEX5/rb0jukREk1D0plI=; b=s6nuJzPG4PzTPfEmq374UWksnwFomC41wzm7ohkM4TpRJgJECHDsg3sJll0ia1iT+f de9DIOmC9yOX2M7CJ2Y9ZyhQ7SxfdNSafe1NGrtbD8b189gEMVAfn48WMw5o+C22CdxH A2aNnvwmmF0HF5IW3O+pDngoqP05h/fZb9vMNMFTucrHAOog965+tXSq/uF/HgwGdhO8 G2qYC1t9/O8hrFHy2i3iHpwJXRT5AbarNjBKFo2HyS2o2rNHQuDR6mC+IcvRKyG+A7z9 kOXIRK5ovP3e54GUUr9nQyAKHwCl2tO0NdTvDF9enhCxAGM0FEHmqDL7d7/9DhzZ4Ajg hcyQ== X-Gm-Message-State: AOAM530Xk/F2XIlcIo0OSuvpaPF3AsygVa3PDD0KHS7SZyD4AnvllcPk hgrIS9Gg+iz/g6wdAcugW/gHWV9aqkaVSjAvyng= X-Google-Smtp-Source: ABdhPJztCRaRensDYVQrZXbvcoHJFII+dMIl5OVTNf1h335zmRlsz0/osnNu06GEx5pBVMultqU6jKc5+FgPQE2fEZg= X-Received: by 2002:a02:23ce:: with SMTP id u197mr6352224jau.113.1610630995410; Thu, 14 Jan 2021 05:29:55 -0800 (PST) MIME-Version: 1.0 References: <2a4ca79e-8051-c0c2-8bea-a0f972a69d8e@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 14 Jan 2021 18:59:39 +0530 Message-ID: To: Rasesh Mody , Ferruh Yigit Cc: Igor Russkikh , Balazs Nemeth , "dev@dpdk.org" , Devendra Singh Rawat Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 12, 2021 at 11:25 AM Rasesh Mody wrote: > > > From: Jerin Jacob > > Sent: Tuesday, January 12, 2021 10:21 AM > > > > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody wrote: > > > > > > > From: dev On Behalf Of Igor Russkikh > > > > Sent: Monday, January 4, 2021 6:15 PM > > > > > > > > > When calling rte_eth_promiscuous_enable(port_id) followed by > > > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc > > > > > mode anymore. This patch ensures that promisc mode takes > > > > > precedence over allmulticast mode fixing the regression introduced by > > b10231aed1ed. > > > > Please add Fixes: > > > > > > > > > > > > Signed-off-by: Balazs Nemeth > > > > Even if promiscuous mode is disabled after the change, allmulti mode setting will persist. > Fix looks good to me. > > Acked-by: Rasesh Mody Fixed check-git-log.sh issues and applied to dpdk-next-net-mrvl/for-main. Thanks > > Thanks, > Rasesh > > > > > Igor >