From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6BE2A0093; Mon, 7 Mar 2022 08:45:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88B5C4068F; Mon, 7 Mar 2022 08:45:15 +0100 (CET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id 9418340040 for ; Mon, 7 Mar 2022 08:45:14 +0100 (CET) Received: by mail-io1-f47.google.com with SMTP id s20so2688266iol.2 for ; Sun, 06 Mar 2022 23:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NeOVEe4q156Ib71+z1hbpXqAok6Hq/qx/W1MCCcCIqA=; b=nUK9wd6KEvyC7uozga1HVxEAe83/XY34QZRC51gtYOBW8rLHuARe9ejhYgLMVx0FJm PtGyQ23Q8/nrXNeeDzx9rNK8KGVy5DKyjKeBj6rWvDZweLUDuf5B10sxoqa16EnUM0vc hl+dA8lQUB9mcPhRWGnw91mhii1bOSMFk6XddwJBBq0yB3j1DZdfAbKuoKrskKJLO0K8 zIS/OhlQodkHXXZSWLRW5FXWSvF1v23X4mHTSfMf/HvEDMBac3zDHKktVBjJTEX7Kxrl FfYYqZyvSx7hxDlVSsHScFZ/MoG8FDe96T03eBbLbszaYWciV4qw3dV+ewSSd/mCrvn8 O/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NeOVEe4q156Ib71+z1hbpXqAok6Hq/qx/W1MCCcCIqA=; b=url6EaZQjzBXTxjzqGA4ix/PZmgdCTSs3Z3rGFzqZgyzYlNrCszi9vQyHMPW8yP1Qp wwGVDQ/heqqB4JeCnN9l0tPgid2HhvjJJ8Ji1E3v7wDtgwpkJaXiRfn3OZXRsgbLr0EK m1q0eETXmth+SwrxnLr3n/E7LSkldsD9iJermW4/NS6qshpqfxQpWFRyPCoBgyU97JKe tIsF0radiyFdWmu8tZkvzPZ2yJiNm5IlqjLx5LmIJ5hfZB0tVpIHZtqt4XQUDMLUxzHq mD9KbZ9GwON1i+Usy3AyujcCLVNlaq89SToy2+/7EjeqNY77THix5gRZ0Vd/ALn4lmgO FSIw== X-Gm-Message-State: AOAM532tpgrSE/WCCXIkiH+DlBeQv0u6C9pgjCGICD1sxoPB5PVGGdhl tGnhZh7m7rPEsXG0lTlkWcLDs9l1vJR95OuQpRY= X-Google-Smtp-Source: ABdhPJwn1fcsg3Mk1SjwjTpgqHilYxSxWIxoF5urgb20mPfujMACb84AJcRTr0VDvVLcQBgnBtQYLM3hqPE4F+0ETGI= X-Received: by 2002:a05:6638:338f:b0:317:8011:c638 with SMTP id h15-20020a056638338f00b003178011c638mr10001789jav.123.1646639113842; Sun, 06 Mar 2022 23:45:13 -0800 (PST) MIME-Version: 1.0 References: <20220307064318.1002855-1-haiyue.wang@intel.com> In-Reply-To: <20220307064318.1002855-1-haiyue.wang@intel.com> From: Jerin Jacob Date: Mon, 7 Mar 2022 13:14:47 +0530 Message-ID: Subject: Re: [PATCH v1] graph: remove the useless duplicate name check To: Haiyue Wang Cc: dpdk-dev , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 7, 2022 at 12:47 PM Haiyue Wang wrote: > > The node clone API parameter 'name' is the new node's postfix name, not > the final node name, so it makes no sense to check it. And the new name > will be checked duplicate when calling API '__rte_node_register'. > > Signed-off-by: Haiyue Wang Could you check the test failure with this change? Reproducer: echo "graph_autotest" | ./build/app/test/dpdk-test -c 0x30 --no-huge > --- > lib/graph/node.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/lib/graph/node.c b/lib/graph/node.c > index 79230035a2..ae6eadb260 100644 > --- a/lib/graph/node.c > +++ b/lib/graph/node.c > @@ -150,10 +150,6 @@ node_clone(struct node *node, const char *name) > goto fail; > } > > - /* Check for duplicate name */ > - if (node_has_duplicate_entry(name)) > - goto fail; > - > reg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges)); > if (reg == NULL) { > rte_errno = ENOMEM; > -- > 2.35.1 >