From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D3245A0562;
	Sat,  4 Apr 2020 15:12:28 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 486555F13;
	Sat,  4 Apr 2020 15:12:28 +0200 (CEST)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com
 [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id A2BFDFFA
 for <dev@dpdk.org>; Sat,  4 Apr 2020 15:12:27 +0200 (CEST)
Received: by mail-io1-f68.google.com with SMTP id q9so10662237iod.4
 for <dev@dpdk.org>; Sat, 04 Apr 2020 06:12:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=ubuzQdlG+nzleWAJIyZWsaoM1+8Chxgth2+9Ksf/VtQ=;
 b=o0LbWnxijc1YHSxnxg0Af3vq3zCVL6mCQx6BbFuRHXp5Ff+ScqjlNjNjsIGax1QFpN
 6P7ToIrhYgVHFf2CJmxQGvIQ07gju1TNJPdG+wD6DtMpe39c62w5/A4kvi3aswGyGag3
 BXCPmx+Ls7uDOxe7F1nDBS2qXSXneFflzfQjtJQA5kLJ4BD1UqfzumHjGcK5zopcSOAb
 OBV8hK8zmQ1h3ha3amqsyKapIVNlhfqhYhL4swayodCVQP8MOHQfPsIXdE11MLsZCVyn
 DQyDQWWcj+f0iJra4RC5ZC47Xk5BKlqDAQjjDjGcQHC0vqRpLqFjFnhLLNpk97ixMcvX
 0ptg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ubuzQdlG+nzleWAJIyZWsaoM1+8Chxgth2+9Ksf/VtQ=;
 b=GC168/oqE25ebVpQi7VJMzrft2pmExkZq2EnV/Lw6uLPID/ExDOU/y/wg3dwusa4FV
 VZHrnynsqtxzwGfCckLZw7DBqcVJ550U2iHCRAuzvW2I086xFq0C9c83YG4fNHJzlRav
 4AVvJzFRgfew+6feBS2Kpqm2xB1lIBvTR0BO+i7R0hNKvb++11jlo70PtirCyEwOPfHe
 m/jzWLF6aLKZ0wR5gODhgzO1lL/VAFm48+oV/W2UXFXhY4TJBKZlr4wzd1En2eKpOHDH
 dDBSWfMy021kQ4XI/O/tjypAozDkE+GpX8inI73R30lY0W1eu4Jea9P61HiDmGisgkDK
 y1SQ==
X-Gm-Message-State: AGi0PuYQdZg04eyc7Wsc1Th2nS3prX8rlLQnSJEkDdFkYjbNZvs72sIb
 ngF38UONTmD24ybUejx7HRfXzwz2cH5LHZW+0gA=
X-Google-Smtp-Source: APiQypIidRKuEkP8w7d2RktFZxNDXziwqxSETev5E436Jxpiz57kqESQCfWBd/z7a8ut+p/BhGDJTizjmRsMV0dgx9U=
X-Received: by 2002:a6b:dd14:: with SMTP id f20mr12246990ioc.123.1586005946981; 
 Sat, 04 Apr 2020 06:12:26 -0700 (PDT)
MIME-Version: 1.0
References: <20200326165644.866053-1-jerinj@marvell.com>
 <20200331192945.2466880-1-jerinj@marvell.com>
 <20200331192945.2466880-5-jerinj@marvell.com>
 <DM5PR11MB1484DE1A8940D9356B3FA5C9B8C40@DM5PR11MB1484.namprd11.prod.outlook.com>
In-Reply-To: <DM5PR11MB1484DE1A8940D9356B3FA5C9B8C40@DM5PR11MB1484.namprd11.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Sat, 4 Apr 2020 18:42:11 +0530
Message-ID: <CALBAE1OSv-JKW2=3mumbOmdfz0C=zhf1ud1ZfDpvNv159rAojQ@mail.gmail.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, 
 "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, 
 "david.marchand@redhat.com" <david.marchand@redhat.com>,
 "mdr@ashroe.eu" <mdr@ashroe.eu>, 
 "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>, 
 "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, 
 "ndabilpuram@marvell.com" <ndabilpuram@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 04/29] graph: implement node debug routines
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Apr 4, 2020 at 1:27 PM Wang, Xiao W <xiao.w.wang@intel.com> wrote:
> > +static void
> > +node_scan_dump(FILE *f, rte_node_t id, bool all)
> > +{
> > +     struct node *node;
> > +
> > +     RTE_ASSERT(f != NULL);
> > +     NODE_ID_CHECK(id);

This one is using fail: jump. See below

> > +     STAILQ_FOREACH(node, &node_list, next) {
> > +             if (all == true) {
> > +                     node_dump(f, node);
> > +             } else if (node->id == id) {
> > +                     node_dump(f, node);
> > +                     return;
> > +             }
> > +     }
> > +fail:
> we can remove this "fail" mark since it's not used as jmp target.

See above.

>
> > +     return;
> > +}
>