From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <nithind1988@gmail.com>
Cc: Sunil Kumar Kori <skori@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix corruption in segments list
Date: Tue, 12 Jan 2021 23:43:44 +0530 [thread overview]
Message-ID: <CALBAE1OTH8n=e55KQ7znVEp-QoqjSe+xYHn_HLvaz_icbb3ryA@mail.gmail.com> (raw)
In-Reply-To: <X+nM1w0dKtUHbQJx@gmail.com>
On Mon, Dec 28, 2020 at 5:48 PM Nithin Dabilpuram <nithind1988@gmail.com> wrote:
>
> On Mon, Dec 21, 2020 at 07:33:08PM +0530, skori@marvell.com wrote:
> > From: Sunil Kumar Kori <skori@marvell.com>
> >
> > On Tx, lastseg->next is not being reset to null for multi segmented packet
> > and same mbuf can be used on Rx which has a stale mbuf entry into
> > mbuf->next.
> >
> > On Rx, application receives mbuf with mbuf->next uninitialized though
> > mbuf->nb_segs is correct. Application iterates over all segments using
> > mbuf->next ignoring mbuf->nb_segs which leads to undefined behavior.
> >
> > So earlier assumption of just having right value in mbuf->nb_segs is
> > enough, is incorrect. Mbuf must contain valid and synced value in
> > nb_segs and next pointer.
> >
> > Fixes: 364eb0e46683 ("net/octeontx2: avoid per packet barrier with multi segment")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> >
>
> Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
prev parent reply other threads:[~2021-01-12 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 14:03 skori
2020-12-28 12:17 ` Nithin Dabilpuram
2021-01-12 18:13 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OTH8n=e55KQ7znVEp-QoqjSe+xYHn_HLvaz_icbb3ryA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=nithind1988@gmail.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).