From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35E5C45943; Mon, 9 Sep 2024 06:46:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 044AE402BE; Mon, 9 Sep 2024 06:46:47 +0200 (CEST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by mails.dpdk.org (Postfix) with ESMTP id 4FEB4402A8 for ; Mon, 9 Sep 2024 06:46:45 +0200 (CEST) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4583209a17dso2807291cf.1 for ; Sun, 08 Sep 2024 21:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725857204; x=1726462004; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sSbSGqbRnvZCSzb/ov4L8aEVPe1Kjpw9WsUD20eEz8w=; b=Pz2SfkxNhTOQiJHiY0lEm0DAuXLS8agTYt2b3yPwWuY2m6EUhgZP5b4gYFzaTK4QJ3 dmSjPYWJuQkuBEXTXPQy3GK4mvixFkDti9OI5Hf6KFcVQoQanwOCWFUeztaa8//OgacA aSbbNwXBKw7e6lkxAJTBvRQo5oV130B+J61kQs6MKmskDZTYnBwxCsB7aphNrn2DRRYq AMfF4ctSd2g7QjP3FX2ZbtcquCe8JbUlDBSp+zI/jIvB0zDN8CVRooCw/qXaoM1lW5MO W7aLAjWrtsW6tT5Uvzfwpv93d2Cc1gp3/yvQOYAarREeiMjidu/t58gCVmV2q20iRZcy cMew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725857204; x=1726462004; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sSbSGqbRnvZCSzb/ov4L8aEVPe1Kjpw9WsUD20eEz8w=; b=lzATrriO36Mwu4Z21LwASMwVerEUb2POQxONGwKTMj97l7cOA77KDShX+pq/A4eSLC vdmMxgQThFMlQu5vR/usQHm92n99PAHcxFDfqSBRuKw9qGI/OIWnd4hxAWtToZCad5ED 36ZXoA5+VyKZX0CjrN0OvqSO/Y2bg/9ow9e80xKSKZZUHybHhHq9FEX9Ac/j3L36u2iB q+Fa87RXFKr0au/zvq/K04jx4y217QCsNxclXMghP+YyhmmmWOhc4EzOtMwiim18DQYY 1iVuXccDL2BgYAQh2jwNGmEGyZ6PHbGVNy4WAD+iyvxPY5GTHQsfgIsHFFTffO+8f1Xk lRZA== X-Forwarded-Encrypted: i=1; AJvYcCWsdGLExMftEShHlgxSbE4TihzmUGYTw1BGqy58JDsnsl1tS0Qc2j5klalLRt/X3XvwhAs=@dpdk.org X-Gm-Message-State: AOJu0Yw1+eN+D+wZyDHnxQL44IOxWpz6MM2f8xFiGSrtZbALK+C6FH6L 2WvvMw4D9kRhGk6v29iyaYy4YQm2W7LXu2q8bEXmSSRHwW4NqyGlkfeBExPeEfGq4Fb04WvhCtT veGYQGxjntFAQK7MtfI9uZ5iX+3k= X-Google-Smtp-Source: AGHT+IFUheP+RsKM7UySiV4dljsKYpk09SDx0Tn/On9Et0Z8wgOkdEV7lsGrv1kSnUoHbyihbmIsoawIGVJW9tMPSMI= X-Received: by 2002:ac8:5a0e:0:b0:456:8ee8:f5ed with SMTP id d75a77b69052e-4580c78def9mr117943501cf.48.1725857204421; Sun, 08 Sep 2024 21:46:44 -0700 (PDT) MIME-Version: 1.0 References: <20240904180954.104473-1-stephen@networkplumber.org> <3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com> <52b4caae-b4ef-4ee6-bd61-cd4147defd0f@amd.com> In-Reply-To: <52b4caae-b4ef-4ee6-bd61-cd4147defd0f@amd.com> From: Jerin Jacob Date: Mon, 9 Sep 2024 10:16:18 +0530 Message-ID: Subject: Re: [PATCH 0/3] eal: mark API's as stable To: Ferruh Yigit Cc: David Marchand , Stephen Hemminger , dev@dpdk.org, Jerin Jacob Kollanukkaran , Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 7:33=E2=80=AFPM Ferruh Yigit = wrote: > > On 9/6/2024 2:11 PM, Jerin Jacob wrote: > > On Fri, Sep 6, 2024 at 3:04=E2=80=AFPM Ferruh Yigit wrote: > >> > >> On 9/5/2024 8:58 AM, David Marchand wrote: > >>> On Wed, Sep 4, 2024 at 8:10=E2=80=AFPM Stephen Hemminger > >>> wrote: > >>>> > >>>> The API's in ethtool from before 23.11 should be marked stable. > >>> > >>> EAL* ? > >>> > >>>> Should probably include the trace api's but that is more complex cha= nge. > >>> > >>> On the trace API itself it should be ok. > >>> The problem is with the tracepoint variables themselves, and I don't > >>> think we should mark them stable. > >>> > >> > >> We cleaned tracepoint variables from ethdev map file, why they exist f= or > >> 'eal'? > >> > >> I can see .map file has bunch of "__rte_eal_trace_generic_*", I think > >> they exists to support 'rte_eal_trace_generic_*()' APIs which can be > >> called from other libraries. > >> > >> Do we really need them? > >> Why not whoever calls them directly call 'rte_trace_point_emit_*' inst= ead? > >> As these rte_eal_trace_generic_*()' not used at all, I assume this is > >> what done already. > >> > >> @Jerin, > >> what do think to remove 'rte_eal_trace_generic_*()' APIs, so trace > >> always keeps local to library, and don't bloat the eal .map file? > > > > The purpose of exposing rte_eal_trace_generic_* is that, applications > > can add generic trace points > > in the application. > > > > Can't applications use 'rte_trace_point_emit_*()' directly, as libraries > does? It is two different usages. 'rte_eal_trace_generic_ case is more like, application wants to simply emit int via generic trace API but not add any _new_ trace point.