DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ashwin Sekhar T K <asekhar@marvell.com>, dpdk-dev <dev@dpdk.org>,
	Jerin Jacob <jerinj@marvell.com>,
	 Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size
Date: Thu, 16 Sep 2021 22:05:46 +0530	[thread overview]
Message-ID: <CALBAE1OUo4FL6-xT7uctp1hqjJng29oXySwH+cpZkh9Wt_EnbA@mail.gmail.com> (raw)
In-Reply-To: <d57bef9a-a1ca-0153-75f1-255e3bfd6afb@intel.com>

On Thu, Sep 16, 2021 at 8:46 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 8/30/2021 2:52 PM, Ashwin Sekhar T K wrote:
> > NPA stack should be aligned to ROC cache line size.
> >
>
> Can you please document the long versions of 'NPA' & 'ROC' abbreviations?
>
> Also for the patch title, since abbreviations needs to be uppercase, to automate
> the check for these abbreviations, can you please add them to
> './devtools/words-case.txt' in separate patch.

Please do add  NIX, NPC, CPT, SSO, LBK, MCAM too.


> And can you add some more context on the reasoning of the change, why it should
> be aligned to cache line?
> What is the impact user/application sees if it is not aligned, and after aligned?
>
> Thanks,
> ferruh
>
> > Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
> >
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
> > ---
> >  drivers/common/cnxk/roc_npa.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
> > index d064d125c1..a0d2cc8f19 100644
> > --- a/drivers/common/cnxk/roc_npa.c
> > +++ b/drivers/common/cnxk/roc_npa.c
> > @@ -194,7 +194,7 @@ npa_stack_dma_alloc(struct npa_lf *lf, char *name, int pool_id, size_t size)
> >  {
> >       const char *mz_name = npa_stack_memzone_name(lf, pool_id, name);
> >
> > -     return plt_memzone_reserve_cache_align(mz_name, size);
> > +     return plt_memzone_reserve_aligned(mz_name, size, 0, ROC_ALIGN);
> >  }
> >
> >  static inline int
> >
>

  reply	other threads:[~2021-09-16 16:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 13:52 Ashwin Sekhar T K
2021-09-16 14:27 ` Jerin Jacob
2021-09-16 15:15 ` Ferruh Yigit
2021-09-16 16:35   ` Jerin Jacob [this message]
2021-09-17 11:23 ` [dpdk-dev] [PATCH v2] common/cnxk: align NPA stack to ROC " Ashwin Sekhar T K
2021-09-21  9:12   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1OUo4FL6-xT7uctp1hqjJng29oXySwH+cpZkh9Wt_EnbA@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=asekhar@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).