From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16FFCA0C41; Thu, 16 Sep 2021 18:36:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B4EF407FF; Thu, 16 Sep 2021 18:36:14 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 8E3314069E for ; Thu, 16 Sep 2021 18:36:13 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id m11so8649761ioo.6 for ; Thu, 16 Sep 2021 09:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kMtcFNrrmbZ2O9Zrox2g/RU3M9VFqjdsq6r8cTfrw7E=; b=adEHUSo8/EP20C1Du4/9r2Xg9JjoZW0iHDOQWmTfLN0cUWhWrH1FNbCAMrJSLAS2oZ glf8XjT9fZb0pzMG/rf030/SqGyUksFF5wjTBjLp+05eFo1tUN0c1Ua6uElhWiAYAJgA ONNohi2RyRbbh0fhaq2aIbZRiE7EtCrxH7dZhN6z+i6z1Pj9p8saMU4aNIJCSiW+e1bD AYhRJXK2Ih6OFbKk9CGG4Q5+QrTPVFzHpz/+QYJcrMo1AcvEPuwmtaJrr+FjxZhpsZIH 92dg9NfoTHfZ4RZ0bZ4qULcvnRCEyNz6xhrFwf+OfZDrRmrq440TicQCA9qwwrnoYBa0 Mx9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kMtcFNrrmbZ2O9Zrox2g/RU3M9VFqjdsq6r8cTfrw7E=; b=tGLZV+AAxwkVf7aQGx5GGEhHWkU1aylzh1zKVLxvF/5UuZ/G8Z6mI8f0all+JsOzCO wPLW3N/mivGz3JY/hvKD+E5pGBD8fqtsiRb7Rc1+89MJg/S+IyK2D7nM/9ZdG8B6JBa7 2uPM3VVWFMQv/2omtL+c5f2/MMrWZI5K9xjOinHvSs+oHDmcSrnOhYmVhNo1V4Bi6nHe j58p6Y085ouCUsDKYwBLViqdZCTCbHa0/RM6MgyKRIzy+iHOGSPkWb9iWkdUEEGQC0Wt a741ziTlJhgVNUTg0OiEEcTO/fswjqGvaIi83Khs2pDcwbR6YakyeN/DMNMA6tnxEXL6 VSLQ== X-Gm-Message-State: AOAM5318mcpGAlqxEAE63TCDEuE0M4EqUm1Rm07fZo3sGbTyGrLV1/Dv RDzTSDD1vnsZSnBfIbnpP6UX50K+W/DVvsqUjeo= X-Google-Smtp-Source: ABdhPJwxh6/oSQtcxQD4Y3PcQoBOUvtUYnTJoEJP0kgBIjjnhC8EJbG2Z3LZ1FCzHSF3ArLlW1pBSCJpCRtyNtVfnAs= X-Received: by 2002:a05:6602:2219:: with SMTP id n25mr5031393ion.185.1631810172659; Thu, 16 Sep 2021 09:36:12 -0700 (PDT) MIME-Version: 1.0 References: <20210830135231.2610152-1-asekhar@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 16 Sep 2021 22:05:46 +0530 Message-ID: To: Ferruh Yigit Cc: Ashwin Sekhar T K , dpdk-dev , Jerin Jacob , Nithin Dabilpuram , Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 16, 2021 at 8:46 PM Ferruh Yigit wrote: > > On 8/30/2021 2:52 PM, Ashwin Sekhar T K wrote: > > NPA stack should be aligned to ROC cache line size. > > > > Can you please document the long versions of 'NPA' & 'ROC' abbreviations? > > Also for the patch title, since abbreviations needs to be uppercase, to automate > the check for these abbreviations, can you please add them to > './devtools/words-case.txt' in separate patch. Please do add NIX, NPC, CPT, SSO, LBK, MCAM too. > And can you add some more context on the reasoning of the change, why it should > be aligned to cache line? > What is the impact user/application sees if it is not aligned, and after aligned? > > Thanks, > ferruh > > > Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations") > > > > Signed-off-by: Ashwin Sekhar T K > > --- > > drivers/common/cnxk/roc_npa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c > > index d064d125c1..a0d2cc8f19 100644 > > --- a/drivers/common/cnxk/roc_npa.c > > +++ b/drivers/common/cnxk/roc_npa.c > > @@ -194,7 +194,7 @@ npa_stack_dma_alloc(struct npa_lf *lf, char *name, int pool_id, size_t size) > > { > > const char *mz_name = npa_stack_memzone_name(lf, pool_id, name); > > > > - return plt_memzone_reserve_cache_align(mz_name, size); > > + return plt_memzone_reserve_aligned(mz_name, size, 0, ROC_ALIGN); > > } > > > > static inline int > > >