From: Jerin Jacob <jerinjacobk@gmail.com>
To: psatheesh@marvell.com
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: add changes in base rule merging
Date: Thu, 22 Sep 2022 14:05:39 +0530 [thread overview]
Message-ID: <CALBAE1OUy4m+krWJ5fZaJHvJWc3As0kYnyqHcho1Zzs3fLAh2g@mail.gmail.com> (raw)
In-Reply-To: <20220922045909.479006-1-psatheesh@marvell.com>
On Thu, Sep 22, 2022 at 10:29 AM <psatheesh@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Added changes to base rule install mechanism.
> If action type is IPsec and multi channel is set,
> then base rule will not be merged.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> Reviewed-by: Satheesh Paul Antonysamy <psatheesh@marvell.com>
Please keep the consistent name.
Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: update base rule merging mechanism
Added changes to base rule install mechanism.
If action type is IPsec and multi channel is set,
then base rule will not be merged.
Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Reviewed-by: Satheesh Paul <psatheesh@marvell.com>
> ---
> drivers/common/cnxk/roc_npc_mcam.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
> index 4bea6719c5..a725cabc57 100644
> --- a/drivers/common/cnxk/roc_npc_mcam.c
> +++ b/drivers/common/cnxk/roc_npc_mcam.c
> @@ -720,10 +720,13 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc)
> uint64_t key_data[2] = {0ULL, 0ULL};
> uint64_t key_mask[2] = {0ULL, 0ULL};
> int key_len, bit = 0, index, rc = 0;
> + struct nix_inl_dev *inl_dev = NULL;
> int intf = pst->flow->nix_intf;
> struct mcam_entry *base_entry;
> + bool skip_base_rule = false;
> int off, idx, data_off = 0;
> uint8_t lid, mask, data;
> + struct idev_cfg *idev;
> uint16_t layer_info;
> uint64_t lt, flags;
>
> @@ -789,7 +792,14 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc)
> if (pst->set_ipv6ext_ltype_mask)
> npc_set_ipv6ext_ltype_mask(pst);
>
> - if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) {
> + idev = idev_get_cfg();
> + if (idev)
> + inl_dev = idev->nix_inl_dev;
> + if (inl_dev && inl_dev->is_multi_channel &&
> + (pst->flow->npc_action & NIX_RX_ACTIONOP_UCAST_IPSEC))
> + skip_base_rule = true;
> +
> + if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX && !skip_base_rule) {
> (void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox);
> rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp);
> if (rc) {
> --
> 2.35.3
>
prev parent reply other threads:[~2022-09-22 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 4:59 psatheesh
2022-09-22 8:35 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OUy4m+krWJ5fZaJHvJWc3As0kYnyqHcho1Zzs3fLAh2g@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=psatheesh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).