From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FB1C454AA; Thu, 20 Jun 2024 14:10:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F78142E58; Thu, 20 Jun 2024 14:10:08 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 75360402B1 for ; Thu, 20 Jun 2024 14:09:55 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-441567d352bso4252931cf.1 for ; Thu, 20 Jun 2024 05:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718885394; x=1719490194; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0hUS1faOknDML5AjOWhFKSXYvMetZF0duuk8O2JMvkM=; b=Lq3F7wBhMjWRfWr9NeDbliLJGklubmrnX0tG3p811pLFSsEKAZncC/xnjccZSuu/oF ZTSOin5U3ZQyQC8LhfRwTU5tKrHadJ54qNiux3G3PZmaAK0s7YnPeORllUSbxj40U6qW lX22ByNM3THyYYsyBBP5m+m1LW4sApR8WJKeU6ZU6su0NcO8wStonhJo02Ahszr+vhv/ etKlYBZcwfpAc0KWaTuqrbybf58qAL1EUF2N8eZTvnNk7WA4DoxPlQ1qci2txIwWcH6q ptOSiISNu/mxjd6mHhxLKzYSijEMk0tPwVcYydJtYEWkXPLsJbUZo6zOE55BQboPbjkG Wtvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718885394; x=1719490194; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0hUS1faOknDML5AjOWhFKSXYvMetZF0duuk8O2JMvkM=; b=CFj4ZegwgLxO/WVq7GAPwFnhXrYxeC3KEo//EaEUqZq/jZo7DlKNChC79EoeH+eSTu 0cCWcIfmyYqMtHIrTFWH+gUpwtqxghmASaLFUknnSRvNz0+4n+v8p2YraOWOh4V7DyjI EiDJ+lI9NJ1qqSKltzA4mPv5/Kdhituag6TSbreIR4CAU0hRW4vfX0gakN959Zikcrpd qJHXSWArGsCXGzyGU7kNtalr/sPpKDDLq+zVINhQjaZa2Driz2jPrERH4UflGH3Ez/Is dyHcnHMT51a7HDWx28S8kYxAvAjWLCNA4J7mDH+xaPAp573OwvWJ8BRU2K8kbz9ycwY8 kbbw== X-Gm-Message-State: AOJu0YxdD4EAENtakS8yGwWGUfllHmqjuhsjmRqtnd6DZf83kh5ity+m YQu0Xzq2ByFsKcaEHyMXFGPFQvh9osvOiWxZcbmZB04WY4nCsMysc+iuUyR+aom5c2zOpvqFIrl 1hPlgRUQlgkBbB0ozmM6y1sM/7bY= X-Google-Smtp-Source: AGHT+IGbmD3jo8kGcGWD1sJTbmfnEwivmLEMggN1Vi6QmnblCfXcNWpE4tq/fYV+DfboAC9i4/sFly7m5F0BowmetpI= X-Received: by 2002:a05:622a:40a:b0:43b:1546:f8a9 with SMTP id d75a77b69052e-444a7a4b961mr54673821cf.51.1718885394514; Thu, 20 Jun 2024 05:09:54 -0700 (PDT) MIME-Version: 1.0 References: <20240501194620.1199357-2-abdullah.sevincer@intel.com> <20240619210106.253239-1-abdullah.sevincer@intel.com> <20240619210106.253239-4-abdullah.sevincer@intel.com> In-Reply-To: <20240619210106.253239-4-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Thu, 20 Jun 2024 17:39:28 +0530 Message-ID: Subject: Re: [PATCH v5 3/5] event/dlb2: enhance DLB credit handling To: Abdullah Sevincer , "Richardson, Bruce" , Thomas Monjalon , David Marchand , Ferruh Yigit Cc: dev@dpdk.org, jerinj@marvell.com, mike.ximing.chen@intel.com, tirthendu.sarkar@intel.com, pravin.pathak@intel.com, shivani.doneria@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 20, 2024 at 2:31=E2=80=AFAM Abdullah Sevincer wrote: > > This commit improves DLB credit handling scenarios when > ports hold on to credits but can't release them due to insufficient > accumulation (less than 2 * credit quanta). > > Worker ports now release all accumulated credits when back-to-back > zero poll count reaches preset threshold. > > Producer ports release all accumulated credits if enqueue fails for a > consecutive number of retries. > > All newly introduced compilation flags are in the fastpath. > > Signed-off-by: Abdullah Sevincer > --- > drivers/event/dlb2/dlb2.c | 322 +++++++++++++++++++++++++++------ > drivers/event/dlb2/dlb2_priv.h | 1 + > drivers/event/dlb2/meson.build | 40 ++++ > meson_options.txt | 2 + + @Richardson, Bruce @Thomas Monjalon @David Marchand @Ferruh Yigit It is not allowed to add PMD specific build options in generic DPDK build options. Please check with Bruce. You may use scheme like https://patches.dpdk.org/project/dpdk/patch/20240522192139.3016-1-pbhagavat= ula@marvell.com/ or if we think, we need to standardize the PMD compilation options, then we can do that as well.