From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80BAEA0A02; Tue, 18 May 2021 16:05:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F02B4068E; Tue, 18 May 2021 16:05:36 +0200 (CEST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id 2198A40041 for ; Tue, 18 May 2021 16:05:35 +0200 (CEST) Received: by mail-il1-f182.google.com with SMTP id h11so9217309ili.9 for ; Tue, 18 May 2021 07:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIEOWAuFECTiFzJMnz4/NgsEAeJ/5vaQgsDkE/QQbnM=; b=S7eLz1qJiGc8UoF/VvPDAabB9nkkxIltevBRh3UjM1uKyNV48eIwNXV/MvuH3EbtRu J6cb0IWcakJsXPzVICJ8BTE9JNDJKRGcbTtNcMBoPmpuobnRxIygOEw60OSl8pE/laxY ftDbpQ/Uss5L6080hANH+W3lo9jIZpHxJWDquoKITd32BuurOdnisEJ+3ukkyg36/TtH AZSitaM6G+zSKvCEqH1h2KCvfuq1qqzVPOLiWb2e+QtED42cinx6nn/YizUUX6rJJDzX XVn5/QCmKJjVi9blOCEOkZ5CbBJBuJoilKZBsMijv88tu3SeswA4/8IazWkIN4x09PkV we8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIEOWAuFECTiFzJMnz4/NgsEAeJ/5vaQgsDkE/QQbnM=; b=X/oCYQGIUINJbOf+MIor/ktmfpVOnbR+FOXcfpaRo2KMtYwE1D8uA9MVKTveAYumRP VRJNQxv1kYt4axYuhdOaf/68/sWw2yRTq6x0+80fE9A3/lQM31VntQHFRZeYNX8ubRKt 1c46Sw+3V+55wEBttez09mH2lCMRcuzViMBzrZgumR9cXFAWjaYJj4YHzkIo3lMCiE5L 3Fy3TOfz8iUwNDcAhS8TIPdAE1rjzMkgEsZLQ4l4ti6S5P9Ib5G9TdZq5SS6NnMPgJqL uLsA6lLStpbZtTEkJuxwzelipXk/MsdlCk3C47uFMQsTYuSAByBjf3MRek3yU8redqEX 4tEw== X-Gm-Message-State: AOAM533PkTgkVVltLk9VMDOl8wlVMcGevoi5BjajXb8gsfaVWSCMNfVQ 0vRiuATVglr5M+4yiTsbp8gETjWIv8gkegZsK08= X-Google-Smtp-Source: ABdhPJzlT46x/+daEOlYZeA4S0AbRNEmYK2pU+ftWH8IFSXiKkLb3tSNzuPnngXuG8ohOPPIYtr85gy1Wh3VVFVH8RE= X-Received: by 2002:a05:6e02:2149:: with SMTP id d9mr4417780ilv.162.1621346734461; Tue, 18 May 2021 07:05:34 -0700 (PDT) MIME-Version: 1.0 References: <20210510061148.1674641-1-feifei.wang2@arm.com> In-Reply-To: From: Jerin Jacob Date: Tue, 18 May 2021 19:35:18 +0530 Message-ID: To: Feifei Wang Cc: "jerinj@marvell.com" , Ruifeng Wang , Honnappa Nagarahalli , "dev@dpdk.org" , nd Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] =?utf-8?b?5Zue5aSNOiBbUEFUQ0hdIGFwcC9ldmVudGRldjog?= =?utf-8?q?remove_unnecessary_barrier_for_order_test?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 18, 2021 at 2:57 PM Feifei Wang wrote: > > Hi, Jerin > > Sorry to disturb you. Would you please help me review this patch, thanks very much. In slowpath, I thought of having this barrier. But I agree that it can be removed. Since this is not bug. We will merge this patch in next release. > > > Best Regards > Feifei > > > -----Original Message----- > > From: Feifei Wang > > Sent: Monday, May 10, 2021 2:12 PM > > To: jerinj@marvell.com > > Cc: dev@dpdk.org; nd ; Feifei Wang > > ; Ruifeng Wang ; > > Honnappa Nagarahalli > > Subject: [PATCH] app/eventdev: remove unnecessary barrier for order test > > > > For "order_launch_lcores" function, wmb after that the main lcore updates > > the variable "t->err", which represents the end of the test signal, is > > unnecessary. Because after the main lcore updates this siginal variable, it will > > jump out of the launch function loop, and wait other lcores stop or return > > error in the main function(evt_main.c). > > During this time, there is no storing operation and thus no need for wmb. > > > > Signed-off-by: Feifei Wang > > Reviewed-by: Ruifeng Wang > > Reviewed-by: Honnappa Nagarahalli > > --- > > app/test-eventdev/test_order_common.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/app/test-eventdev/test_order_common.c b/app/test- > > eventdev/test_order_common.c > > index 04456d56db..d7760061ba 100644 > > --- a/app/test-eventdev/test_order_common.c > > +++ b/app/test-eventdev/test_order_common.c > > @@ -308,7 +308,6 @@ order_launch_lcores(struct evt_test *test, struct > > evt_options *opt, > > rte_event_dev_dump(opt->dev_id, stdout); > > evt_err("No schedules for seconds, > > deadlock"); > > t->err = true; > > - rte_smp_wmb(); > > break; > > } > > old_remaining = remaining; > > -- > > 2.25.1 > > >