From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 643B74415A; Wed, 5 Jun 2024 06:03:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC185402CE; Wed, 5 Jun 2024 06:03:02 +0200 (CEST) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by mails.dpdk.org (Postfix) with ESMTP id 02F5B402A9 for ; Wed, 5 Jun 2024 06:03:00 +0200 (CEST) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6f93c24d1f7so784350a34.1 for ; Tue, 04 Jun 2024 21:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717560180; x=1718164980; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sfO0vVfmoHQwycAXRhuYGnChV+6HD7fHLpihyaEK06I=; b=fPXaYzB0jfU+nIzPx+k8s8m8lB7Vcay0iyW7qmRoxNk58J0cdYzs7zPADJY6xuAYdJ YkWrUtpeund+/Bx6mzyIhcQZ6QDGenPZhvLYgbBmhfQaFGdvJHGHR0aZY70CG6aG9gbV ElG/7OYfq9kwP/Ynu9TLpLR07R6sxeuL+VHPmfin0ycVOi94FKtoM8cepSt078z5+EGD gxpgmruEPkOx4GIBATM1qKpMnwcVpK1JHWh96b6nNL2O5c8REIOsiovxXXOoihvYzs2o DlthfnAPV1Bb0ZTzxQW9kKfkxaiqLV65uP4QDoVQ9sVe5/trecRSxmIGw8WzwUKXU0Q+ GQFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717560180; x=1718164980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sfO0vVfmoHQwycAXRhuYGnChV+6HD7fHLpihyaEK06I=; b=qXtm0cS3VV24skGd1la9HFOycmHqTypY4K3kd+i8Q8hhvpd8oFCFeHA25StUNqeOJc ZprcD/9achZOcPfz2J+sBQGwm/YW6miPSXkOYpOsD2ECczWMb6tFALR6UbhugEW64m+m Vk9xtZ28GPnabChcen2xnJKf5R3INngD8/qOiaw0Xho0yEGM8m7dsELdSkvKKQ4lUZoL j2t07BFH33hn6SLsYuEO7OoJVL1YDlFr5fyl5OL4vWmefHdjAXogIL5PWvqanbrVTEMs 0RcMbbQUxFCa7MYo1dJI8wT7Plxfhu39ZDS7iuXYbbKP7jI3qch+Y67g+hyn/P+7oZWA aG0g== X-Forwarded-Encrypted: i=1; AJvYcCW//M7UUVCc0AAtPNzvgSGASd12lTXrlygoMyw8YO4GSo/HWoP1ZgW5L5LZi5mbvmluC/Jj+BpEhhkIrI4= X-Gm-Message-State: AOJu0Yyrp2mbLaBH4/DS2YnxvOKwB3LZYlSKfYPDtSJQt5wLMPUGsbXH 2TUbsZpQUYywv1tSQyGq+ZxeMuEBO++RvDDbVc7l2vmrqAT3p0UFGPW5rel7TCxTNM11usnLTGB tJHXTVUMpT1W5aHrfYqhTn+6Pf9U= X-Google-Smtp-Source: AGHT+IFoxS7Nspn4tmFJpu+v7AEro43TeLKRiial6wmon1AyMKjyozCBD3miVjnCgGJSZNUj3/f27XrrOS5ADXe7EYI= X-Received: by 2002:a9d:6e09:0:b0:6f0:e470:1906 with SMTP id 46e09a7af769-6f94343f12cmr1763324a34.10.1717560179920; Tue, 04 Jun 2024 21:02:59 -0700 (PDT) MIME-Version: 1.0 References: <20240501194620.1199357-1-abdullah.sevincer@intel.com> <20240501194620.1199357-4-abdullah.sevincer@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 5 Jun 2024 09:32:33 +0530 Message-ID: Subject: Re: [PATCH v4 3/3] event/dlb2: enhance DLB credit handling To: "Sevincer, Abdullah" Cc: "Richardson, Bruce" , "dev@dpdk.org" , "jerinj@marvell.com" , "Chen, Mike Ximing" , "Sarkar, Tirthendu" , "Pathak, Pravin" , "Doneria, Shivani" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 4, 2024 at 11:52=E2=80=AFPM Sevincer, Abdullah wrote: > > > > >+This new patch is full of compilation flags clutter, can you make it ru= ntime? > Thanks for the reviews Jerin, we can make it run time but it will cost mo= re cycles and new APIs in the PMD to set those run time params. The reason = we do it this way is to save cycles also not to make cli params longer. OK. At least, slowpath code you can remove ifdef and use only in fastpath. > > >+Adding @Richardson, Bruce @Thomas Monjalon to comment on this, I > >+am not sure driver specific > >+meson_options.txt is a good path? >