From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 235D6A00BE; Thu, 17 Feb 2022 14:36:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFABF40150; Thu, 17 Feb 2022 14:36:35 +0100 (CET) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id F018040042 for ; Thu, 17 Feb 2022 14:36:33 +0100 (CET) Received: by mail-io1-f54.google.com with SMTP id e79so3618329iof.13 for ; Thu, 17 Feb 2022 05:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9YQVBz5y4uJM/zXF0p48M5xmGxrIW5O9aXgkgyQB3mo=; b=oQzoGhMjGV0XiZ5Au+1MFYcHFYTVn5Ghp2pJe0ztMWjY9p+C6K/VEuPhn9wTNYbws3 5rLoaMdVYyecTXI2Pya0OTeYTpGQK9vtnu7N9HXgJksQER50Qe6Mf/6AxdXL6s8O10nc p/5szYoastahw9txst2qpiCINOkPUE+zlYmuAOnI5J07w643Wun7CPJ1XYWxjnJWidgh Dcrhq6PLtNF3FNHjlvdtkRwvO2M/j08fgVZi4bw4jJgZSYuKVlKiHvXyj5YQxQ45e/RW zqGwMiTnXG1Ry/uWxK5Igj3k6feDJG137tTsS+HZUvFsOc7UqUiMuCtrcC+5y++JwVNN 1PFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9YQVBz5y4uJM/zXF0p48M5xmGxrIW5O9aXgkgyQB3mo=; b=XbdNt56S18auarQB8CmwcdBnUS60YG8bj2QbsH2D8ohUWg1VE/CjVxbKiD+rAgff9F LfHsdUkoEJRovelAfsM56QZQ3BPhaUV2B8p1py1n8Dtv7gYTuS52mj/1rjp0SgokZ/uI ekiAkAcbptpcQehFd0d0D9RLN0O+cddEkz63b+gpBg4X+8EbjQ+732OnTWaMm3dr9C94 f96U5aqB23QK9uyow3VRb/6gsc06vGL2o9NMwF5oQDVFIndPT5PXMe4LIDjJA9+AQQMQ nY7BnaAkRUZVRuSXfanNNAl7pDEEXm+vurZtW3BmMYTH8SFB7nZljg1obnN8PIfVj5wq ODzQ== X-Gm-Message-State: AOAM5312xJUJkYF07TqcX7NZ0pGF+B+nYupqSbjkcWbv4w7M9UCRmcaV BOA9j89KPhGyvsCnhuyeJwpes7UnvbClGTN7Lfo= X-Google-Smtp-Source: ABdhPJw6lB9vHIF9pU/jklrLzVji/6JPx2zDUfDjlCD/HtzyPseYHZYPa2zhU3dG+yUcZeogXeg1n818siM8iBL/hoY= X-Received: by 2002:a6b:ce01:0:b0:610:8f2:3b7 with SMTP id p1-20020a6bce01000000b0061008f203b7mr1941660iob.25.1645104991125; Thu, 17 Feb 2022 05:36:31 -0800 (PST) MIME-Version: 1.0 References: <20220207072932.22409-1-ndabilpuram@marvell.com> <20220207072932.22409-11-ndabilpuram@marvell.com> In-Reply-To: <20220207072932.22409-11-ndabilpuram@marvell.com> From: Jerin Jacob Date: Thu, 17 Feb 2022 19:06:05 +0530 Message-ID: Subject: Re: [PATCH 11/20] common/cnxk: removed tracking of mark actions To: Nithin Dabilpuram Cc: Jerin Jacob , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Ray Kinsella , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram wrote: > > From: Satha Rao Subject change removed to remove > > Removed roc npc apis which tracks addition and deletion of NPC and APIs > mark actions. Tell why it is removed. > > Signed-off-by: Satha Rao > --- > drivers/common/cnxk/roc_npc.c | 21 --------------------- > drivers/common/cnxk/roc_npc.h | 3 --- > drivers/common/cnxk/roc_npc_priv.h | 1 - > drivers/common/cnxk/version.map | 2 -- > 4 files changed, 27 deletions(-) > > diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c > index e3961bf..d2ebe61 100644 > --- a/drivers/common/cnxk/roc_npc.c > +++ b/drivers/common/cnxk/roc_npc.c > @@ -166,8 +166,6 @@ roc_npc_init(struct roc_npc *roc_npc) > roc_npc->kex_capability = npc_get_kex_capability(npc); > roc_npc->rx_parse_nibble = npc->keyx_supp_nmask[NPC_MCAM_RX]; > > - npc->mark_actions = 0; > - > npc->mcam_entries = npc_mcam_tot_entries() >> npc->keyw[NPC_MCAM_RX]; > > /* Free, free_rev, live and live_rev entries */ > @@ -323,13 +321,11 @@ npc_parse_actions(struct roc_npc *roc_npc, const struct roc_npc_attr *attr, > } > mark = act_mark->id + 1; > req_act |= ROC_NPC_ACTION_TYPE_MARK; > - npc->mark_actions += 1; > break; > > case ROC_NPC_ACTION_TYPE_FLAG: > mark = NPC_FLOW_FLAG_VAL; > req_act |= ROC_NPC_ACTION_TYPE_FLAG; > - npc->mark_actions += 1; > break; > > case ROC_NPC_ACTION_TYPE_COUNT: > @@ -812,23 +808,6 @@ npc_rss_action_program(struct roc_npc *roc_npc, > return 0; > } > > -int > -roc_npc_mark_actions_get(struct roc_npc *roc_npc) > -{ > - struct npc *npc = roc_npc_to_npc_priv(roc_npc); > - > - return npc->mark_actions; > -} > - > -int > -roc_npc_mark_actions_sub_return(struct roc_npc *roc_npc, uint32_t count) > -{ > - struct npc *npc = roc_npc_to_npc_priv(roc_npc); > - > - npc->mark_actions -= count; > - return npc->mark_actions; > -} > - > static int > npc_vtag_cfg_delete(struct roc_npc *roc_npc, struct roc_npc_flow *flow) > { > diff --git a/drivers/common/cnxk/roc_npc.h b/drivers/common/cnxk/roc_npc.h > index b836e26..6dcdd29 100644 > --- a/drivers/common/cnxk/roc_npc.h > +++ b/drivers/common/cnxk/roc_npc.h > @@ -337,9 +337,6 @@ int __roc_api roc_npc_mcam_free_all_resources(struct roc_npc *roc_npc); > void __roc_api roc_npc_flow_dump(FILE *file, struct roc_npc *roc_npc); > void __roc_api roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc, > struct roc_npc_flow *mcam); > -int __roc_api roc_npc_mark_actions_get(struct roc_npc *roc_npc); > -int __roc_api roc_npc_mark_actions_sub_return(struct roc_npc *roc_npc, > - uint32_t count); > int __roc_api roc_npc_vtag_actions_get(struct roc_npc *roc_npc); > int __roc_api roc_npc_vtag_actions_sub_return(struct roc_npc *roc_npc, > uint32_t count); > diff --git a/drivers/common/cnxk/roc_npc_priv.h b/drivers/common/cnxk/roc_npc_priv.h > index afd11ad..a04f621 100644 > --- a/drivers/common/cnxk/roc_npc_priv.h > +++ b/drivers/common/cnxk/roc_npc_priv.h > @@ -380,7 +380,6 @@ struct npc { > uint16_t flow_prealloc_size; /* Pre allocated mcam size */ > uint16_t flow_max_priority; /* Max priority for flow */ > uint16_t switch_header_type; /* Supported switch header type */ > - uint32_t mark_actions; /* Number of mark actions */ > uint32_t vtag_strip_actions; /* vtag insert/strip actions */ > uint16_t pf_func; /* pf_func of device */ > npc_dxcfg_t prx_dxcfg; /* intf, lid, lt, extract */ > diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map > index 7a8aff1..0f990d3 100644 > --- a/drivers/common/cnxk/version.map > +++ b/drivers/common/cnxk/version.map > @@ -305,8 +305,6 @@ INTERNAL { > roc_npc_flow_parse; > roc_npc_get_low_priority_mcam; > roc_npc_init; > - roc_npc_mark_actions_get; > - roc_npc_mark_actions_sub_return; > roc_npc_vtag_actions_get; > roc_npc_vtag_actions_sub_return; > roc_npc_mcam_alloc_entries; > -- > 2.8.4 >