From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B971A0543; Mon, 13 Jun 2022 09:20:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BF7A40223; Mon, 13 Jun 2022 09:20:11 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id F22D140150 for ; Mon, 13 Jun 2022 09:20:09 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id x16so3295664qtw.12 for ; Mon, 13 Jun 2022 00:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lc8E5b1IoLLoaLqXQUXxjEC0nJTDZnIQ9ivE8Hkg1hE=; b=QQWKc6IjFOsHUFGqL5PiunidmfEglp946RXUY+ZzkrWjzWL2OfbWUETwdaTIjewSXT r9VHZXHGMpdu1VarFZqV8Meqerr6Syms7a9Jr0UDykGpOeDgSmiU17ZsQUuTPRhXOenH IqgJ78uTX84aUWTUyNJ0RfMkS6hwvH2hpJhnwyu0Pb102jgEPVtzoBIa7jo4szKqbaXu C/vbZcPAgJnMHTf/XP7gHegbOzJm62WmBAssEBLOj0yzbAbWnQxy2PMWsMp1ynT8KNNJ RRJoC/OwKh01Ik322/bA6T1UojCYCkZNIm84BinomYo0rSnYSVsZXJnMYrjvd6Cx1BSj sR4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lc8E5b1IoLLoaLqXQUXxjEC0nJTDZnIQ9ivE8Hkg1hE=; b=qx5XBWhWEGK89fmnazApDYR3VRt3eHLQMR+K+rEGEc1ZWSfYYeXQFG61PEv46Yfd2V By+cnCAfjQ6l0zIrjI7qGNqktXtb4iFbiQErPRKzOj80N7iDhiUNo1A90DYq6292L1qt EieLzhmax386+NGMi9PfdSM4rbEE5O9FK73P8dO40uN6UpCosPyvWsmySH5JpCxlKPnS UdQow1tB0gYztPsIrEtyrrEQAwddqXcB4gmHesskCWMfKnWTh/sIiKyd58OS5xzoYteK lc6oKr6s5TH1wwyaruSKQB/Xo/OYp758rU5gpmDaWFBBE+nyc3atL4uLLKl47ArrQkqE IPlQ== X-Gm-Message-State: AOAM5312VRXEZ6uZCOqMiU5g+HWcLdD+YFTXA1eiW/vmugJBZ8U/LqC3 Uc/3IcxcBPRpt7lwnF2xYSmJI6oITsieBNk03Ag= X-Google-Smtp-Source: ABdhPJwK+TJw8fr2WICgg6R4E4psLTGVt7s4M8pofvXUwyn4r/Q8KZGFGMbdIrcE1gbA3KmIls/jXWz2M0YSHZzz04g= X-Received: by 2002:a05:622a:8d:b0:305:1c58:a837 with SMTP id o13-20020a05622a008d00b003051c58a837mr11409105qtw.410.1655104809279; Mon, 13 Jun 2022 00:20:09 -0700 (PDT) MIME-Version: 1.0 References: <764fb382f2934807b8e6e0ba15c37a606a98d9d2.1654232597.git.sthotton@marvell.com> In-Reply-To: <764fb382f2934807b8e6e0ba15c37a606a98d9d2.1654232597.git.sthotton@marvell.com> From: Jerin Jacob Date: Mon, 13 Jun 2022 12:49:43 +0530 Message-ID: Subject: Re: [PATCH] common/cnxk: alloc link map array if HWS is available To: Shijith Thotton Cc: Jerin Jacob , dpdk-dev , Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 3, 2022 at 10:41 AM Shijith Thotton wrote: > > Link map array is required only if work slots are available. > > Signed-off-by: Shijith Thotton > --- > drivers/common/cnxk/roc_sso.c | 45 +++++++++++++++++++---------------- Applied to dpdk-next-net-eventdev/for-main. Thanks > 1 file changed, 25 insertions(+), 20 deletions(-) > > diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c > index 358d37a9f2..34b9896d5f 100644 > --- a/drivers/common/cnxk/roc_sso.c > +++ b/drivers/common/cnxk/roc_sso.c > @@ -784,29 +784,34 @@ roc_sso_dev_init(struct roc_sso *roc_sso) > } > rc = -ENOMEM; > > - sso->link_map = > - plt_zmalloc(sizeof(struct plt_bitmap *) * roc_sso->max_hws, 0); > - if (sso->link_map == NULL) { > - plt_err("Failed to allocate memory for link_map array"); > - goto rsrc_fail; > - } > + if (roc_sso->max_hws) { > + sso->link_map = plt_zmalloc( > + sizeof(struct plt_bitmap *) * roc_sso->max_hws, 0); > + if (sso->link_map == NULL) { > + plt_err("Failed to allocate memory for link_map array"); > + goto rsrc_fail; > + } > > - link_map_sz = plt_bitmap_get_memory_footprint(roc_sso->max_hwgrp); > - sso->link_map_mem = plt_zmalloc(link_map_sz * roc_sso->max_hws, 0); > - if (sso->link_map_mem == NULL) { > - plt_err("Failed to get link_map memory"); > - goto rsrc_fail; > - } > + link_map_sz = > + plt_bitmap_get_memory_footprint(roc_sso->max_hwgrp); > + sso->link_map_mem = > + plt_zmalloc(link_map_sz * roc_sso->max_hws, 0); > + if (sso->link_map_mem == NULL) { > + plt_err("Failed to get link_map memory"); > + goto rsrc_fail; > + } > > - link_mem = sso->link_map_mem; > - for (i = 0; i < roc_sso->max_hws; i++) { > - sso->link_map[i] = plt_bitmap_init(roc_sso->max_hwgrp, link_mem, > - link_map_sz); > - if (sso->link_map[i] == NULL) { > - plt_err("Failed to allocate link map"); > - goto link_mem_free; > + link_mem = sso->link_map_mem; > + > + for (i = 0; i < roc_sso->max_hws; i++) { > + sso->link_map[i] = plt_bitmap_init( > + roc_sso->max_hwgrp, link_mem, link_map_sz); > + if (sso->link_map[i] == NULL) { > + plt_err("Failed to allocate link map"); > + goto link_mem_free; > + } > + link_mem = PLT_PTR_ADD(link_mem, link_map_sz); > } > - link_mem = PLT_PTR_ADD(link_mem, link_map_sz); > } > idev_sso_pffunc_set(sso->dev.pf_func); > idev_sso_set(roc_sso); > -- > 2.25.1 >