From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B707141BA1; Wed, 1 Feb 2023 19:37:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52C5642B8E; Wed, 1 Feb 2023 19:37:53 +0100 (CET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mails.dpdk.org (Postfix) with ESMTP id 615454067C for ; Wed, 1 Feb 2023 19:37:51 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id y8so20734511vsq.0 for ; Wed, 01 Feb 2023 10:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qu0RLfKWgo6B7HY4YoydLesW7NqtmABHG6HKvnFofO8=; b=Q5KonxyLlTRliv74df3+z3Zbjouwgw0cwN4/TNSMXneCpvlP0SgH7rGTMFc8srK3+M Dgt5BadBwHZ4MxWbLG6GyF/P+MlEOELLFvvRg1ekruLs/aV0x4k1YGPf87E/CBgudqA1 xH4pQgV5E7Yu+yJX3FfOmnSwn/2oKpeJKWyxexq/qYudJYq0FvRH+8k70wDGvApDBJZL j2QLOHBnVehQkaMdCwK+SqHOz4gNdhGqYZMoECRWG8jZOiI6sTCoyoydn2+BPDEz8+rB 1wDiovBAi0B1LvhcraNwJD06DYK2VPaVwk33fkJVGs8VjmOkTDBxk/Fma7UYDOij43l8 efEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qu0RLfKWgo6B7HY4YoydLesW7NqtmABHG6HKvnFofO8=; b=ueis9UeIsKItUUgshMi7PCQDX+RFSahHMBLFk75XZDbeP7BCSznICUZuUx3hSBaYqq kvWOJR5h7eebbBoTiHBnzOoCozw0tVl9SxPl5MYtDytPkV282JChM6bh7/sH08k8EzIE qDFMV1j34sf8MPmGeuAcFnRQD0WGv1h28fwsA4WPYVs0+eHbUuzwK+eQtPjAkOv6Xb1f IL1igAAMhsa6qtpSw4AVAcBRNBnpLII/vi3Jtj8GGfNUEx4U5E5Gz/lXFGEQwXNCf832 8lXjtATe6LDPUjoNLVASeX+7B4LnvfW/gduytcnUcQJJ1hNnVE8uibtWr7Vvzq2y66Zj 3aVQ== X-Gm-Message-State: AO0yUKWm/OzwP4uU/dHnj861wjlXk4EsFsnPOvzYdNqrcAeYZOMupXod G6l0zSZJ+SMJK0GnZMmFMZQkvRI/xKSGO/K9g+8= X-Google-Smtp-Source: AK7set9cbE6U/KuM17NWd9qlQgatiwXQ9/jreJtsSa+wY+aZbinVQaiezofJGFJJBVVPyjRcXqFC18i0tIXM2T/TkIs= X-Received: by 2002:a05:6102:3005:b0:3eb:2024:bda9 with SMTP id s5-20020a056102300500b003eb2024bda9mr625132vsa.45.1675276670593; Wed, 01 Feb 2023 10:37:50 -0800 (PST) MIME-Version: 1.0 References: <20221222013904.692922-1-rkudurumalla@marvell.com> <20221221190140.399996e0@hermes.local> In-Reply-To: From: Jerin Jacob Date: Thu, 2 Feb 2023 00:07:24 +0530 Message-ID: Subject: Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer To: Ori Kam Cc: Rakesh Kudurumalla , Stephen Hemminger , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "NBU-Contact-Adrien Mazarguil (EXTERNAL)" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 1, 2023 at 11:19 PM Ori Kam wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Friday, 27 January 2023 8:23 > > To: Ori Kam > > Cc: Rakesh Kudurumalla ; Stephen Hemminger > > ; NBU-Contact-Thomas Monjalon > > (EXTERNAL) ; Ferruh Yigit ; > > Andrew Rybchenko ; dev@dpdk.org; > > NBU-Contact-Adrien Mazarguil (EXTERNAL) > > Subject: Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer > > > > On Thu, Jan 26, 2023 at 8:43 PM Ori Kam wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Rakesh Kudurumalla > > > > Sent: Wednesday, 18 January 2023 10:10 > > > > > > > > > > > > > -----Original Message----- > > > > > From: Rakesh Kudurumalla > > > > > Sent: Tuesday, January 10, 2023 12:12 PM > > > > > To: Ori Kam ; Jerin Jacob ; > > > > > Stephen Hemminger > > > > > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; > > > > > Ferruh Yigit ; Andrew Rybchenko > > > > > ; dev@dpdk.org; NBU-Contact- > > Adrien > > > > > Mazarguil (EXTERNAL) > > > > > Subject: RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Ori Kam > > > > > > Sent: Monday, December 26, 2022 10:30 PM > > > > > > To: Jerin Jacob ; Stephen Hemminger > > > > > > > > > > > > Cc: Rakesh Kudurumalla ; NBU-Contact- > > > > > Thomas > > > > > > Monjalon (EXTERNAL) ; Ferruh Yigit > > > > > > ; Andrew Rybchenko > > > > > > ; dev@dpdk.org; NBU-Contact- > > > > Adrien > > > > > > Mazarguil (EXTERNAL) > > > > > > Subject: [EXT] RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress > > > > > > policer > > > > > > > > > > > > External Email > > > > > > > > > > > > ---------------------------------------------------------------------- > > > > > > Hi All, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Jerin Jacob > > > > > > > Sent: Thursday, 22 December 2022 7:27 > > > > > > > > > > > > > > On Thu, Dec 22, 2022 at 8:32 AM Stephen Hemminger > > > > > > > wrote: > > > > > > > > > > > > > > > > On Thu, 22 Dec 2022 07:09:02 +0530 Rakesh Kudurumalla > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Dropping of packets based on RED can be skipped with meter > > > > > > > > > action, when RED is configured using > > > > > > > > > rte_eth_cman_config_set() > > > > > > > > > > > > > > > > > > Signed-off-by: Rakesh Kudurumalla > > > > > > > > > > > > > > > > > > Should this be more general and apply to all congestion > > management > > > > > > > > options. Assuming the hardware can do something better than > > RED. > > > > > > > > > > > > > > Yes. We can use "enum rte_cman_mode mode" in the descriptor to > > > > > > > future- proof. > > > > > > > > > > > > I'm missing the idea of this new action, I understand that is related > > > > > > to Jerin congestion patches. > > > > > > But I fail to see why we need it? Is it to mark some metadata that > > > > > > will have some effect on the congestion result? (I assume the system > > > > > > is implemented in the HW) > > > > > > > > > > Yes. It is implemented in HW. Congestion management is applied on > > > > ethdev > > > > > Rx queue using rte_eth_cman_config() API. Once it is configured, it > > applies > > > > to > > > > > all the packets that steer towards that particular ethdev Rx queue. This > > > > > feature help to skip the congestion management processing based on > > the > > > > > packet color identified by the rte_flow meter object. For example, If > > one > > > > Rx > > > > > queue configured as RED congestion and application wants to bypass > > the > > > > > RED congestion processing for all GREEN color packet can be expressed > > > > > though this API proposal. > > > > > > > > Hi Ori Kam, > > > > > > > > Let me know if above information would give clear idea on skip RED > > action > > > > > > I think so, to put it in my own words, when setting this the selected packet > > is treated as > > > green packet? > > > > > > If so, can we use the meter_color field? If you want the packet to be green > > just set the > > > field to green? > > > > It is already there in one form. See following in existing header file. > > > > /** > > * Meter policy > > */ > > struct rte_mtr_meter_policy_params { > > /** > > * Policy action list per color. > > * actions[i] potentially represents a chain of rte_flow actions > > * terminated by the END action, exactly as specified by the rte_flow > > * API for the flow definition, and not just a single action. > > */ > > const struct rte_flow_action *actions[RTE_COLORS]; > > }; > > > > > Sorry I'm not sure I understand, > I know we can have colors in the meter, but this feature is about > somehow telling the rxq to skip the red packet and treat it as green right? Yes. When rte_mtr_meter_policy_params::actions[RTE_COLOR_GREEN] set as RTE_FLOW_ACTION_TYPE_SKIP_CMAN for the given meter object, it is indicating to SKIP the CMAN configuration applied to the rxq on the downstream path if meter assigns a GREEN color. (RQ section is as usual as existing path, either via ethdev RSS or rte_flow RSS action or rte_fow Queue action). > > > > > > > Best, > > > Ori > > >