From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22302A034C; Tue, 18 Aug 2020 07:07:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F10D31C031; Tue, 18 Aug 2020 07:07:39 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id D706F1C020 for ; Tue, 18 Aug 2020 07:07:37 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id t15so20032123iob.3 for ; Mon, 17 Aug 2020 22:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AB0svlUkv37I0jZ38BA9YonqkZmq8MWOGaUsfVdvf+c=; b=RaoNev5DVT4TPIGlQLr3gewjt1RsWusvXtN6RYPtwkbeiuvORX2oN1IWbMfinQwNHn SMvY8CRpARm0jrURGpiFckfVEUSlVFOKybVLIvyULIz/b71UonQ6BfjSBEX1IjDmY7WC htBBQlNI999h5Y9vZN5G0L5l5VHtNDXSs2SBjocO/6t3l4maN8UTRPC3Va8ixNy1ZmRJ HzPsOO/087AdaIs7DGrKou6PXm6qPdVqeIdOUrt57FPKcn2H8hZXJ+NrD1Am2NivB3A9 lpWkxyrlktFRid6AsVxXwhxlvBuUJLJqqZc9UnJOOPrRweg5GAsHPcahijJqG2elP5nE +DFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AB0svlUkv37I0jZ38BA9YonqkZmq8MWOGaUsfVdvf+c=; b=p17bv4qIcx0JBsJR+YlHdxW3pZpaUTvz7pmLHBu+1YyaM0s3Y4CW6LjrZgU8onzHgj jdgKfD/9mhYPRXRNqhGJhI3TbPPVisaLp6mnuG/mv1SI3/hhGLSMc1oJ0Hjy1CIdYBz+ 75NmTMTDDQED2LKn3wH0Umo4F+Jc1hyLktZpTCKJ//gKPACwnajNMBvmv4Db46qhBN5J OmbTs93Pb7B2v5eIfMhp4paoDYRay0DiNwMn0/4MkVyY6jar6ZHP6bxMs62gmSs3Bifx W5j7wEzijBmj2K0CMo6Uo9Hndkyfsaw1+tIvHenZ3t3Z5hlRR79jmkLqN9rTtWsV+9AE nVFQ== X-Gm-Message-State: AOAM531rVR9Cva97+d2RaS6HzvaOEkm0/fdUZXdKdJgjWf14qltRl4JM 2IwOqCcDe9BMORvDICOts6ufbfwZWBDSnVk7Zrk= X-Google-Smtp-Source: ABdhPJzLgyZJm3AVMbzESjAoQAd3Saq+E9guh8aUE9ddp3FFDa0kbCXAQXnYtiEXLgyZsYKXeZRI8rD9/vkzoSa4x90= X-Received: by 2002:a02:e4a:: with SMTP id 71mr17450122jae.133.1597727257208; Mon, 17 Aug 2020 22:07:37 -0700 (PDT) MIME-Version: 1.0 References: <20200817124703.58157-1-huwei013@chinasoftinc.com> <20200818024355.23364-1-huwei013@chinasoftinc.com> In-Reply-To: From: Jerin Jacob Date: Tue, 18 Aug 2020 10:37:21 +0530 Message-ID: To: Ruifeng Wang Cc: "Wei Hu (Xavier)" , "dev@dpdk.org" , "xavier.huwei@huawei.com" , nd , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] eal/arm64: update CPU flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 18, 2020 at 9:11 AM Ruifeng Wang wrote: > > Hi, > > > -----Original Message----- > > From: Wei Hu (Xavier) > > Sent: Tuesday, August 18, 2020 10:44 AM > > To: dev@dpdk.org > > Cc: xavier.huwei@huawei.com; nd ; Honnappa Nagarahalli > > ; Ruifeng Wang > > ; jerinjacobk@gmail.com > > Subject: [PATCH v3] eal/arm64: update CPU flags > > > > From: "Wei Hu (Xavier)" > > > > SVE is the next-generation SIMD extension of the ARMv8-A AArch64 > > instruction set. > > The related marco definition can be found in linux kernel: > > arch/arm64/include/uapi/asm/hwcap.h > > > > This patch updates cpu SVE flags on ARM64 platform, such as SVE, etc. Suggested rewording: ARM64 Linux kernel updated the CPU flags using the HWCAP scheme. This patch incorporates those changes to the eal library. > > > > Signed-off-by: Chengwen Feng > > Signed-off-by: Wei Hu (Xavier) > > --- > > v2 -> v3: > > 1. Change commit log. > > 2. Add HWCAP2_FLAGM2 and HWCAP2_FRINT to > > rte_cpu_feature_table[]. > > 3. Add the flags for newly added items into enum rte_cpu_flag_t. > > v1 -> v2: > > Adds more sve-related definition to rte_cpu_feature_table, > > sunch as SVE2, etc. > > --- > > lib/librte_eal/arm/include/rte_cpuflags_64.h | 13 +++++++++++++ > > lib/librte_eal/arm/rte_cpuflags.c | 13 +++++++++++++ > > 2 files changed, 26 insertions(+) > > > How about updating test_cpuflags() too to cover these new flags? +1 . Wei, Please update the test_cpuflags() functions for new flags.