From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8210AA0577; Sun, 5 Apr 2020 15:06:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AB332C5E; Sun, 5 Apr 2020 15:06:22 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 029C5276C; Sun, 5 Apr 2020 15:06:20 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id t11so12087778ils.1; Sun, 05 Apr 2020 06:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=73eSPkoKhsSAUFksehKiYt7xC03TX+39aka0DimUIUY=; b=YU4EF9WHmAxkMWOr07NaG2QwUXWivP7dmHLYj8/N0kv8/qvZQOqOyAOKtWmBV4sGRI nHAIeaYOMsPl811qsAoGlZPPqGTkBVxRq7ZjptwNvZ0e74Eyre7W7nGYka9UJOs3sMna HFiS/nz5pvKsfYZn57Wh4m2lCiW0ZEyopBTKBvM2J1YqjSop7aG/NJvUQDIKANtOuKy1 mO6hD9dH6PaBt2ikdO176IR7sAlYLawq2sOo85w4FNPFZhTsGmSpOoC1c/Mxvj9b1T4a qfE21t5zBIR084BEkzuoYL3uXQi94kkLdloNsJrXsYG/nXxnsnt4/M2eYg7bSsBfKhy8 lOxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=73eSPkoKhsSAUFksehKiYt7xC03TX+39aka0DimUIUY=; b=q6Em2b/2B2Rfis5pxndQe7xdIVvLwMgxEh/am89UUoigR+AYMSV9KfzKoHW5wMo5CM DxYrg4Vy4i/X4x5irDCBChQryFjfLIqb9suLr+8SoUXSio6N33fkOqxBubzVCqyZ8JsJ wfuLSrC5JUoQ6883KC98mfoH+sDIIEfuvbT1m5Bpfqe40O45bk1d6dZJ11dK4UBlnDg6 /85rucJeBs0kAjWJRZVyI/zzA/OqOy7rJsoonAmKT8RyAixGWBE/Sy9X+4yMjWqPIIql 6xt72BXd/eKq5MXAovFvWeN+zs7rG9T061okNLMtRf8VCXv+2Zz+tjFF01gyMR2gCjOo W/IQ== X-Gm-Message-State: AGi0PuYBZ0mYkJUd1yrR/QPEkX+K/ofdBg97VoPoH3YezpkIduooeABr N2JFAeVJT9lacWJs+HB64CJiL/VHeOg1wnfiYLM= X-Google-Smtp-Source: APiQypLYSuX0C0oxOExAY9sv8AiUDSYXSQt90K8bsOfWIrXH295q/2G9Hzsq9HWmHx2wQyFaKJWXVTTIQHjXbcbOHio= X-Received: by 2002:a92:48cb:: with SMTP id j72mr17048452ilg.162.1586091980128; Sun, 05 Apr 2020 06:06:20 -0700 (PDT) MIME-Version: 1.0 References: <20200303012913.13664-1-sodey@rbbn.com> In-Reply-To: From: Jerin Jacob Date: Sun, 5 Apr 2020 18:36:04 +0530 Message-ID: To: "Dey, Souvik" Cc: Rasesh Mody , Shahed Shaikh , Jerin Jacob Kollanukkaran , "ferruh.yigit@intel.com" , "thomas@monjalon.net" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 5, 2020 at 7:21 PM Dey, Souvik wrote: > > Thanks will do that. And will also try to remove the trailer in the patches. Thanks for pointing it out. > > From: dev On Behalf Of Rasesh Mody > Sent: Tuesday, March 3, 2020 6:01 PM > To: Dey, Souvik ; Shahed Shaikh ; Jerin Jacob Kollanukkaran ; ferruh.yigit@intel.com; thomas@monjalon.net > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case 1) Please change vlan to VLAN 2) Fix the following checkpatch issue. Probably move the new code to a new function to get enough space. [master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh ### net/bnx2x: handle guest VLAN for SR-IOV case WARNING:BAD_SIGN_OFF: email address '"Dey Souvik" ' might be better as 'Dey Souvik ' #16: Signed-off-by: "Dey Souvik" WARNING:LONG_LINE_COMMENT: line over 80 characters #27: FILE: drivers/net/bnx2x/bnx2x.c:2219: + /* when transmitting in a vf, start bd must hold the ethertype WARNING:LONG_LINE: line over 80 characters #36: FILE: drivers/net/bnx2x/bnx2x.c:2225: + if (eh->ether_type == rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) { WARNING:LONG_LINE: line over 80 characters #41: FILE: drivers/net/bnx2x/bnx2x.c:2230: + ETH_TX_BD_FLAGS_VLAN_MODE_SHIFT); WARNING:LONG_LINE: line over 80 characters #47: FILE: drivers/net/bnx2x/bnx2x.c:2236: + (rte_be_to_cpu_16(eh->ether_type))); WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Dey, Souvik ' total: 0 errors, 6 warnings, 0 checks, 28 lines checked 0/1 valid patch ----------------------------------------------------------------------------