From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 577E743026; Thu, 10 Aug 2023 10:07:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8B7840DFB; Thu, 10 Aug 2023 10:07:35 +0200 (CEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mails.dpdk.org (Postfix) with ESMTP id 86BFE40DD8 for ; Thu, 10 Aug 2023 10:07:34 +0200 (CEST) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-4872f5cfffdso161967e0c.2 for ; Thu, 10 Aug 2023 01:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691654854; x=1692259654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yzMMwFwDcrSgt4jX6fvmJm3q69PgV7k6OHdLGHwxNJY=; b=iTTlY9di/9GgoDgEvRLFFdf7DEyt34f5RV2XVNO9+GHqXkorL3ryLo9xrW+XXtV/9v GWXqkTPpQq+qBvySQ6xl3zZG7eRzOr52e9hIjSApX4jrXrkLIg/9E559BtQtM9f42A3L bLf3EuxGD8EYforjDEMo/AL8mHuvVFSzK/bw12WULhoDFTCzQtC+6ozA8CP9Zd0NtdBG E9aBGur2eH2pP3B7o5nbX7/Z5R6llVbDdETIHy8YTP2CJxevchxO8e//NyDGMODgvtVG JFcu0LCKmEUfBoxdBhAuTFFSv3xtJYZKNe3OPTNYzWEVM5NszRnaplYKblzC3pAP4DIu q2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691654854; x=1692259654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yzMMwFwDcrSgt4jX6fvmJm3q69PgV7k6OHdLGHwxNJY=; b=gEkS/BUWOi0YRlX5HI6Mc+8Nvxd58idbPz2bbs4jRuHhzVlbRKnaJJlKtPPPMffdKN tSwHs/DoPLM0hC8a9Pq2dd0fQw9BZmLCPJtP73YAg58HJe59oxL1NLmMm1tJW0mYERQM PdHYJnxQ2WhrNs4AoDLyywVNRjcJ8AW9J2afoDBFjEx7vB1oz5M/PQrdUUmcUET9FRJq l4/eeYZR03yJgk/6YOTirMtxLj9sYiiqnq8lhdRFfjDgSv/PwLRCxJV0k4TSrRxe0Uiq 1rbfgcUJ++avCdch7/Yg9KjIjbzU5Qc3+6534WHWlMMJjVKehyr0jfolKLBJKVaByzw1 qJ1g== X-Gm-Message-State: AOJu0YwGIzSl179XgsMfdhgivWmJXp/ucuPNtxv8P6QEPE3JhrmyWhdz qo3SWn2d8RlsxkuPeHW7F+ggcdnGItOEBY36Xho= X-Google-Smtp-Source: AGHT+IE0lq+YpbXbrFbwc3BhyfJ5hYDk+FSC46HdOKWHcO75/1S0wfiZRTGs38vrk4GvFsoGcBbspIBzoo+Pn7twSmo= X-Received: by 2002:a67:ee53:0:b0:443:6c48:4d49 with SMTP id g19-20020a67ee53000000b004436c484d49mr581486vsp.10.1691654853710; Thu, 10 Aug 2023 01:07:33 -0700 (PDT) MIME-Version: 1.0 References: <20230801094004.51939-1-s.v.naga.harish.k@intel.com> <20230801135149.135550-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 10 Aug 2023 13:37:07 +0530 Message-ID: Subject: Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs To: "Naga Harish K, S V" Cc: "dev@dpdk.org" , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 10, 2023 at 1:09=E2=80=AFPM Naga Harish K, S V wrote: > > Hi Jerin, > As per DPDK Guidelines, API changes or ABI breakage is allowed durin= g LTS releases > (https://doc.dpdk.org/guides/contributing/abi_policy.html#abi-br= eakages) Yes. Provided if depreciation notice has sent, approved and changes absolutely needed. > > Also, there are previous instances where API changes happened, some of th= em are mentioned below. These are not the cases where existing APIs removed and changed prototype to cover up the removed function. > > In DPDK 22.11, the cryptodev library had undergone the following API c= hanges. > * rte_cryptodev_sym_session_create() and rte_cryptodev_asym_session_creat= e() API parameters changed. > rte_cryptodev_sym_session_free() and rte_cryptodev_asym_session_free()= API parameters changed. > rte_cryptodev_sym_session_init() and rte_cryptodev_asym_session_init()= APIs are removed. > > * eventdev: The function ``rte_event_crypto_adapter_queue_pair_add`` was = updated > to accept configuration of type ``rte_event_crypto_adapter_queue_conf`= ` > instead of ``rte_event``, > similar to ``rte_event_eth_rx_adapter_queue_add`` signature. > Event will be one of the configuration fields, > together with additional vector parameters. > > Applications have to change to accommodate the above API changes. > > As discussed earlier, fewer adapter-create APIs are useful for the applic= ation design. > Please let us know your thoughts on the same. mempool have different variants of create API. IMO, Different variants of _create API is OK and application can pick the correct one based on the needed. It is OK to break the API prototype if absolutely needed, in this case it is not.