From: Jerin Jacob <jerinjacobk@gmail.com>
To: asomalap@amd.com
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 5/6] crypto/ccp: enable IOMMU for CCP CCP use vdev framework, and vdev framework don’t support IOMMU. Adding custom IOMMU support for AMD CCP drives.
Date: Mon, 14 Oct 2019 11:40:55 +0530 [thread overview]
Message-ID: <CALBAE1OcwoKxnOy-Y+8s5or_CCW3r+ELsth3yayBtmbivYSwAA@mail.gmail.com> (raw)
In-Reply-To: <20191014052134.12406-1-asomalap@amd.com>
On Mon, Oct 14, 2019 at 10:52 AM <asomalap@amd.com> wrote:
>
> From: Amaranath Somalapuram <asomalap@amd.com>
git commit subject not found. Make sure to run the following before
submitting the patch
./devtools/check-git-log.sh
./devtools/checkpatches.sh
>
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
> drivers/crypto/ccp/ccp_crypto.c | 244 ++++++++++++++++++++++++-------
> drivers/crypto/ccp/ccp_dev.c | 56 ++-----
> drivers/crypto/ccp/ccp_dev.h | 2 +-
> drivers/crypto/ccp/ccp_pci.c | 1 +
> goto fail;
> + if(iommu_mode == 2)
> + pci->kdrv = RTE_KDRV_VFIO;
> + else if(iommu_mode == 0)
> + pci->kdrv = RTE_KDRV_IGB_UIO;
> + else if (iommu_mode == 1)
> + pci->kdrv = RTE_KDRV_UIO_GENERIC;
The crypto driver should not have iommu mode-specific handling.
I am not sure about the problem statement. If the problem is,
iommu support for PCI based vdev device then move the solution to
common layer so that everyone can use it. If not, please share the
problem statement.
prev parent reply other threads:[~2019-10-14 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 5:21 asomalap
2019-10-14 6:10 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OcwoKxnOy-Y+8s5or_CCW3r+ELsth3yayBtmbivYSwAA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=asomalap@amd.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).