From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0412C42BE2; Tue, 30 May 2023 12:00:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E960B40A82; Tue, 30 May 2023 12:00:41 +0200 (CEST) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by mails.dpdk.org (Postfix) with ESMTP id 3BA6A406BC for ; Tue, 30 May 2023 12:00:40 +0200 (CEST) Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-786e09ce8c4so2706904241.0 for ; Tue, 30 May 2023 03:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685440839; x=1688032839; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/YlddjF5lSHaC+dZ7Z3AYzO9RdnN7BvmFxSRqMYVw9o=; b=c2sk3PvY4A/1wVU/OxOmAwpQEQm4eJgNwaNJt2T3+vjWq4hVVLM80ofr+lt/AK/uZ9 ASnsTDJnC252jWE8b5C30q8c3yUYZoVLQTVSh6lBoduGhVHgpKnqu5LsCvudXEX0n4Lz FJ2mszPDK0F/qJpGhLsDph5Y5IaDOkeOFv5RoaugqWCN8DFl8E0gKp3XM+++hmaVUPoY YM+JmyZbPOIvEB4bBs4AvtZ5EiAjekkOqW0sRNXrySzjSRSK6TkObAKm0MY4dBjVjJHw oivOjjFwoLHxYhoOKOh8/IEWWIdyfqiiZqFXv91MyuVRsjDKzvHtuFCjbQKqi7AZ+UJp y4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685440839; x=1688032839; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/YlddjF5lSHaC+dZ7Z3AYzO9RdnN7BvmFxSRqMYVw9o=; b=dOQu5eJv+rXkta8PjwAK3kmaknbeu7BfhbIk+5C0YuVVwkEzQE1JZAT7l8DzQwJ5EZ RiTJSm19NYcWmj5Zwdl7F7UQXqFsF7/+GeRS5whFGuSKvoANZD69bMFRQwXCULXoLXmK 6L+hdTRZQ9ccA68NrQZ7NVbUTrzqaEQghHRJy5YpWDB8BMt7Y32iswrZftpJTWLgV9m+ cm+yRMPlnmU9bAAG6bObOCcLq+weIyIRwIU+3tPwN49Fmx6p2a65oTujDd6gzJHGxM+M otwp8M9mtAq34OdZEd9xluO3qU8buyyvlV3w9RVzgvwJyOxFcrmTN8Gf0xHhp+BDiJ/p wzQA== X-Gm-Message-State: AC+VfDyr3yG3bnv5AQvLqTse5BtsUo3iw3ktL3y1oPZMIB5CXlfIye1z xYYRPJZlW27AFGJDIf4txpxS2B7UWl72UyJV+/R692WR7tg= X-Google-Smtp-Source: ACHHUZ6kEUdBFfC13+sY8Kc6VCSyc26qmAhxJeIMffQcA2u0J4nk4cbY340U83RnVRspvKQ7GifiLkRODwnCUes7JeA= X-Received: by 2002:a1f:78c3:0:b0:457:2a53:b42b with SMTP id t186-20020a1f78c3000000b004572a53b42bmr3478086vkc.7.1685440839403; Tue, 30 May 2023 03:00:39 -0700 (PDT) MIME-Version: 1.0 References: <20230530094208.3438943-1-schalla@marvell.com> In-Reply-To: <20230530094208.3438943-1-schalla@marvell.com> From: Jerin Jacob Date: Tue, 30 May 2023 15:30:13 +0530 Message-ID: Subject: Re: [PATCH] event/cnxk: add wmb after steorl for event mode To: Srujana Challa Cc: pbhagavatula@marvell.com, sthotton@marvell.com, rbhansali@marvell.com, jerinj@marvell.com, dev@dpdk.org, ndabilpuram@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 30, 2023 at 3:12=E2=80=AFPM Srujana Challa wrote: > > From: Author Srujana Challa > > LMTST area can be overwritten before read by HW between to consecutive > steorl operations. Hence, add wmb() after steorl op to make sure > the lmtst operation is complete. lmtst -> LMTST Change the subject to "fix ...." And add Fixes: tag > > Signed-off-by: Srujana Challa > --- > drivers/event/cnxk/cn10k_tx_worker.h | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/event/cnxk/cn10k_tx_worker.h b/drivers/event/cnxk/cn= 10k_tx_worker.h > index c18786a14c..81fe31c4b9 100644 > --- a/drivers/event/cnxk/cn10k_tx_worker.h > +++ b/drivers/event/cnxk/cn10k_tx_worker.h > @@ -43,7 +43,6 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_m= buf *m, uint64_t *cmd, > const uint64_t *txq_data, const uint32_t flags) > { > uint8_t lnum =3D 0, loff =3D 0, shft =3D 0; > - uint16_t ref_cnt =3D m->refcnt; > struct cn10k_eth_txq *txq; > uintptr_t laddr; > uint16_t segdw; > @@ -98,10 +97,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_= mbuf *m, uint64_t *cmd, > > roc_lmt_submit_steorl(lmt_id, pa); > > - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) { > - if (ref_cnt > 1) > - rte_io_wmb(); > - } > + /* Memory barrier to make sure lmtst store completes */ > + rte_io_wmb(); > + > return 1; > } > > -- > 2.25.1 >