From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2757642996; Thu, 20 Apr 2023 12:13:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AB3440A4B; Thu, 20 Apr 2023 12:13:29 +0200 (CEST) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mails.dpdk.org (Postfix) with ESMTP id BCB0240687 for ; Thu, 20 Apr 2023 12:13:27 +0200 (CEST) Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-42e668a2c5eso93370137.3 for ; Thu, 20 Apr 2023 03:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681985607; x=1684577607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VQsNATaoz5xcE91LMnv9w0+iTBVp8yP0uboid0IawHA=; b=VhIJqBbXGJyg3xKtrVIfxNdS5nzJRtVFnLPrBe2ifwAZYLAQvIlDYebAsRnHgpaHse 7UGHKqIi0oXOSXOvDoYfFgYcPF30Spktn+N8tujA5njmBBuCWabtQEvwJkn/rdjGWAWH myFW7MY+QB3Hk2MI0dtfaOtoHkFZlSEgF6z1jqPZDBlqZoN1AECBbqBjzSmuqxy5oHF3 iGR4tVzvd55+poUdxYMyuJ7AUx/EILx0+I9ozwuWEvT0IDgjhEv4V7gkNXMHr7VrmrwS TWUTYn4+XnitV4pqjVelbRHxQehdqrFPT+Pd1CFTDYBIM1Po70IDc4jhgDYaRwS9/q+k ltAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681985607; x=1684577607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQsNATaoz5xcE91LMnv9w0+iTBVp8yP0uboid0IawHA=; b=Fohapla9JLMs6mMD8rSsduhpiO5nuM6c0S5YkvFXgZ5RMbCQZhGiXOiFKvIn7tnaVq h/MUoABo4qi8MnD+4xrKOeMlS4S4xVgXSAyYn80L+t9C5tnis+OIEVsKH9TPFtR3WTVr cs5F/7oSGriS0RF+EXOfS4dXQ84rLfwJK0Uh3hOE16nxW1fOtKdy0elZRIojQqSqu768 XD1y8zJmhAKDnrtapTA/cFTW9T/U95YpCDZVZQPNrGaTYGLQey65AVm24odZ7mDbvepK JxfG3H7M+kQNTDgsEzNrKTZIoBG81+jL4Q6Blax4Xctc4+JkFtZu/UgpsSnPUuBra0kp RAdw== X-Gm-Message-State: AAQBX9eqicGhJb2sNP2vlQF4hg9aMnCUJAo5M/Xb4BMvs3tEp61EF1Fk kj77/uxY8OIKfiZSziwnBa84yiU0Re+bJx/OgiY= X-Google-Smtp-Source: AKy350ars+Y5a3dfzRDIx+UMY6BQH6sPOA9w89utlKkLM1CMdvyOjR+cd1ZhapA8lsmFUYkd1jXICSjszPMoMB+OLTc= X-Received: by 2002:a67:f2d6:0:b0:42e:789c:b11b with SMTP id a22-20020a67f2d6000000b0042e789cb11bmr549624vsn.0.1681985607095; Thu, 20 Apr 2023 03:13:27 -0700 (PDT) MIME-Version: 1.0 References: <20230420100803.494-1-viacheslavo@nvidia.com> <20230420100803.494-2-viacheslavo@nvidia.com> In-Reply-To: <20230420100803.494-2-viacheslavo@nvidia.com> From: Jerin Jacob Date: Thu, 20 Apr 2023 15:43:01 +0530 Message-ID: Subject: Re: [RFC 1/5] app/testpmd: add trace dump command To: Viacheslav Ovsiienko Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 20, 2023 at 3:39=E2=80=AFPM Viacheslav Ovsiienko wrote: > > The "dump_trace" CLI command is added to trigger > saving the trace dumps to the trace directory. > > Signed-off-by: Viacheslav Ovsiienko > --- > app/test-pmd/cmdline.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 7b20bef4e9..be9e3a9ed6 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -39,6 +39,7 @@ > #include > #endif > #include > +#include > > #include > #include > @@ -8367,6 +8368,8 @@ static void cmd_dump_parsed(void *parsed_result, > rte_lcore_dump(stdout); > else if (!strcmp(res->dump, "dump_log_types")) > rte_log_dump(stdout); > + else if (!strcmp(res->dump, "dump_trace")) > + rte_trace_save(); Isn't saving the trace? If so, change the command to save_trace or so. > } > > static cmdline_parse_token_string_t cmd_dump_dump =3D > @@ -8379,7 +8382,8 @@ static cmdline_parse_token_string_t cmd_dump_dump = =3D > "dump_mempool#" > "dump_devargs#" > "dump_lcores#" > - "dump_log_types"); > + "dump_log_types#" > + "dump_trace"); > > static cmdline_parse_inst_t cmd_dump =3D { > .f =3D cmd_dump_parsed, /* function to call */ > -- > 2.18.1 >