From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08570A00C4; Thu, 5 May 2022 10:34:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D1AC40C35; Thu, 5 May 2022 10:34:40 +0200 (CEST) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mails.dpdk.org (Postfix) with ESMTP id B83EC40042 for ; Thu, 5 May 2022 10:34:37 +0200 (CEST) Received: by mail-io1-f51.google.com with SMTP id r27so4031943iot.1 for ; Thu, 05 May 2022 01:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P8igi4MpQzv6RQnuVbqtz7AwaL7ZU9NteWgJkKaowpc=; b=mOyTZgu2YZ1hmXW5HNQ3rBh3qiT//B0yySDIFG0E08RMpqDRzwbzwI1gK0E5EpDYrF if15In3nwWGHuBq8zxatNEWt/SABkIgfDZV5+YyuKcQ3JA5Cp6+YzdEzyewXzLKcdmlD f06V32kgzQCPHXnTOUOPQkq6jhw9CFWfYtN20QQjhzkRzAHFmRRwWhofYXCHEhuYiXJA bSTMawYZ/GIfnSgzrZsJ1StTWJYMkJZilwPikcTqDNE3AwkB+1PlxY+9ymyrPGA4YLKG 1UBZyKfvp1FvW/NbotunyD94o9rca/xWPQiahoyMNMmrV7d5OSk9OybDzP127m+2fVD2 0FOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8igi4MpQzv6RQnuVbqtz7AwaL7ZU9NteWgJkKaowpc=; b=0CPZ5H8jYzzywPimAjpi1Qv0+WAfTOvOoQWL95SUllmEsV6oDK+hRszRPjhhQxcTbQ 6Y5SOK4xZPFIOeyXOa5m6VbOQjS6F3Gb2uTMXGfK5eymUI/JoDanq4KI+cF63JrePn/I 7BvSkc31lshIAPQQ7ITki5QqNmk0uOfcfSC4adS6DH3QBmIyXTCw5LINRGlP3VDl84D5 Wmg0wVQ9HKSLGjr8rvGYxbM8RfzcZPpsB/onvqTUKPqaqpG4ie3E4Epzl0SbWqWkHGSM JV5SZdBUaweqAaRfo5BBEOH4Ck8UnetuRxPtN5rsiOzISbr8ekGudmUy9UAz9Acecgfl 8BQw== X-Gm-Message-State: AOAM531LaBJmPduaFXO+wxJKflMJEogh9mZSzrWmHzcLmiYaFr+6D7x1 oCSIV9owQCzF1msYbIXrV0z3dKhVlg9/QPwAmmM= X-Google-Smtp-Source: ABdhPJzU8JOnhdZWwb5u6ZGWTeSM6e+Qi0WLTHerJxXtML/I0AOcO3kIDP9a2x8e2GXvDMKmRsgYVLzOOBzxv0hu+sM= X-Received: by 2002:a02:b899:0:b0:328:522b:9417 with SMTP id p25-20020a02b899000000b00328522b9417mr11120637jam.79.1651739677089; Thu, 05 May 2022 01:34:37 -0700 (PDT) MIME-Version: 1.0 References: <20220424161723.1680524-1-gmuthukrishn@marvell.com> In-Reply-To: <20220424161723.1680524-1-gmuthukrishn@marvell.com> From: Jerin Jacob Date: Thu, 5 May 2022 14:04:10 +0530 Message-ID: Subject: Re: [PATCH] common/cnxk: fix null pointer dereference To: Gowrishankar Muthukrishnan , Ferruh Yigit , Andrew Rybchenko Cc: dpdk-dev , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Apr 24, 2022 at 9:47 PM Gowrishankar Muthukrishnan wrote: > > Fix null pointer dereference reported in coverity scan. > > Coverity issue: 372065 Cc: stable@dpdk.org > Fixes: 665b6a7400b ("common/cnxk: add NPC helper API") > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc_npc_utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/common/cnxk/roc_npc_utils.c b/drivers/common/cnxk/roc_npc_utils.c > index f9768ea3cf..dadd8826cb 100644 > --- a/drivers/common/cnxk/roc_npc_utils.c > +++ b/drivers/common/cnxk/roc_npc_utils.c > @@ -145,6 +145,9 @@ npc_parse_item_basic(const struct roc_npc_item_info *item, > info->mask = item->mask; > } > > + if (info->mask == NULL) > + return NPC_ERR_INVALID_MASK; > + > /* mask specified must be subset of hw supported mask > * mask | hw_mask == hw_mask > */ > -- > 2.25.1 >