From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23DA8A0032; Thu, 17 Feb 2022 09:12:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECB8640150; Thu, 17 Feb 2022 09:12:49 +0100 (CET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id 1D90540042; Thu, 17 Feb 2022 09:12:48 +0100 (CET) Received: by mail-io1-f47.google.com with SMTP id t6so2684227ioj.12; Thu, 17 Feb 2022 00:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HW2PUeTa077gimrT51kXZ0xf9/dfMFm1Gvm/S4mHtlk=; b=ZjRiVOQWM5F71VtU87nKVj5iswaBugSyJfiSYBEdM67vgmiWfTsOyE28D9GxNdi0q0 yL6YR2dtL537wrenuMrjFPPZRFHW/FqV/cSCKf0RuICShjOjW50AXSvVPR1B2OTILg9D ZQdw4DGDmEsdGMv88Ff0MajGSGQ+NO47N2cklZTGt+embTk98lOsT+hKR09z/0FvvWD5 AcRegjNrP0469pZhyHyQq55eX4Ry8r63uFDUF56exISt9rX5ofP5BmVwYnv0TpL9JBBB 3EB05do4INkdHs0jFxkBOt4nV6PIGo3ttz2stBkVWYlhrS9fuFj9PqVmVj4HaS4nWiH6 Pc/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HW2PUeTa077gimrT51kXZ0xf9/dfMFm1Gvm/S4mHtlk=; b=45aU8YW7jfLwfcKST5Tjmy2GN1BUmpBTZp2rgDhRfb6p4dqwlTYajRT9g2AMXrxQN0 tJSYHXRiQH/Po0+KBMob+YR+Goo+119ABKOZ50QrTdSqA1SAa4eogvpqxgeiWU6i660s wgHQNPoZrNh/45mb7EGBsoaBoMlpgb4QrVT4+8XNe3lYG6g5lYOymDlCdGiv33orPm/g 1YC4y+os7w7G18W2BYBvi2ATjLFQbOVCqmGSKwdGTYDsmX/EhGh/Bzs2Dp0AvdYYNWIW ktYu49G/oAd/779x/Ao0TganlGWlurEtb0cwjYiHF1E+pP1t2ducZ3IYZoHoHNk6ZMbH 7eNA== X-Gm-Message-State: AOAM530tabLTMlzHeYjvB2R8OKkFvKoHiQQd8ToYHAcanif1m2S+EEsF AAUUJ+8EJ1OLQS+39KUbFTJvktJPVjIc8cYh8+8= X-Google-Smtp-Source: ABdhPJwdC1vanKfHj2IxFbwVnPqXYriiMstk6nXPZM/xLUWs1M98fdSA4D5GpFLBHkPrfe1iI4TvWubvRgzBXMbIUOQ= X-Received: by 2002:a05:6638:584:b0:311:9d1c:64b with SMTP id a4-20020a056638058400b003119d1c064bmr1350375jar.158.1645085567136; Thu, 17 Feb 2022 00:12:47 -0800 (PST) MIME-Version: 1.0 References: <20220125041759.905955-1-psatheesh@marvell.com> In-Reply-To: <20220125041759.905955-1-psatheesh@marvell.com> From: Jerin Jacob Date: Thu, 17 Feb 2022 13:42:20 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix base rule merging only for ingress To: Satheesh Paul , Ferruh Yigit Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 25, 2022 at 9:48 AM wrote: > > From: Satheesh Paul > > When creating flow rule, merge base steering rule only > for ingress rules. > > Fixes: f9af9080746 ("common/cnxk: add mcam utility API") > Cc: stable@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar Kokkilagadda Updated the commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix base rule merge Egress rules do not have a base steering rule and the current base steering rule is applicable only for ingress rules. Hence, when creating a flow rule, merge base steering rule only for ingress rules. Fixes: f9af9080746 ("common/cnxk: add mcam utility API") Cc: stable@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda > --- > drivers/common/cnxk/roc_npc_mcam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c > index b251f643bc..7a3a8944f5 100644 > --- a/drivers/common/cnxk/roc_npc_mcam.c > +++ b/drivers/common/cnxk/roc_npc_mcam.c > @@ -752,7 +752,7 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc) > if (pst->set_ipv6ext_ltype_mask) > npc_set_ipv6ext_ltype_mask(pst); > > - if (pst->is_vf) { > + if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) { > (void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox); > rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp); > if (rc) { > -- > 2.25.4 >