From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84C38A04B7; Wed, 14 Oct 2020 08:42:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2FC71DC92; Wed, 14 Oct 2020 08:42:25 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 1FE5B1DC14; Wed, 14 Oct 2020 08:42:23 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id t12so3947753ilh.3; Tue, 13 Oct 2020 23:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YveNIP7l9lBOHY5KdOYC4K4IkUQHOizlnQ3aaU2fXYQ=; b=mSVVu9WPESEfq9nldsbaQkWInxfChuV105We5fbqOZf9ZLr0XNjsQG14OmYcPcL3We Qr9XuwhoEwi70Zb63MJMaQNqbGcbJYvWe8+yypfaFIua2ShHTJWIZjRpBTksgYmHOX8T NTdnoQTVs957JQFZJAvKYuuNr9ndtq5Z/wf/I+nnzk63OjVGLZReHv9C75kv0RVNTc9D qvVcjasDIOtO5bKa7W8yO2PK4vmETp7mmyLNrotcmq/uIr/cbUvBwl6bs4TvItCMOfoZ Fueq1Jvg606go1m0NG3FVCajB9CeO5v0NqyGAqrnJswQuG8c67P79/2Vg/qOHQnf8nxP m4Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YveNIP7l9lBOHY5KdOYC4K4IkUQHOizlnQ3aaU2fXYQ=; b=bQEz2elnBMeFFbM+5oLWBXcwcd4RQTBiUKSBWi5iOhOAEbps8m/cTgD7pUyvzSWKd9 ieMNaFsRxiL0iM9Iit0qvy8oYudajSh03MZLNQ6Ref1F2aIoCaGHT8/sObkKl+O3tUuq bYRO5j/ebxw1Bmt1DKeQRdem30zf1ASd9u3+X89BY0ALhJgUwaVtrv4/u47p1yVu2Rgc QbWM7rJU7tdJ87ZtTg7AU+NJwyJGHJMsr/XJFoRJTTiQzlyKirtin5IY74ZlMCYc3VRA SZutZ1j/awUAWaUs1zpavRSDPpnHh6bMo+V/MHAkhnL9tNUJkYgwEt1dY7+dLB0S0b24 5KcA== X-Gm-Message-State: AOAM530yWGzjv9GMSAhSkIQ+KeNC8RcCSqlPfvQ+oO5M/S4Unv+S7X++ ZoygyoPXa5QChr2P0KqwMlajAkzDthxkBPSzu9Q= X-Google-Smtp-Source: ABdhPJx2qxusZWpuu5ikPFX2lJ4FHu/dTy/yNTTqdQBlUOwhK+jCW26hSxvzADwy2IHHOvPisd69ZNd5PhlW69XBZ+g= X-Received: by 2002:a92:b006:: with SMTP id x6mr2879005ilh.130.1602657741438; Tue, 13 Oct 2020 23:42:21 -0700 (PDT) MIME-Version: 1.0 References: <20201012224814.10472-1-rmody@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 14 Oct 2020 12:12:05 +0530 Message-ID: To: Ajit Khaparde Cc: Ferruh Yigit , Rasesh Mody , dpdklab , Jerin Jacob , dpdk-dev , dpdk stable , GR-Everest-DPDK-Dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 3:07 AM Ajit Khaparde wrote: > > On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit wrote: > > > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody wrote: > > >> > > >> Add QLogic vendor id support for BCM57840 device ids. > > >> > > >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build") > > >> Cc: stable@dpdk.org > > >> > > >> Reported-by: Souvik Dey > > >> Signed-off-by: Rasesh Mody > > > > > > > > > There was an error from CI on Broadcom CI, > > > Since this patch is about Broadcom PMD fix, Do we need to worry about this? > > > http://mails.dpdk.org/archives/test-report/2020-October/158246.html > > > > > > > Errors shouldn't be related to this patch, so I think error can be ignored for > > this patch. > +1 > > > > > But added Ajit & lab for the issue. > I have seen this behavior earlier. > It showed up randomly on some patches which are not even > related to Broadcom PMD. I will try to keep an eye on it. Applied to dpdk-next-net-mrvl/for-main. Thanks > > > > > > > > >> --- > > >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > > >> 1 file changed, 4 insertions(+) > > >> > > >> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > > >> index 40225b2f4..ce9df8748 100644 > > >> --- a/drivers/net/bnx2x/bnx2x_ethdev.c > > >> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > > >> @@ -17,6 +17,7 @@ > > >> * The set of PCI devices this driver supports > > >> */ > > >> #define BROADCOM_PCI_VENDOR_ID 0x14E4 > > >> +#define QLOGIC_PCI_VENDOR_ID 0x1077 > > >> static const struct rte_pci_id pci_id_bnx2x_map[] = { > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, > > >> @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, > > >> #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > > >> #endif > > >> { .vendor_id = 0, } > > >> }; > > >> @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > > >> { .vendor_id = 0, } > > >> }; > > >> > > >> -- > > >> 2.18.0 > > >> > >