From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9450AA034F; Mon, 7 Feb 2022 10:40:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 637B8410EA; Mon, 7 Feb 2022 10:40:40 +0100 (CET) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mails.dpdk.org (Postfix) with ESMTP id DD88140DDA for ; Mon, 7 Feb 2022 10:40:39 +0100 (CET) Received: by mail-il1-f169.google.com with SMTP id m8so3978606ilg.7 for ; Mon, 07 Feb 2022 01:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zpvcIU/1d/ivTTCmmffhWHhVk92/XtWbShzftvSkZq8=; b=qzro+eYHbzLZHpwXrWZPvcgWn4BxhyCih7Upxga7X26ELbRvT3n8mp8iIVLmm9q0ga npq9+g7KHt+lYvW7TZT4uCUMM4bElBtmBrkknPdwqzqxhXXhdrAVAFNBWJU05LJN+v3P y6WlJ3kbVRKFw1/rAyEXSON0x8qO3bukntQQu2GDawDrpLARxfVIC47+y+hl4sqmR105 2gVdO6ROYgtIOa1fum++XHJMDFRbARowD+/Qv4sEapD6Y6b0Y8Jy6dTZNgQ36mNe4DXY rJ/hV6oP/qYZY0LlgrUJfTFNXNydldlm60s5xa8G1ifTtQdm5+K1SFmWRoLJMzE1ozyZ +vow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zpvcIU/1d/ivTTCmmffhWHhVk92/XtWbShzftvSkZq8=; b=Ee1mtxz+XBf+g4sS4GeNXzZL6x1qr29Cw3LTtlN3lT0B1U4ylFsaUmHoTa18TY7MgO 8NCo/JGJ26ppqaSgSQWHcEsq12IBdK2EqPaLegCbpo6nlv3xSeyVG1cjat9r0ZPeRaVP sjUFJDpfRLMBzDOQVayINKLIdsAaFF6GKG/SOBwkt7AqExSWHftuthU7bRoumjeflos4 BU+gyxzHy+7+3Od0R/h7ywRCeDLK0oSwGXGd4epD3y8NsuBKnA3Azx7au3Ip3icCRu2e j5xGFLiq2vkmPgo/6cW5dYoD9pBQ7AL4CfoaIRp5PVrjC8S2yitnCKeWcX1xju/sQVuq dx9Q== X-Gm-Message-State: AOAM5327w+SGTWETL2KguEv/PgL/Cnj0wPdpaP3vEqrpdvQXBx3Em7BV R3S67wLHrh72U7Vr75NSB2neg5He3ccLAObLbOQ= X-Google-Smtp-Source: ABdhPJzajmNkgX4xIbxC9o8Pn2vQ0QJnTFdizrDm7rxBcLTQPgohLfmSIXElSHIaftU9u8F7XC6sxpXfss+Z2pnF91U= X-Received: by 2002:a05:6e02:160b:: with SMTP id t11mr5895025ilu.75.1644226838961; Mon, 07 Feb 2022 01:40:38 -0800 (PST) MIME-Version: 1.0 References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220204174209.440207-3-bruce.richardson@intel.com> In-Reply-To: <20220204174209.440207-3-bruce.richardson@intel.com> From: Jerin Jacob Date: Mon, 7 Feb 2022 15:10:12 +0530 Message-ID: Subject: Re: [PATCH 2/7] eventdev: fix header build with C++ To: Bruce Richardson Cc: dpdk-dev , Erik Gabriel Carrillo , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 4, 2022 at 11:12 PM Bruce Richardson wrote: > > The eventdev headers had issues when used from C++ > > * Missing closing "}" for the extern "C" block > * No automatic casting to/from void * > > Signed-off-by: Bruce Richardson Acked-by: Jerin Jacob > --- > lib/eventdev/rte_event_timer_adapter.h | 3 +++ > lib/eventdev/rte_eventdev.h | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/eventdev/rte_event_timer_adapter.h b/lib/eventdev/rte_event_timer_adapter.h > index 1551741820..1fe4dd8e8f 100644 > --- a/lib/eventdev/rte_event_timer_adapter.h > +++ b/lib/eventdev/rte_event_timer_adapter.h > @@ -678,4 +678,7 @@ rte_event_timer_cancel_burst(const struct rte_event_timer_adapter *adapter, > return adapter->cancel_burst(adapter, evtims, nb_evtims); > } > > +#ifdef __cplusplus > +} > +#endif > #endif /* __RTE_EVENT_TIMER_ADAPTER_H__ */ > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index eef47d8acc..25fb7c89dd 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -1805,7 +1805,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id, > return 0; > } > #endif > - rte_eventdev_trace_enq_burst(dev_id, port_id, ev, nb_events, fn); > + rte_eventdev_trace_enq_burst(dev_id, port_id, ev, nb_events, (void *)fn); > /* > * Allow zero cost non burst mode routine invocation if application > * requests nb_events as const one > -- > 2.32.0 >