From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24BA0A0C41; Tue, 3 Aug 2021 06:05:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAD2140E32; Tue, 3 Aug 2021 06:05:49 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 9A0B04069C for ; Tue, 3 Aug 2021 06:05:47 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id r1so18410999iln.6 for ; Mon, 02 Aug 2021 21:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3LwN2IvO7d4l8tyUHVBQOMLFEVe1/LmAHliP3hMm3r8=; b=BfYWP5FnwR8pZ0Lzba+S2g/8H4THfu6+THOOw7wZP6ZJ5ptNbJ29/ZfvvcKY6rggIG F8QYf+0pYOCjV53rI1GfUWpIdW8EFfsn6owoUUi6/+cNkb4qDuPAvMfr0nPOqopxxnEf 0HToJ9jlePpEy3pPpwSozyeTsuiqZJrDuqYeqPahwkpcDQWDAoEqc7cTYQba54wOV/DT 0SzonOazumnwZVI6qFGJPr9z01ufnW3Jaomsp4/xxbXlz8qIWc2TXS1Lnf6ekHKq52wb +8eIhP1rMNbRrSy7QWaaG+U8Xt21azq3uP910xWAdp6Auv1qqLeGN2wJQHD2vEIEhDzt kWVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3LwN2IvO7d4l8tyUHVBQOMLFEVe1/LmAHliP3hMm3r8=; b=p41PIgFfCCqPUWSP8IYRWKeyVromU+FPdHqrLXURAdT2+AadGjMqOr7sxjO71qRDaC TPEaA3q1Tn92F40eoovcAit1dJoNSjpw9MIRStrQaCRTYgu6myyzhk31m4f3QlGzov6P 7au3RNsxoUcOxsVO9qktuij7S6j3zgwRgWosadxomI9P+YRgddLLfUjxAysIxehX74pd aFuh233sB1E1RVcywcjLkJdBcA6BENxYa8wPbc9fRl4dh5raNaQFABk2xziU+cg244/r QTRqcy6YJZeg5Eqn3HE/GKmOaswg60CEiUEiM4cdrM8hgkl8xS+ShJrJtOLkZHdXvFcY +DJA== X-Gm-Message-State: AOAM533cmOPbKKhfPlYGyKHpW9i4POrnmFoPhVydTmEvxMhqy2hRG7+m W9hM4WkDebeQn7v9v/8PoogBOopIKCCCv0ioVp4= X-Google-Smtp-Source: ABdhPJzZnWJvLNt4G+qYA2pFBN7Ls8aKrnXDcbsBwstl4FjAk5S3ceB0K2FKA5u5VVcJWcRj8ZE8GnlarK0timk7r4k= X-Received: by 2002:a92:c5c5:: with SMTP id s5mr517582ilt.271.1627963546897; Mon, 02 Aug 2021 21:05:46 -0700 (PDT) MIME-Version: 1.0 References: <20210802160352.135754-1-hkalra@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 3 Aug 2021 09:35:21 +0530 Message-ID: To: "Xia, Chenbo" Cc: Harman Kalra , "jerinj@marvell.com" , "david.marchand@redhat.com" , "thomas@monjalon.net" , Ray Kinsella , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: announce: make rte intr handle internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 3, 2021 at 8:07 AM Xia, Chenbo wrote: > > > -----Original Message----- > > From: dev On Behalf Of Harman Kalra > > Sent: Tuesday, August 3, 2021 12:04 AM > > To: jerinj@marvell.com; david.marchand@redhat.com; thomas@monjalon.net; Ray > > Kinsella > > Cc: dev@dpdk.org; Harman Kalra > > Subject: [dpdk-dev] [PATCH] doc: announce: make rte intr handle internal > > > > Moving struct rte_intr_handle as an internal structure to > > avoid any ABI breakages in future. Since this structure defines > > some static arrays and changing respective macros breaks the ABI. > > Eg: > > Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 > > MSI-X interrupts that can be defined for a PCI device, while PCI > > specification allows maximum 2048 MSI-X interrupts that can be used. > > If some PCI device requires more than 512 vectors, either change the > > RTE_MAX_RXTX_INTR_VEC_ID limit or dynamically allocate based on > > PCI device MSI-X size on probe time. Either way its an ABI breakage. > > > > Discussion thread: > > https://mails.dpdk.org/archives/dev/2021-March/202959.html > > > > Change already included in 21.11 ABI improvement spreadsheet (item 42): > > https://docs.google.com/spreadsheets/d/1betlC000ua5SsSiJIcC54mCCCJnW6voH5Dqv9U > > xeyfE/edit#gid=0 > > > > Signed-off-by: Harman Kalra > > --- > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index d9c0e65921..e95574b1ec 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -17,6 +17,9 @@ Deprecation Notices > > * eal: The function ``rte_eal_remote_launch`` will return new error codes > > after read or write error on the pipe, instead of calling ``rte_panic``. > > > > +* eal: Making ``struct rte_intr_handle`` internal to avoid any ABI breakages > > + in future. > > + > > * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does > > not allow for writing optimized code for all the CPU architectures > > supported > > in DPDK. DPDK has adopted the atomic operations from > > -- > > 2.18.0 > > Acked-by: Chenbo Xia Acked-by: Jerin Jacob