From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8904BA2F18 for ; Thu, 3 Oct 2019 05:24:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA08F1BFAC; Thu, 3 Oct 2019 05:24:22 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 902031BFA8 for ; Thu, 3 Oct 2019 05:24:21 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id c25so2134459iot.12 for ; Wed, 02 Oct 2019 20:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n+LBGntHTHSmtsvBPZRUP9dlB74P1eoCrzq/N2tNnHo=; b=dFbjFkr1ZjmfXDyEBT9RiVVoo2d4IxMyWhgshV5dBZrdgAlsqKAS2zmEY4f8d4KP9F bsW3fdzSMPDY9upkqq7iGidfQEl1IrT0v0sVHaaaZUt75RuuvkyTmDBKuTq7x6vyNqbv +SVTaCRCtOBdPVvoT2KC1ySXM/DXxi9BBjlgcisS02Iu0tSnfICYAAiSGPD5Zlc6w4gH cjRGkArfjO52fTs08tmKd8N7jN6zP2od1FQmXDJdjJcG7BL27YZvCsn7795pZDv3dtEy nv7CvR4+XtTLIO2xlCeqN8GmpW6xciFmo3fqMMmOVd+FePP7Vq3CrQlymXXvNS0IRpIQ AAtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n+LBGntHTHSmtsvBPZRUP9dlB74P1eoCrzq/N2tNnHo=; b=acGvPDh5oq0J+Vto0RGpyCEA/zOhDzFYrUXpX8/XjjT9YIebm/qWT/kXli7TeZlQ+s lhCYJAy2T6rXjayXxCOg15McpdwTPPNj8PNdzspJJQd3Uf09XbHZW+/iDlg157VKQC2Q UFhCoozbTB3WAIN6OAmSaYBhf2mQSQfBC+NzpJkhblP5ALj/ZF996eferxJ6XHGkHR8g pU+1WZCsV+dw00nDDjOocS7NhkbGvlF4n6kMKOoCtCFb+BCP/Fbfv50QD8/5DGmvuJoM XFS3oJZUSbmRq2p6zXcbXEdZB5gXbNpEpkJK0P1RjPgN3JQovnUDwPncNxcBlKhekkxV zySA== X-Gm-Message-State: APjAAAXmmxK2liQVkEV0b8sTuN3SKWIPLo4847yHY55gt5n0S4m5x5W2 SAW5YnI2oTIf4xOfw3Oou2pyX1ziIYIWLSXQOzI= X-Google-Smtp-Source: APXvYqzMFKzw1UaT59ueb5aYDf8f73Nvhp9tUFr/RvXYZnblQXRrRzHqUTZ/KyZ4xCltXpJIgYGDc2tZkpzhywRiACQ= X-Received: by 2002:a92:de42:: with SMTP id e2mr7672743ilr.271.1570073060749; Wed, 02 Oct 2019 20:24:20 -0700 (PDT) MIME-Version: 1.0 References: <20191001113339.21767-1-hemant.agrawal@nxp.com> In-Reply-To: <20191001113339.21767-1-hemant.agrawal@nxp.com> From: Jerin Jacob Date: Thu, 3 Oct 2019 08:54:09 +0530 Message-ID: To: Hemant Agrawal Cc: dpdk-dev , Jerin Jacob , "Gujjar, Abhinandan S" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 1, 2019 at 5:06 PM Hemant Agrawal wrote: > > The IV was not set, which was causing HW based SEC on DPAA1 > to fail. > > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") > > Signed-off-by: Hemant Agrawal Abhinandan, Could you please review the crypto adapter fixes, I would like to pull this for RC1 if possible. > --- > Please squash if possible. > > app/test/test_event_crypto_adapter.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c > index 652e458f0..bf83a6357 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -171,6 +171,7 @@ test_op_forward_mode(uint8_t session_less) > struct rte_event ev; > uint32_t cap; > int ret; > + uint8_t cipher_key[17]; > > memset(&m_data, 0, sizeof(m_data)); > > @@ -186,6 +187,11 @@ test_op_forward_mode(uint8_t session_less) > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC; > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > + cipher_xform.cipher.key.data = cipher_key; > + cipher_xform.cipher.key.length = 16; > + cipher_xform.cipher.iv.offset = IV_OFFSET; > + cipher_xform.cipher.iv.length = 16; > + > op = rte_crypto_op_alloc(params.op_mpool, > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > TEST_ASSERT_NOT_NULL(op, > @@ -364,6 +370,7 @@ test_op_new_mode(uint8_t session_less) > struct rte_mbuf *m; > uint32_t cap; > int ret; > + uint8_t cipher_key[17]; > > memset(&m_data, 0, sizeof(m_data)); > > @@ -379,6 +386,11 @@ test_op_new_mode(uint8_t session_less) > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC; > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > + cipher_xform.cipher.key.data = cipher_key; > + cipher_xform.cipher.key.length = 16; > + cipher_xform.cipher.iv.offset = IV_OFFSET; > + cipher_xform.cipher.iv.length = 16; > + > op = rte_crypto_op_alloc(params.op_mpool, > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > TEST_ASSERT_NOT_NULL(op, "Failed to allocate crypto_op!\n"); > -- > 2.17.1 >